Uh oh!
There was an error while loading. Please reload this page.
update base64-js version. follow up #6961 - #6937
Conversation
facebook-github-bot
commented
Apr 12, 2016
By analyzing the blame information on this pull request, we identified @lindskogen, @cpojer and @sahrens to be potential reviewers. |
@mkonicek Can you check on this since you guys update the internal fb npm cache manually. |
zxcpoiu
commented
Apr 19, 2016
philikon
commented
Apr 19, 2016
I don't see why that's the case. |
There was a problem hiding this comment.
Why not ^1.1.0 as that version seems to have a bunch of improvements over 1.0.4 (whereas 1.1.1 and 1.1.2 seem to only be about aesthetics).
philikon
commented
Apr 19, 2016
Pro-tip: make sure you explain the motivation for your PR. You're currently not giving any, instead pointing to other PRs which also don't give motivation. If you want to make it easier for reviewers, and quicker for you, I suggest editing your PR note to include a small note about why you want this change. Also please don't forget a test plan. |
facebook-github-bot
commented
Apr 20, 2016
@zxcpoiu updated the pull request. |
zxcpoiu
commented
Apr 20, 2016
@philikon why this PR exist and described as a follow up of #6961 are because:
This PR should be closed if no one needed
If no one thinks this is necessary, then this PR should be closed. thanks again for all the great jobs. |
dewe
commented
Apr 20, 2016
I can't recall why this was upgrade was needed. Since @philikon is handling things in the other PRs, this one should definitely be closed. |
mkonicek
commented
Apr 22, 2016
Upgrading sounds good. I'll need to merge this manually into our internal node_modules store though. |
ghost
commented
May 5, 2016
@cpojer would you mind taking a look at this pull request? It's been a while since the last commit was reviewed. |
This is a follow up of PR react#6327 by @dewe and @jeremyong as @mkonicek indicated this should split into a separate PR
javache
commented
Aug 4, 2016
@facebook-github-bot import |
ghost
commented
Aug 4, 2016
Thanks for importing. |
ghost
commented
Aug 13, 2016
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @cpojer as a potential reviewer. Could you take a look please or cc someone with more context? |
mkonicek
commented
Sep 9, 2016
Took a while to get back to this one :) @facebook-github-bot import |
ghost
commented
Sep 9, 2016
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
Motivation
This is originally a follow up of PR #6327 by @dewe and @jeremyong
And @mkonicek indicated this should split into a separate PR.
Now @philikon takes over #6327 as #6961
Test Plan:
According to #6961 and #6889
Load WebSocketExample in UIExplorer app and start websocket test server script and test sending binary data on both iOS and Android