Skip to content

Link fix on Splash, add TRED. - #7862

Closed
alexleventer wants to merge 2 commits into
react:masterfrom
alexleventer:patch-3
Closed

Link fix on Splash, add TRED.#7862
alexleventer wants to merge 2 commits into
react:masterfrom
alexleventer:patch-3

Conversation

@alexleventer

Copy link
Copy Markdown
Contributor

Fix the link for Splash, add TRED to React Native app showcase.

Fix link to Splash, add TRED.
@ghost

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

@ghostghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 31, 2016
@ghost

ghost commented Jun 2, 2016

Copy link
Copy Markdown

@alexleventer updated the pull request.

@lacker

Copy link
Copy Markdown
Contributor

Hey, I changed up the format on the showcase. It would be great to have a listing for Tred though. Maybe this article - http://www.geekwire.com/2015/mobile-dealership-tred-raises-another-1m-to-help-used-car-owners-make-more-money/ with an infoTitle like "Mobile Dealership Tred Raises $1M"? See #8263 for the new format.

@ghost

ghost commented Jul 3, 2016

Copy link
Copy Markdown

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @lacker as a potential reviewer. Could you take a look please or cc someone with more context?

@ghostghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016
@hramos

Copy link
Copy Markdown
Contributor

@alexleventer do you still want to merge this?

@alexleventer

Copy link
Copy Markdown
ContributorAuthor

Yea @hramos - updating now

@ghostghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 2, 2016
@ghostghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@hramos

Copy link
Copy Markdown
Contributor

Ping

@mkonicek

mkonicek commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

@alexleventer I'm going through all pull requests and noticed this one hasn't been updated in a while and the last comment asks a question. I'll close this pull request so it doesn't stay open indefinitely but please send a new one if you want to add TRED to the showcase.

@mkonicekmkonicek closed this Sep 9, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@alexleventer@lacker@hramos@mkonicek@javache