Uh oh!
There was an error while loading. Please reload this page.
Core Components Tutorial to ES6 - #8198
Conversation
Converts the ListView tutorial to ES6. Not sure if there is any specific linting guidelines for this? Related to documentation ListView lockdown: #8184
ghost
commented
Jun 17, 2016
By analyzing the blame information on this pull request, we identified @JoelMarcey and @stevemao to be potential reviewers. |
janicduplessis
commented
Jun 17, 2016
Hey, thanks for the PR! Can you close this one and open a new one on master instead of 0.27-stable branch. |
satya164
commented
Jun 17, 2016
cc @mkonicek seems more people are sending PR's to release branches. In last 1-2 weeks, I've probably seen 4. |
janicduplessis
commented
Jun 17, 2016
@satya164 True, maybe we can add a note in CONTRIBUTING.md |
satya164
commented
Jun 17, 2016
@janicduplessis I was thinking the bot could reply to these. |
mkonicek
commented
Jun 17, 2016
cc @JoelMarcey, I believe we want to move the docs to ES6. |
@Ehesp can you please update this PR so it can be merged to the master branch, rather than 0.27-stable? Adding a note to CONTRIBUTING, or PULL_REQUEST_TEMPLATE sgtm. |
JoelMarcey
commented
Jun 17, 2016
Yeah, we do. In fact, moving this exact example to ES6 was going to be part of our lockdown next week. So this is great. Once this get put on master, we can review and land it, I think. |
z11h
commented
Jun 18, 2016
@JoelMarcey I've also been thinking about moving all the demos to ES6 and if you guys are interested in going on with it, I can submit a PR 😄 |
Ehesp
commented
Jun 18, 2016
Ah yes sorry - will sort in a few hours.
|
Ehesp
commented
Jun 18, 2016
Re-submitted - see above. Also there is a note for the master branch on this commit (420be9e) - was just being stupid sorry! |
I like this idea. We should be able to do something like |
JoelMarcey
commented
Jun 19, 2016
We would definitely be interested in a PR, I think. What do you think @mkonicek@caabernathy@lacker@bestander ?? |
bestander
commented
Jun 19, 2016
Sure thing! |
Converts the ListView tutorial to ES6. Not sure if there is any specific linting guidelines for this?
Related to documentation ListView lockdown: #8184