Skip to content

Set defaults in RCTBundleURLProvider so development mode is the default - #8404

Closed
jsierles wants to merge 3 commits into
react:masterfrom
rnplay:fix-dev-mode-default-false
Closed

Set defaults in RCTBundleURLProvider so development mode is the default#8404
jsierles wants to merge 3 commits into
react:masterfrom
rnplay:fix-dev-mode-default-false

Conversation

@jsierles

@jsierlesjsierles commented Jun 24, 2016

Copy link
Copy Markdown
Contributor

This PR follows up from #8400 and 9845f49.

Sets URL parameters for ensuring dev mode is enabled by default.

Test Plan

Install React Native in a fresh app from react-native init.

update AppDelegate.m to use the new default development URL generator:

jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index.ios" fallbackResource:nil];

Run on iOS device or simulator, and ensure that the dev menu can be pulled up.

@ghost

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @nathanajah and @shaneosullivan to be potential reviewers.

@ghostghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 24, 2016
@jsierles
jsierlesforce-pushed the fix-dev-mode-default-false branch from 84f3ce3 to 490d42aCompareJune 26, 2016 10:39
@javache

Copy link
Copy Markdown
Contributor

@nathanajah is looking into changing this so we apply the defaults in the constructor.

We should also get rid of the dispatch_once.

@jsierles

Copy link
Copy Markdown
ContributorAuthor

@javache Sounds good - would be good to get this into 0.29 to avoid confusion on the issue:

#8333 (comment)

@ghostghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016
@ghost

Copy link
Copy Markdown

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @nathanajah as a potential reviewer. Could you take a look please or cc someone with more context?

@ghostghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 27, 2016
@javache

Copy link
Copy Markdown
Contributor

I think this has been fixed already, right?

@javachejavache closed this Aug 3, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jsierles@javache