Skip to content

Remove navigator comparison and redirect to Navigation guide - #8411

Closed
hramos wants to merge 4 commits into
react:masterfrom
hramos:lockdown-navigator-comparison
Closed

Remove navigator comparison and redirect to Navigation guide#8411
hramos wants to merge 4 commits into
react:masterfrom
hramos:lockdown-navigator-comparison

Conversation

@hramos

Copy link
Copy Markdown
Contributor

The new Navigation guide replaces the Navigator comparison doc. The server will redirect from navigator-comparison.html to navigation.html when this lands.

@ghost

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @caabernathy and @alvaromb to be potential reviewers.

@ghostghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 24, 2016
@hramos

hramos commented Jun 24, 2016

Copy link
Copy Markdown
ContributorAuthor

Think of it, the earlier redirect was not going to work properly in the generated static site. I'm fine with keeping the navigator-comparison.html permalink in order to avoid dealing with redirects.

@caabernathy

Copy link
Copy Markdown
Contributor

So is this PR still applicable since you mentioned you wanted to revert?

@hramos

Copy link
Copy Markdown
ContributorAuthor

@caabernathy there is some content updates in this PR, but given the revert I think it makes more sense to split this into two new PRs.

@hramoshramos closed this Jun 24, 2016
@hramos
hramos deleted the lockdown-navigator-comparison branch June 24, 2016 17:00
@hramos

Copy link
Copy Markdown
ContributorAuthor

See #8417

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hramos@caabernathy