Uh oh!
There was an error while loading. Please reload this page.
Add Image resizeMode center to iOS - #8792
Closed
aleclarson wants to merge 2 commits into
Closed
Conversation
ghost
commented
Jul 14, 2016
By analyzing the blame information on this pull request, we identified @JoelMarcey and @nicklockwood to be potential reviewers. |
Contributor
There was a problem hiding this comment.
This expression seems incorrect
ContributorAuthor
There was a problem hiding this comment.
@javache
Are you talking about destSize.width = destSize.width (which is used elsewhere so I just copied it)?
Or do you mean I should be using the aspect ratios instead?
Contributor
There was a problem hiding this comment.
Could be a bug in the other code then too. Could you clean up all of them up? It probably should just be sourceSize.width = destSize.width
aleclarsonforce-pushed
the
resizemode-center-ios
branch
from
July 18, 2016 22:44
039b293 to
7b591f4Comparealeclarson
commented
Jul 18, 2016
ContributorAuthor
@javache Added another commit that removes the extra assignments. 👍 |
javache
commented
Jul 19, 2016
Contributor
@facebook-github-bot shipit |
ghost
commented
Jul 19, 2016
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
facebook-github-bot pushed a commit
that referenced
this pull request
Jan 27, 2018
Summary: `<Image resizeMode="center">` already works on iOS (implemented in #8792), but is neither tested nor documented the way the other `resizeMode` values are. This PR primarily enables the relevant RNTester case on iOS, and secondarily copies over the doc comment from `Image.android.js` to `Image.ios.js`. A PR to `react-native-website` will follow shortly and it is there I will try and revise the wording a bit. Updated RNTester screenshot (iOS): <img src=https://user-images.githubusercontent.com/2246565/35470720-44b38282-0357-11e8-941c-1b3c5a1b2f3b.png width=300> react-native-website PR coming soon. [IOS] [MINOR] [Image] - Include resizeMode=center in RNTester Closes#17759 Differential Revision: D6829051 Pulled By: hramos fbshipit-source-id: c6e0000a75765e8bf3a1d0306aaafad002b14a58
tungdo194 pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: Addresses this comment: react/react-native#2296 (comment) This pull request adds the `center` value to `ImageResizeMode`. When set, it will center the image within its frame. If the image is larger than its frame, the image is downscaled while maintaining its aspect ratio. That is how the Android implementation works, too. Sorry, don't have time to write tests. 😢 Any reviewers should make sure `RCTTargetRect` returns the correct value when: - the image is smaller than its frame (ie: no downscaling needed) - the image is larger than its frame (should be downscaled to avoid clipping) Closesreact/react-native#8792 Differential Revision: D3586134 Pulled By: javache fbshipit-source-id: 78fb8e5928284003437dac2c9ad264fa584f73ec
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this comment: #2296 (comment)
This pull request adds the
centervalue toImageResizeMode.When set, it will center the image within its frame.
If the image is larger than its frame, the image is downscaled while maintaining its aspect ratio.
That is how the Android implementation works, too.
Sorry, don't have time to write tests. 😢
Any reviewers should make sure
RCTTargetRectreturns the correct value when: