Uh oh!
There was an error while loading. Please reload this page.
Android WebSocket: include cookies in request - #9114
Conversation
ghost
commented
Jul 30, 2016
By analyzing the blame information on this pull request, we identified @philikon and @AndrewJack to be potential reviewers. |
zxcpoiu
commented
Jul 31, 2016
@facebook-github-bot label Android |
shirou
commented
Aug 12, 2016
Hi, is there any update? I met same issue and resolved with this great PR. |
ghost
commented
Aug 12, 2016
@antoinerousseau updated the pull request. |
antoinerousseau
commented
Aug 12, 2016
@shirou I wish someone from FB would realize that this PR is ready to be merged! |
ghost
commented
Aug 12, 2016
@antoinerousseau updated the pull request. |
ghost
commented
Sep 11, 2016
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @philikon as a potential reviewer. Could you take a look please or cc someone with more context? |
shirou
commented
Sep 16, 2016
@antoinerousseau Could you update this branch? @philikon Could you review and if there are no problem, merge this PR? or if you have some concern, I will help. We really need this PR. Thank you. |
ghost
commented
Sep 16, 2016
@antoinerousseau updated the pull request - view changes |
facebook-github-bot
commented
Oct 16, 2016
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @philikon as a potential reviewer. Could you take a look please or cc someone with more context? |
lacker
commented
Oct 29, 2016
Why is this the right behavior? It's not clear to me that websockets should automatically use cookies. FWIW #10575 is a similar pull request. |
lacker
commented
Nov 7, 2016
Chatted with some folks internally to make sure this is 1/ philosophically what we want to do and 2/ wont break FB apps and this seems good. @facebook-github-bot shipit |
facebook-github-bot
commented
Nov 7, 2016
@lacker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: This PR updates #6851 from srikanthkh, fixing coding conventions and javadoc, and adding a test plan. Added testing functions into the WebSocketExample page of the UIExplorer, including a tiny http server to set a cookie on demand. Instructions included in the UIExplorer app. Closesreact/react-native#9114 Differential Revision: D4140534 Pulled By: lacker fbshipit-source-id: e020ad0c6d1d3ea09c0c3564c1795b4e1bc4517d
This PR updates #6851 from @srikanthkh, fixing coding conventions and javadoc, and adding a test plan.
Test plan
Added testing functions into the WebSocketExample page of the UIExplorer, including a tiny http server to set a cookie on demand. Instructions included in the UIExplorer app.