[NativeAnimated][iOS] Add support for value listener

[janicduplessis]

Adds support for Animated.Value#addListener for native driven animated values. Same as #8844 but for iOS. This depends on some JS code in #8844 so only review the 2nd commit and let's wait for #8844 to land first.

Test plan
Tested using the UIExplorer example.

[ghost]

By analyzing the blame information on this pull request, we identified @buba447 and @kmagiera to be potential reviewers.

[ryangomba]

@janicduplessis oh snap, thanks for doing this!

[ryangomba]

Circle is unhappy, but otherwise looks good to me. Will wait until #8844 is landed.

[facebook-github-bot]

@janicduplessis updated the pull request.

[janicduplessis]

Ok tests should pass now, NativeEventEmitter triggered an invariant because native modules are not defined during tests so I just mocked it.

[facebook-github-bot]

@janicduplessis updated the pull request.

[ide]

@janicduplessis can you rebase? #8844 has been merged too.

[ghost]

@janicduplessis updated the pull request.

[janicduplessis]

@ide Done!

[ide]

@facebook-github-bot shipit

[brentvatne]

@facebook-github-bot shipit

[ghost]

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

[ghost]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[ghost]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[janicduplessis]

@javache Could you check why the import failed? There is no conflict and OSS tests all passed.

[ide]

@janicduplessis just a guess, maybe FB is relying on this. We could stub it out as return true and try to merge.

[janicduplessis]

I don't think so, I added it in the Android PR a few days ago.

[brentvatne]

@foghina maybe :)

[foghina]

Had a look but this is too iOS-y for me. A build seems to be failing with (I think) this error:

Invariant Violation: Native module cannot be null.
at invariant (evalmachine.<anonymous>:2406:7)
at new NativeEventEmitter (evalmachine.<anonymous>:4459:51)
at evalmachine.<anonymous>:71282:24
at loadModuleImplementation (evalmachine.<anonymous>:127:1)
at guardedLoadModule (evalmachine.<anonymous>:70:8)
at _require (evalmachine.<anonymous>:54:1)
at evalmachine.<anonymous>:69201:23
at loadModuleImplementation (evalmachine.<anonymous>:127:1)
at guardedLoadModule (evalmachine.<anonymous>:70:8)
at _require (evalmachine.<anonymous>:54:1)

Not sure if this is useful in any way. Leaving this up to @javache to figure out.

[janicduplessis]

I think I figured out why, some internal apps probably don't include the native AnimatedModule and this creates a NativeEventEmitter even if we don't use it. I'll make the nativeEventEmitter creation lazy that way it won't get created for apps that don't use it.

[ide]

Thanks @foghina, that stack trace is helpful. "evalmachine" is part of Node's vm module, perhaps this is failing in a Jest test?

[ghost]

@janicduplessis updated the pull request.

[facebook-github-bot]

@janicduplessis updated the pull request.

[janicduplessis]

@ide Looks like it, I had to mock NativeEventEmitter in a test to make it pass but now I changed the NativeEventEmitter creation to be lazy so it won't need to be mocked unless the test uses an animated value listener for a native driven node.

[ide]

@facebook-github-bot shipit

[ghost]

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.