Added documentation for additional fields of Image by DanielMSchmidt · Pull Request #9304 · react/react-native

DanielMSchmidt · 2016-08-09T06:37:27Z

Hi there,

As @ospfranco found there is some documentation for the code coming from #7338 missing, so I added it. It concerns the method, headers and bdoy field on the Image source object.

If you would like to have any changes made, please don't hesitate to comment, I will add them.

Have a nice day and thank you for maintaining React Native!

ghost · 2016-08-09T06:38:42Z

By analyzing the blame information on this pull request, we identified @davidaurelio and @JoelMarcey to be potential reviewers.

JoelMarcey · 2016-08-09T21:18:55Z

nit: comma after "image request"

Should it be "set such things as" ?

JoelMarcey · 2016-08-09T21:20:32Z

Thanks. Just a couple of comments. Then we can ship.

ospfranco · 2016-08-09T21:48:32Z

thanks @DanielMSchmidt please bear in mind, the android counterpart of that commit has not been merged yet, 7791, so current documentation should at least mention this? or maybe it is better to hold it until it has been merged

ghost · 2016-09-08T17:02:30Z

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @davidaurelio as a potential reviewer. Could you take a look please or cc someone with more context?

JoelMarcey · 2016-09-09T04:05:02Z

I think we may still be waiting for #7791 to be merged here -- is that right @ospfranco?

JoelMarcey · 2016-09-09T04:05:32Z

The small changes I requested can be made in the meantime.

mkonicek · 2016-09-09T16:32:00Z

Thanks for the review @JoelMarcey 👍

DanielMSchmidt · 2016-09-09T19:08:39Z

I just updated the PR to deal with your comments @joelcloralt

facebook-github-bot · 2016-09-09T19:08:55Z

@DanielMSchmidt updated the pull request - view changes

JoelMarcey · 2016-09-09T19:15:05Z

Thanks. SO now we just need to decide whether this needs to wait for #7791

facebook-github-bot · 2016-10-10T17:02:11Z

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @davidaurelio as a potential reviewer. Could you take a look please or cc someone with more context?

JoelMarcey · 2016-10-10T17:12:11Z

#7791 is still open. We are still waiting for that, right?

ospfranco · 2016-10-12T20:37:13Z

Hey @JoelMarcey, sorry I was short on time, yes #7791 is still open:

it was dependent on a change @rigdern made on Fresco framework for android, now that is merged so we are waiting on the pull request to be merged to react-native, once that is merged you can push this too.

hramos · 2016-11-10T23:28:45Z

Waiting on #7791 ...

lacker · 2016-12-14T23:25:23Z

Still waiting on this functionality actually getting in.

hramos · 2017-01-19T22:48:17Z

Waiting...

facebook-github-bot · 2017-04-19T10:21:04Z

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

javache · 2017-04-19T10:54:14Z

Could you rebase this change?

Add method, headers and body example for Image component

DanielMSchmidt · 2017-04-19T11:04:39Z

@javache Did so 👍

facebook-github-bot · 2017-04-19T11:34:58Z

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Hi there, As ospfranco found there is some documentation for the code coming from react#7338 missing, so I added it. It concerns the method, headers and bdoy field on the Image source object. If you would like to have any changes made, please don't hesitate to comment, I will add them. Have a nice day and thank you for maintaining React Native! Closesreact#9304 Differential Revision: D4913262 Pulled By: javache fbshipit-source-id: 922430ec3388560686e1cf53cb5dff7f30e4e31f

DanielMSchmidt mentioned this pull request Aug 9, 2016
[HELP WANTED] Setting header for image source #9299
Closed

ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 9, 2016

JoelMarcey reviewed Aug 9, 2016
View reviewed changes

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2016

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2016

JoelMarcey added GH Review: needs-revision and removed GH Review: review-needed labels Sep 9, 2016

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016

DanielMSchmidt force-pushed the patch-3 branch from df1157e to d68b242Compare September 9, 2016 19:08

ghost added GH Review: review-needed and removed GH Review: needs-revision labels Sep 9, 2016

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2016

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2016

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 12, 2016

hramos added GH Review: accepted and removed GH Review: review-needed labels Nov 10, 2016

hramos mentioned this pull request Nov 10, 2016
Android: Support HTTP headers for source prop on <Image> components #7791
Closed

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Apr 19, 2017

Add documentation for additional fields of Image
3df834e
Add method, headers and body example for Image component

DanielMSchmidt force-pushed the patch-3 branch from ee87eee to 3df834eCompare April 19, 2017 11:03

facebook-github-bot closed this in 625df66Apr 19, 2017

Uh oh!

Conversation

DanielMSchmidt commented Aug 9, 2016

Uh oh!

ghost commented Aug 9, 2016

Uh oh!

JoelMarceyAug 9, 2016

Choose a reason for hiding this comment

Uh oh!

JoelMarceyAug 9, 2016

Choose a reason for hiding this comment

Uh oh!

JoelMarcey commented Aug 9, 2016

Uh oh!

ospfranco commented Aug 9, 2016

Uh oh!

ghost commented Sep 8, 2016

Uh oh!

JoelMarcey commented Sep 9, 2016

Uh oh!

JoelMarcey commented Sep 9, 2016

Uh oh!

mkonicek commented Sep 9, 2016

Uh oh!

DanielMSchmidt commented Sep 9, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Sep 9, 2016

Uh oh!

JoelMarcey commented Sep 9, 2016

Uh oh!

facebook-github-bot commented Oct 10, 2016

Uh oh!

JoelMarcey commented Oct 10, 2016

Uh oh!

ospfranco commented Oct 12, 2016

Uh oh!

hramos commented Nov 10, 2016

Uh oh!

lacker commented Dec 14, 2016

Uh oh!

hramos commented Jan 19, 2017

Uh oh!

facebook-github-bot commented Apr 19, 2017

Uh oh!

javache commented Apr 19, 2017

Uh oh!

DanielMSchmidt commented Apr 19, 2017

Uh oh!

facebook-github-bot commented Apr 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

DanielMSchmidt commented Sep 9, 2016•
edited
Loading