Navigator - Fix wrong scene transformation after pop by sooth-sayer · Pull Request #9516 · react/react-native

sooth-sayer · 2016-08-22T07:20:28Z

ghost · 2016-08-22T07:21:03Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

eslint-bot · 2016-08-22T07:26:11Z

react/no-string-refs: Using this.refs is deprecated.

mkonicek · 2016-09-08T22:43:08Z

Thanks for the great demo in #9485!

@ericvicenti Does this look good to you?

mkonicek · 2016-09-08T22:44:18Z

Can you please add a comment why this is needed so people reading the code in the future understand why it's needed to reset the transform here?

sooth-sayer · 2016-09-19T14:50:08Z

@mkonicek Is this explanation (10c5093) clear enough?)

lacker · 2016-10-19T23:04:54Z

@sooth-sayer can you fix the problem that eslint-bot pointed out?

sooth-sayer · 2016-10-20T07:43:52Z

@lacker Ok, I will fix it

facebook-github-bot · 2016-10-20T08:29:31Z

@sooth-sayer updated the pull request - view changes

eslint-bot · 2016-10-20T08:39:22Z

no-return-assign: Arrow function should not return assignment.

sooth-sayer · 2016-10-20T10:58:43Z

@lacker fixed

ericvicenti · 2016-10-20T14:54:45Z

Ok this makes sense to me.

@facebook-github-bot shipit

ericvicenti · 2016-10-20T14:57:00Z

@facebook-github-bot shipit

lacker · 2016-10-25T22:58:39Z

I think this needs a CLA to ship it. @sooth-sayer would you mind signing the CLA?

facebook-github-bot · 2016-10-26T06:09:25Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

sooth-sayer · 2016-10-26T06:09:57Z

@lacker Ok, I signed it

lacker · 2016-10-26T06:25:49Z

@facebook-github-bot shipit

facebook-github-bot · 2016-10-26T06:27:00Z

@lacker has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ghost added the GH Review: review-needed label Aug 22, 2016

eslint-bot reviewed Aug 22, 2016
View reviewed changes

Comment threadLibraries/CustomComponents/Navigator/Navigator.js Outdated
eslint-botAug 22, 2016
Copy link
Copy Markdown
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react/no-string-refs: Using this.refs is deprecated.

mkonicek changed the title ~~Fix wrong scene transformation after pop~~Navigator - Fix wrong scene transformation after popSep 8, 2016

mkonicek assigned ericvicenti Sep 8, 2016

mkonicek reviewed Sep 8, 2016
View reviewed changes

mkonicek mentioned this pull request Sep 8, 2016
fix [Navigator] Wrong scene transformation after pop #9485 #9493
Closed

sooth-sayer force-pushed the fix/navigator branch from 10c5093 to 735bbbcCompare October 7, 2016 07:06

d.chernyatiev added 2 commits October 20, 2016 11:36

Fix wrong scene transformation after pop
e0c7f95

Add comment for _clearTransform invokation
205c3ea

sooth-sayer force-pushed the fix/navigator branch from 735bbbc to 7aedb62Compare October 20, 2016 08:29

eslint-bot reviewed Oct 20, 2016
View reviewed changes

Fix component refs
a496d2c

sooth-sayer force-pushed the fix/navigator branch from 7aedb62 to a496d2cCompare October 20, 2016 09:06

lacker added GH Review: needs-revision and removed GH Review: review-needed labels Oct 25, 2016

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2016

facebook-github-bot removed the GH Review: needs-revision label Oct 26, 2016

facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. labels Oct 26, 2016

Merge branch 'master' into fix/navigator
9498f98

facebook-github-bot closed this in f645389Oct 26, 2016

Uh oh!

Conversation

sooth-sayer commented Aug 22, 2016

Uh oh!

ghost commented Aug 22, 2016

Uh oh!

eslint-botAug 22, 2016

Choose a reason for hiding this comment

Uh oh!

mkonicek commented Sep 8, 2016

Uh oh!

mkonicekSep 8, 2016

Choose a reason for hiding this comment

Uh oh!

sooth-sayer commented Sep 19, 2016

Uh oh!

lacker commented Oct 19, 2016

Uh oh!

sooth-sayer commented Oct 20, 2016

Uh oh!

facebook-github-bot commented Oct 20, 2016

Uh oh!

eslint-botOct 20, 2016

Choose a reason for hiding this comment

Uh oh!

sooth-sayer commented Oct 20, 2016

Uh oh!

ericvicenti commented Oct 20, 2016

Uh oh!

ericvicenti commented Oct 20, 2016

Uh oh!

lacker commented Oct 25, 2016

Uh oh!

facebook-github-bot commented Oct 26, 2016

Uh oh!

sooth-sayer commented Oct 26, 2016

Uh oh!

lacker commented Oct 26, 2016

Uh oh!

facebook-github-bot commented Oct 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants