Uh oh!
There was an error while loading. Please reload this page.
[Text] Account for font leading so descenders are not clipped - #96
Closed
ide wants to merge 1 commit into
Closed
Conversation
ide
commented
Mar 10, 2015
ContributorAuthor
catping |
vjeux
commented
Mar 10, 2015
Contributor
Looks like a legit change. @a2? |
frantic
commented
Mar 22, 2015
Contributor
@a2@nicklockwood - could you guys please take a look? I think it's a legit change - I've seen this bug a lot. I haven't found anything obvious why we wouldn't want this in. |
nicklockwood
commented
Mar 23, 2015
Contributor
Yes, this looks good to me. Please merge. |
Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With `NSStringDrawingUsesFontLeading` it honors the fonts line spacing. To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off.  
ide
commented
Mar 23, 2015
ContributorAuthor
@frantic is there anything else I need to do to update the snapshots? |
frantic
commented
Mar 23, 2015
Contributor
@ide nope, thanks! Going to get this in via internal diff. |
frantic
commented
Mar 23, 2015
Contributor
Landed internally. Thank you! |
vjeux pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With `NSStringDrawingUsesFontLeading` it honors the fonts line spacing. To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off. ## Before  ## After  Closesreact#96 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With `NSStringDrawingUsesFontLeading` it honors the fonts line spacing. To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off. ## Before  ## After  Closesreact#96 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With `NSStringDrawingUsesFontLeading` it honors the fonts line spacing. To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off. ## Before  ## After  Closesreact#96 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
react-one pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
SudoPlz pushed a commit
to SudoPlz/react-native
that referenced
this pull request
Sep 10, 2025
Avoid GC during the app start
SudoPlz added a commit
to SudoPlz/react-native
that referenced
this pull request
Mar 5, 2026
Revert PR react#96 GC startup changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With
NSStringDrawingUsesFontLeadingit honors the fonts line spacing.To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off.
Before
After