Some help little fixes ... remember "Right Resource Management" by lguzzon · Pull Request #18 · react/react

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

lguzzon · 2013-05-30T14:44:37Z

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentWillUnmount" method).
That's it.

I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

zpao · 2013-05-30T17:34:49Z

Also, please don't remove the brackets on the code fences. This is what allows us to do line highlighting and call out specific changes in the tutorial.

lguzzon · 2013-05-30T17:51:42Z

@benjamn You are rigth ... a got a Typo error ... now fixing
@zpao I see that the rendered markdown with brackets is not highlighted isn't it?

zpao · 2013-05-30T18:03:52Z

On GitHub it won't be - we customized markdown processing a little bit to enable it on the website. That customization actually breaks the highlighting on Github since it's a custom extension. See it in action: http://facebook.github.io/react/docs/tutorial.html

petehunt · 2013-05-30T18:19:21Z

React's lifecycle will guarantee that componentWillMount() is called before componentWillUnmount(), so you don't need to do this check :D See http://facebook.github.io/react/docs/advanced-components.html

petehunt · 2013-05-31T05:34:07Z

@jordow I have a mixin that does this for IG that I want to get into react_contrib.

This is probably a good idea for us to do, however if we use React.autoBind() on the function passed to setInterval() it'll suppress the errors when the component unmounts. I'm pretty sure that killing the setInterval() is better though.

I'm inclined to take this (once rebased) if everyone's OK with it.

zpao · 2013-10-09T19:50:29Z

We've redone a lot of the docs (and a lot of React) since this was opened so I'm going to just close it out.

fix link in community roundup #18

(cherry picked from commit a8e273f)

…act#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

…rs (react#18) Restore props serialization (skipping props breaks hydration). Update findings doc with final validated concurrent throughput: c=1: 127 → 330 req/s (2.6x) c=25: 98 → 292 req/s (3.0x) c=50: 89 → 285 req/s (3.2x) Props serialization adds ~1.3ms per request for 226 boundaries. This is real, irreducible work — the client needs props to hydrate. V8 JSON.stringify is already near-optimal. Total per-request cost is 3.2ms (309 req/s), which is 2.3x faster than the full pipeline. Server-only fused: 528 req/s (matches renderToString).

Added vars and code to "destroy" setInterval in componentWillMount
9d7b384
I think that "resource management" is important; so once You instantiate a resource in a Component then You have to dispose it at the Component life-time's end (in this case using "componentUnMount" method). That's it.

Fixing typo error ... componentWillUnmount
db661b7

petehunt reviewed May 30, 2013
View reviewed changes

Little fixtures: Markdown code brackets, inner variable optimization
7e39ad9

zpao closed this Oct 9, 2013

jgebhardt added a commit to jgebhardt/react that referenced this pull request Mar 14, 2014
Community Round-upreact#18
83e4ef1

zpao pushed a commit that referenced this pull request Mar 15, 2014
Community Round-up#18
1133a93

zpao added a commit that referenced this pull request Mar 15, 2014
Community Round-up#18
029dd9b

jgebhardt added a commit to jgebhardt/react that referenced this pull request Jun 30, 2014
fix link in community roundupreact#18
a8e273f

sophiebits added a commit that referenced this pull request Jun 30, 2014
Merge pull request#1767from jgebhardt/fixlink
94fd726
fix link in community roundup #18

sophiebits pushed a commit that referenced this pull request Jun 30, 2014
fix link in community roundup#18
3f37e8e
(cherry picked from commit a8e273f)

ustadkhan mentioned this pull request Mar 26, 2019
After replacing the .env file - Whoops, looks like something went wrong #15212
Closed

snyk-bot mentioned this pull request Jan 21, 2020
[Snyk] Fix for 1 vulnerabilities SibuStephen/react#9
Open

This was referenced Oct 19, 2020
[Snyk] Security upgrade jscodeshift from 0.1.6 to 0.3.5 stabenfeldt/react#9
Open
[Snyk] Security upgrade jscodeshift from 0.1.6 to 0.3.5 luke7oaks/react#13
Open