Uh oh!
There was an error while loading. Please reload this page.
Add unstable_concurrentUpdatesByDefault - #21227
Merged
Merged
Conversation
Comparing: 86f3385...edd58eb Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
dai-shi
commented
Apr 10, 2021
Contributor
(Let me leave a minor note here as I have been curious about the wording. Do they all mean the same thing? |
sebmarkbage
commented
Apr 10, 2021
Contributor
What is this for? Can we feature flag it if it's internal only? |
rickhanlonii
commented
Apr 10, 2021
ContributorAuthor
@sebmarkbage internally some roots will be sync by default and others will opt-in to time-slicing. |
rickhanlonii
commented
Apr 10, 2021
ContributorAuthor
@dai-shi good question:
|
rickhanloniiforce-pushed
the
rh-root-sync-option
branch
3 times, most recently
from
April 10, 2021 15:53
b820aed to
4c3bdd6Compareacdlite
approved these changes
Apr 19, 2021
acdlite
left a comment
Collaborator
There was a problem hiding this comment.
Nit: Could wrap the root option in the flag to save a ridiculously small number of bytes and perhaps alleviate Seb's concern that it will leak to open source
rickhanloniiforce-pushed
the
rh-root-sync-option
branch
from
April 28, 2021 16:55
8f1b352 to
3128d43Comparerickhanloniiforce-pushed
the
rh-root-sync-option
branch
from
April 28, 2021 17:02
3128d43 to
edd58ebComparefacebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
May 11, 2021
Summary: This sync includes the following changes: - **[b8fda6c](react/react@b8fda6cab )**: [React Native] Set allowConcurrentByDefault = true ([#21491](react/react#21491)) //<Ricky>// - **[1bb8987](react/react@1bb8987cc )**: Renamed function in error log issue #21446 ([#21449](react/react#21449)) //<faebzz>// - **[bd070eb](react/react@bd070eb2c )**: Enable setJSResponder/setIsJSResponder for React Native Fabric ([#21439](react/react#21439)) //<Joshua Gross>// - **[e9a4a44](react/react@e9a4a44aa )**: Add back root override for strict mode ([#21428](react/react#21428)) //<Ricky>// - **[d1542de](react/react@d1542de3a )**: Unify React.memo and React.forwardRef display name logic ([#21392](react/react#21392)) //<Brian Vaughn>// - **[9a130e1](react/react@9a130e1de )**: StrictMode includes strict effects by default ([#21418](react/react#21418)) //<Brian Vaughn>// - **[15fb8c3](react/react@15fb8c304 )**: createRoot API is no longer strict by default ([#21417](react/react#21417)) //<Brian Vaughn>// - **[aea7c2a](react/react@aea7c2aab )**: Re-land "Support nesting of startTransition and flushSync (alt) ([#21149](react/react#21149))" //<Andrew Clark>// - **[bacc870](react/react@bacc87068 )**: Re-land "Flush discrete passive effects before paint ([#21150](react/react#21150))" //<Andrew Clark>// - **[098600c](react/react@098600c42 )**: Re-land "Fix: flushSync changes priority inside effect ([#21122](react/react#21122))" //<Andrew Clark>// - **[df420bc](react/react@df420bc0a )**: Re-land "Delete LanePriority type ([#21090](react/react#21090))" //<Andrew Clark>// - **[ab5b379](react/react@ab5b37927 )**: Re-land "Clean up host pointers in level 2 of clean-up flag ([#21112](react/react#21112))" //<Andrew Clark>// - **[fd907c1](react/react@fd907c1f1 )**: Re-land "Use highest priority lane to detect interruptions ([#21088](react/react#21088))"" //<Andrew Clark>// - **[269dd6e](react/react@269dd6ec5 )**: subtreeFlag warning: Fix legacy suspense false positive ([#21388](react/react#21388)) //<Andrew Clark>// - **[9e9dac6](react/react@9e9dac650 )**: Add unstable_concurrentUpdatesByDefault ([#21227](react/react#21227)) //<Ricky>// - **[86f3385](react/react@86f3385d9 )**: Revert "Use highest priority lane to detect interruptions ([#21088](react/react#21088))" //<Andrew Clark>// - **[c670265](react/react@c6702656f )**: Revert "Clean up host pointers in level 2 of clean-up flag ([#21112](react/react#21112))" //<Andrew Clark>// - **[1bd41c6](react/react@1bd41c664 )**: Revert "Delete LanePriority type ([#21090](react/react#21090))" //<Andrew Clark>// - **[e7e0a90](react/react@e7e0a90bd )**: Revert "Fix: flushSync changes priority inside effect ([#21122](react/react#21122))" //<Andrew Clark>// - **[7bac760](react/react@7bac7607a )**: Revert "Flush discrete passive effects before paint ([#21150](react/react#21150))" //<Andrew Clark>// - **[207d4c3](react/react@207d4c3a5 )**: Revert "Support nesting of startTransition and flushSync (alt) ([#21149](react/react#21149))" //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 2a7bb41...b8fda6c jest_e2e[run_all_tests] Reviewed By: yungsters Differential Revision: D28351439 fbshipit-source-id: 29620f96c9fb9f02b0d856111d3882d3c69fd1c5
koto pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
mrizwanashiq pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a flag to opt-into time-slicing by default per root.