Skip to content

remove flow check in electron app.js - #26184

Merged
mondaychen merged 1 commit into
react:mainfrom
mondaychen:fix_electron
Feb 17, 2023
Merged

remove flow check in electron app.js#26184
mondaychen merged 1 commit into
react:mainfrom
mondaychen:fix_electron

Conversation

@mondaychen

Copy link
Copy Markdown
Contributor

When we were upgrading flow in 6ddcbd4 we added $FlowFixMe for some parameters in this file. However, this file is not compiled at all, and the : syntax breaks the code.

This PR removes the flow check in this file

@facebook-github-botfacebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 16, 2023
@mondaychen
mondaychen merged commit 1a49e2d into react:mainFeb 17, 2023
github-actionsBot pushed a commit that referenced this pull request Feb 17, 2023
When we were upgrading flow in
6ddcbd4
we added `$FlowFixMe` for some parameters in this file. However, this
file is not compiled at all, and the `:` syntax breaks the code.
This PR removes the flow check in this file
DiffTrain build for [1a49e2d](1a49e2d)
[View git log for this commit](https://github.com/facebook/react/commits/1a49e2d833ed24b4d541fc70659a19821585e570)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mondaychen@kassens@facebook-github-bot