Skip to content

[Flight Fixture] Fix proxying with compression - #26368

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:compressionfix
Mar 11, 2023
Merged

[Flight Fixture] Fix proxying with compression#26368
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:compressionfix

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

We're decompressing and then writing and recompressing in the proxy. This causes it to stall if buffered because .pipe() doesn't force flush automatically.

@sebmarkbage
sebmarkbage requested a review from gnoffMarch 10, 2023 23:45
@facebook-github-botfacebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 10, 2023
@react-sizebot

react-sizebot commented Mar 10, 2023

Copy link
Copy Markdown

Comparing: ef8bdbe...048ac72

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=156.70 kB156.70 kB=49.58 kB49.58 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=158.70 kB158.70 kB=50.25 kB50.25 kB
facebook-www/ReactDOM-prod.classic.js=538.92 kB538.92 kB=95.86 kB95.86 kB
facebook-www/ReactDOM-prod.modern.js=522.78 kB522.78 kB=93.55 kB93.55 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 048ac72

@sebmarkbage
sebmarkbage merged commit 7741118 into react:mainMar 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@gnoff@facebook-github-bot