Uh oh!
There was an error while loading. Please reload this page.
Remove hydrate entry point from www builds - #26400
Merged
Merged
Conversation
react-sizebot
commented
Mar 15, 2023
Comparing: d310d65...25eab9f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
kassens
commented
Mar 15, 2023
Contributor
Unfortunately, it's still used in some places, eg. https://fburl.com/code/p66av4kc |
rickhanlonii
commented
Mar 16, 2023
Contributor
Oh nice catch @kassens |
kassens
commented
Mar 16, 2023
Contributor
Actually, this is fine. |
Member
Tests started failing on master after this was merged. Should we revert? |
kassens
commented
Mar 16, 2023
Contributor
I think Rick is already taking a look. If we don't have a quick fix, we'll revert |
kassens
commented
Mar 16, 2023
Contributor
Fix coming in #26412 |
kassens added a commit
that referenced
this pull request
Mar 16, 2023
Reverts #26400. Will take a look at the test failures before re-merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I understand it this isn't used at Meta and it would let us get rid of at least legacy mode hydration code when we remove legacy mode from OSS builds.