Skip to content

Update fork for ReactSharedInternalsClient export - #27717

Merged
jackpope merged 1 commit into
mainfrom
fix-react-shared-internals-umd
Nov 17, 2023
Merged

Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom
fix-react-shared-internals-umd

Conversation

@jackpope

@jackpopejackpope commented Nov 16, 2023

Copy link
Copy Markdown
Collaborator

Summary

After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.

How did you test this change?

  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')

@hoxyqhoxyq mentioned this pull request Nov 17, 2023
Closed
@jackpope
jackpope merged commit bbb9cb1 into mainNov 17, 2023
@jackpope
jackpope deleted the fix-react-shared-internals-umd branch November 17, 2023 14:01
@jackpopejackpope mentioned this pull request Nov 17, 2023
Closed
@Biki-dasBiki-das mentioned this pull request Nov 17, 2023
Closed
@sophiebits

sophiebits commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?

@jackpopejackpope mentioned this pull request Nov 30, 2023
Merged
jackpope added a commit that referenced this pull request Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner mentioned this pull request Dec 15, 2023
Merged
ztanner added a commit to vercel/next.js that referenced this pull request Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update fork for ReactSharedInternalsClient export by jackpope · Pull Request #27717 · react/react · GitHub
Skip to content
Update fork for ReactSharedInternalsClient export - #27717
Merged
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Nov 17, 2023
Merged
Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Conversation
@jackpope
@jackpopejackpope
commented
Nov 16, 2023

Copy link


Copy Markdown

Collaborator
Summary
After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.
How did you test this change?
  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
@hoxyqhoxyq
mentioned this pull request
Nov 17, 2023

Closed

@jackpope
jackpope
merged commit bbb9cb1
into
mainNov 17, 2023
@jackpope
jackpope
deleted the

fix-react-shared-internals-umd

branch
November 17, 2023 14:01
@jackpopejackpope
mentioned this pull request
Nov 17, 2023
 Closed

@Biki-dasBiki-das
mentioned this pull request
Nov 17, 2023
 Closed

@sophiebits
sophiebits
commented
Nov 20, 2023

Copy link


Copy Markdown

Collaborator
Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?
@jackpopejackpope
mentioned this pull request
Nov 30, 2023
 Merged

jackpope added a commit
that referenced
this pull request
Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner
mentioned this pull request
Dec 15, 2023
 Merged

ztanner added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update fork for ReactSharedInternalsClient export by jackpope · Pull Request #27717 · react/react · GitHub
Skip to content
Update fork for ReactSharedInternalsClient export - #27717
Merged
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Nov 17, 2023
Merged
Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Conversation
@jackpope
@jackpopejackpope
commented
Nov 16, 2023

Copy link


Copy Markdown

Collaborator
Summary
After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.
How did you test this change?
  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
@hoxyqhoxyq
mentioned this pull request
Nov 17, 2023

Closed

@jackpope
jackpope
merged commit bbb9cb1
into
mainNov 17, 2023
@jackpope
jackpope
deleted the

fix-react-shared-internals-umd

branch
November 17, 2023 14:01
@jackpopejackpope
mentioned this pull request
Nov 17, 2023
 Closed

@Biki-dasBiki-das
mentioned this pull request
Nov 17, 2023
 Closed

@sophiebits
sophiebits
commented
Nov 20, 2023

Copy link


Copy Markdown

Collaborator
Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?
@jackpopejackpope
mentioned this pull request
Nov 30, 2023
 Merged

jackpope added a commit
that referenced
this pull request
Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner
mentioned this pull request
Dec 15, 2023
 Merged

ztanner added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update fork for ReactSharedInternalsClient export by jackpope · Pull Request #27717 · react/react · GitHub
Skip to content
Update fork for ReactSharedInternalsClient export - #27717
Merged
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Nov 17, 2023
Merged
Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Conversation
@jackpope
@jackpopejackpope
commented
Nov 16, 2023

Copy link


Copy Markdown

Collaborator
Summary
After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.
How did you test this change?
  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
@hoxyqhoxyq
mentioned this pull request
Nov 17, 2023

Closed

@jackpope
jackpope
merged commit bbb9cb1
into
mainNov 17, 2023
@jackpope
jackpope
deleted the

fix-react-shared-internals-umd

branch
November 17, 2023 14:01
@jackpopejackpope
mentioned this pull request
Nov 17, 2023
 Closed

@Biki-dasBiki-das
mentioned this pull request
Nov 17, 2023
 Closed

@sophiebits
sophiebits
commented
Nov 20, 2023

Copy link


Copy Markdown

Collaborator
Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?
@jackpopejackpope
mentioned this pull request
Nov 30, 2023
 Merged

jackpope added a commit
that referenced
this pull request
Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner
mentioned this pull request
Dec 15, 2023
 Merged

ztanner added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update fork for ReactSharedInternalsClient export by jackpope · Pull Request #27717 · react/react · GitHub
Skip to content
Update fork for ReactSharedInternalsClient export - #27717
Merged
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Nov 17, 2023
Merged
Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Conversation
@jackpope
@jackpopejackpope
commented
Nov 16, 2023

Copy link


Copy Markdown

Collaborator
Summary
After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.
How did you test this change?
  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
@hoxyqhoxyq
mentioned this pull request
Nov 17, 2023

Closed

@jackpope
jackpope
merged commit bbb9cb1
into
mainNov 17, 2023
@jackpope
jackpope
deleted the

fix-react-shared-internals-umd

branch
November 17, 2023 14:01
@jackpopejackpope
mentioned this pull request
Nov 17, 2023
 Closed

@Biki-dasBiki-das
mentioned this pull request
Nov 17, 2023
 Closed

@sophiebits
sophiebits
commented
Nov 20, 2023

Copy link


Copy Markdown

Collaborator
Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?
@jackpopejackpope
mentioned this pull request
Nov 30, 2023
 Merged

jackpope added a commit
that referenced
this pull request
Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner
mentioned this pull request
Dec 15, 2023
 Merged

ztanner added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update fork for ReactSharedInternalsClient export by jackpope · Pull Request #27717 · react/react · GitHub
Skip to content
Update fork for ReactSharedInternalsClient export - #27717
Merged
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Nov 17, 2023
Merged
Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Conversation
@jackpope
@jackpopejackpope
commented
Nov 16, 2023

Copy link


Copy Markdown

Collaborator
Summary
After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.
How did you test this change?
  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
@hoxyqhoxyq
mentioned this pull request
Nov 17, 2023

Closed

@jackpope
jackpope
merged commit bbb9cb1
into
mainNov 17, 2023
@jackpope
jackpope
deleted the

fix-react-shared-internals-umd

branch
November 17, 2023 14:01
@jackpopejackpope
mentioned this pull request
Nov 17, 2023
 Closed

@Biki-dasBiki-das
mentioned this pull request
Nov 17, 2023
 Closed

@sophiebits
sophiebits
commented
Nov 20, 2023

Copy link


Copy Markdown

Collaborator
Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?
@jackpopejackpope
mentioned this pull request
Nov 30, 2023
 Merged

jackpope added a commit
that referenced
this pull request
Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner
mentioned this pull request
Dec 15, 2023
 Merged

ztanner added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update fork for ReactSharedInternalsClient export by jackpope · Pull Request #27717 · react/react · GitHub
Skip to content
Update fork for ReactSharedInternalsClient export - #27717
Merged
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Nov 17, 2023
Merged
Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Conversation
@jackpope
@jackpopejackpope
commented
Nov 16, 2023

Copy link


Copy Markdown

Collaborator
Summary
After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.
How did you test this change?
  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
@hoxyqhoxyq
mentioned this pull request
Nov 17, 2023

Closed

@jackpope
jackpope
merged commit bbb9cb1
into
mainNov 17, 2023
@jackpope
jackpope
deleted the

fix-react-shared-internals-umd

branch
November 17, 2023 14:01
@jackpopejackpope
mentioned this pull request
Nov 17, 2023
 Closed

@Biki-dasBiki-das
mentioned this pull request
Nov 17, 2023
 Closed

@sophiebits
sophiebits
commented
Nov 20, 2023

Copy link


Copy Markdown

Collaborator
Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?
@jackpopejackpope
mentioned this pull request
Nov 30, 2023
 Merged

jackpope added a commit
that referenced
this pull request
Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner
mentioned this pull request
Dec 15, 2023
 Merged

ztanner added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Update fork for ReactSharedInternalsClient export by jackpope · Pull Request #27717 · react/react · GitHub
Skip to content
Update fork for ReactSharedInternalsClient export - #27717
Merged
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Nov 17, 2023
Merged
Update fork for ReactSharedInternalsClient export#27717
jackpope merged 1 commit into
mainfrom 
fix-react-shared-internals-umd
Conversation
@jackpope
@jackpopejackpope
commented
Nov 16, 2023

Copy link


Copy Markdown

Collaborator
Summary
After changes in #27436, UMD builds no longer expose Scheduler from ReactSharedInternals. This module is forked in rollup for UMD builds and the path no longer matches. This PR updates the path name to match the new module: ReactSharedInternalsClient.
How did you test this change?
  • yarn build
  • Inspect react.development.js UMD build, observe Scheduler: Scheduler is set in ReactSharedInternals, matching 18.2.0
  • ran attribute-behavior fixture app
  • Observe no more error Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'unstable_cancelCallback')
@hoxyqhoxyq
mentioned this pull request
Nov 17, 2023

Closed

@jackpope
jackpope
merged commit bbb9cb1
into
mainNov 17, 2023
@jackpope
jackpope
deleted the

fix-react-shared-internals-umd

branch
November 17, 2023 14:01
@jackpopejackpope
mentioned this pull request
Nov 17, 2023
 Closed

@Biki-dasBiki-das
mentioned this pull request
Nov 17, 2023
 Closed

@sophiebits
sophiebits
commented
Nov 20, 2023

Copy link


Copy Markdown

Collaborator
Really packages/react/src/forks/ReactSharedInternals.umd.js should probably be renamed to have Client in the name, no?
@jackpopejackpope
mentioned this pull request
Nov 30, 2023
 Merged

jackpope added a commit
that referenced
this pull request
Dec 1, 2023
@jackpopeJack Pope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
3e97c00
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
@ztannerztanner
mentioned this pull request
Dec 15, 2023
 Merged

ztanner added a commit
to vercel/next.js
that referenced
this pull request
Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74
Updates React from 2c338b16f to 0cdfef19b.
### React upstream changes
- react/react#27821
- react/react#27820
- react/react#27818
- react/react#27819
- react/react#27817
- react/react#27703
- react/react#27796
- react/react#27811
- react/react#27804
- react/react#27807
- react/react#27805
- react/react#27792
- react/react#27788
- react/react#26852
- react/react#27790
- react/react#27786
- react/react#27785
- react/react#27783
- react/react#27784
- react/react#27769
- react/react#27766
- react/react#27701
- react/react#27732
- react/react#27740
- react/react#27767
- react/react#27768
- react/react#27765
- react/react#27759
- react/react#27579
- react/react#27709
- react/react#27734
- react/react#27739
- react/react#27717
- react/react#27583
- react/react#27713
Closes NEXT-1887
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Update fork for ReactSharedInternalsClient export (react#27717)
692c79b
## Summary
After changes in react#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@jackpopeJack Pope@AndyPengc12
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (react…
13341c6
…#27767)
## Summary
Follow up from react#27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Update fork for ReactSharedInternalsClient export (#27717)
eb3fd97
## Summary
After changes in #27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.
## How did you test this change?
- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit bbb9cb1.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@jackpope
Rename fork ReactSharedInternals -> ReactSharedInternalsClient (#27767)
2b931e4
## Summary
Follow up from #27717 based on feedback to rename the fork module itself
## How did you test this change?
- `yarn build`
- `yarn test
packages/scheduler/src/__tests__/SchedulerUMDBundle-test.internal.js`
Co-authored-by: Jack Pope <jackpope@meta.com>
DiffTrain build for commit 3e97c00.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@hoxyqhoxyqhoxyq approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope@sophiebits@hoxyq@facebook-github-bot