fix[devtools/e2e]: add fallback for act in integration tests - #27842

Merged
hoxyq merged 1 commit into
mainfrom
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged

fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom
devtools/fix-act-reference-for-e2e

Conversation

@hoxyq

@hoxyqhoxyq commented Dec 17, 2023

Copy link
Copy Markdown
Collaborator

#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.

@hoxyq
hoxyq requested review from gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed the devtools/fix-act-reference-for-e2e branch from 4e9961d to 015399fCompareDecember 17, 2023 13:07
@hoxyq

hoxyq commented Dec 17, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.

@hoxyq
hoxyq merged commit 3e00e58 into mainDec 17, 2023
@hoxyq
hoxyq deleted the devtools/fix-act-reference-for-e2e branch December 17, 2023 13:17
@acdliteacdlite mentioned this pull request Jan 8, 2024
Merged
acdlite added a commit to acdlite/next.js that referenced this pull request Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit to vercel/next.js that referenced this pull request Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq mentioned this pull request Feb 22, 2024
Merged
hoxyq added a commit that referenced this pull request Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit to Akshato07/-Luffy that referenced this pull request Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees

No one assigned

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix[devtools/e2e]: add fallback for act in integration tests - #27842
Merged
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged
fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Conversation
@hoxyq
@hoxyqhoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

Collaborator
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.
@hoxyq
hoxyq
requested review from
gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed
the
devtools/fix-act-reference-for-e2e
branch
from
4e9961d to
015399fCompareDecember 17, 2023 13:07
@hoxyq
hoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.
@hoxyq
hoxyq
merged commit 3e00e58
into
mainDec 17, 2023
@hoxyq
hoxyq
deleted the

devtools/fix-act-reference-for-e2e

branch
December 17, 2023 13:17
@acdliteacdlite
mentioned this pull request
Jan 8, 2024
 Merged

acdlite added a commit
to acdlite/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq
mentioned this pull request
Feb 22, 2024
 Merged

hoxyq added a commit
that referenced
this pull request
Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix[devtools/e2e]: add fallback for act in integration tests - #27842
Merged
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged
fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Conversation
@hoxyq
@hoxyqhoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

Collaborator
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.
@hoxyq
hoxyq
requested review from
gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed
the
devtools/fix-act-reference-for-e2e
branch
from
4e9961d to
015399fCompareDecember 17, 2023 13:07
@hoxyq
hoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.
@hoxyq
hoxyq
merged commit 3e00e58
into
mainDec 17, 2023
@hoxyq
hoxyq
deleted the

devtools/fix-act-reference-for-e2e

branch
December 17, 2023 13:17
@acdliteacdlite
mentioned this pull request
Jan 8, 2024
 Merged

acdlite added a commit
to acdlite/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq
mentioned this pull request
Feb 22, 2024
 Merged

hoxyq added a commit
that referenced
this pull request
Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix[devtools/e2e]: add fallback for act in integration tests - #27842
Merged
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged
fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Conversation
@hoxyq
@hoxyqhoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

Collaborator
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.
@hoxyq
hoxyq
requested review from
gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed
the
devtools/fix-act-reference-for-e2e
branch
from
4e9961d to
015399fCompareDecember 17, 2023 13:07
@hoxyq
hoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.
@hoxyq
hoxyq
merged commit 3e00e58
into
mainDec 17, 2023
@hoxyq
hoxyq
deleted the

devtools/fix-act-reference-for-e2e

branch
December 17, 2023 13:17
@acdliteacdlite
mentioned this pull request
Jan 8, 2024
 Merged

acdlite added a commit
to acdlite/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq
mentioned this pull request
Feb 22, 2024
 Merged

hoxyq added a commit
that referenced
this pull request
Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix[devtools/e2e]: add fallback for act in integration tests - #27842
Merged
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged
fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Conversation
@hoxyq
@hoxyqhoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

Collaborator
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.
@hoxyq
hoxyq
requested review from
gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed
the
devtools/fix-act-reference-for-e2e
branch
from
4e9961d to
015399fCompareDecember 17, 2023 13:07
@hoxyq
hoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.
@hoxyq
hoxyq
merged commit 3e00e58
into
mainDec 17, 2023
@hoxyq
hoxyq
deleted the

devtools/fix-act-reference-for-e2e

branch
December 17, 2023 13:17
@acdliteacdlite
mentioned this pull request
Jan 8, 2024
 Merged

acdlite added a commit
to acdlite/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq
mentioned this pull request
Feb 22, 2024
 Merged

hoxyq added a commit
that referenced
this pull request
Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix[devtools/e2e]: add fallback for act in integration tests - #27842
Merged
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged
fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Conversation
@hoxyq
@hoxyqhoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

Collaborator
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.
@hoxyq
hoxyq
requested review from
gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed
the
devtools/fix-act-reference-for-e2e
branch
from
4e9961d to
015399fCompareDecember 17, 2023 13:07
@hoxyq
hoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.
@hoxyq
hoxyq
merged commit 3e00e58
into
mainDec 17, 2023
@hoxyq
hoxyq
deleted the

devtools/fix-act-reference-for-e2e

branch
December 17, 2023 13:17
@acdliteacdlite
mentioned this pull request
Jan 8, 2024
 Merged

acdlite added a commit
to acdlite/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq
mentioned this pull request
Feb 22, 2024
 Merged

hoxyq added a commit
that referenced
this pull request
Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix[devtools/e2e]: add fallback for act in integration tests - #27842
Merged
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged
fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Conversation
@hoxyq
@hoxyqhoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

Collaborator
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.
@hoxyq
hoxyq
requested review from
gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed
the
devtools/fix-act-reference-for-e2e
branch
from
4e9961d to
015399fCompareDecember 17, 2023 13:07
@hoxyq
hoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.
@hoxyq
hoxyq
merged commit 3e00e58
into
mainDec 17, 2023
@hoxyq
hoxyq
deleted the

devtools/fix-act-reference-for-e2e

branch
December 17, 2023 13:17
@acdliteacdlite
mentioned this pull request
Jan 8, 2024
 Merged

acdlite added a commit
to acdlite/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq
mentioned this pull request
Feb 22, 2024
 Merged

hoxyq added a commit
that referenced
this pull request
Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix[devtools/e2e]: add fallback for act in integration tests - #27842
Merged
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Dec 17, 2023
Merged
fix[devtools/e2e]: add fallback for act in integration tests#27842
hoxyq merged 1 commit into
mainfrom 
devtools/fix-act-reference-for-e2e
Conversation
@hoxyq
@hoxyqhoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

Collaborator
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when act is not available in react, but available in react-dom, like before.
@hoxyq
hoxyq
requested review from
gnoff and kassensDecember 17, 2023 12:59
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq
hoxyqforce-pushed
the
devtools/fix-act-reference-for-e2e
branch
from
4e9961d to
015399fCompareDecember 17, 2023 13:07
@hoxyq
hoxyq
commented
Dec 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Seems trivial, so I am merging this to fix daily failing CI. If this somehow makes things worse, or if this is not the fix we want, feel free to revert without my review.
@hoxyq
hoxyq
merged commit 3e00e58
into
mainDec 17, 2023
@hoxyq
hoxyq
deleted the

devtools/fix-act-reference-for-e2e

branch
December 17, 2023 13:17
@acdliteacdlite
mentioned this pull request
Jan 8, 2024
 Merged

acdlite added a commit
to acdlite/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a
e8b8060
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
acdlite added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
@acdlite
Update React from 0cdfef19b to f1039be4a (#60368)
5e71061
### React upstream changes
- react/react#27888
- react/react#27870
- react/react#27871
- react/react#27850
- react/react#27839
- react/react#27842
- react/react#27841
- react/react#27840
- react/react#27761
- react/react#27831
- react/react#27801
Closes NEXT-2012
@hoxyqhoxyq
mentioned this pull request
Feb 22, 2024
 Merged

hoxyq added a commit
that referenced
this pull request
Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (react#2…
c984c1b
…7842)
react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@hoxyq@AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (react#28418)
58c3f5b
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[react#28417](react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[react#28399](react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[react#28408](react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[react#28348](react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[react#28320](react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28309](react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[react#28318](react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[react#28226](react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28297](react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[react#28145](react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[react#28296](react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[react#28273](react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[react#28233](react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[react#28265](react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[react#28246](react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28218](react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[react#28254](react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[react#28219](react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28216](react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[react#28249](react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[react#28241](react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[react#28243](react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28236](react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[react#28237](react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[react#28242](react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[react#28240](react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[react#28239](react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[react#28245](react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[react#28244](react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[react#28238](react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[react#28235](react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[react#28221](react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[react#28215](react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[react#28214](react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[react#28213](react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[react#28212](react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[react#28211](react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28210](react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[react#28186](react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[react#28232](react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[react#27982](react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[react#28160](react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[react#27871](react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[react#27842](react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[react#27804](react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[react#27805](react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [react#27790](react#27790))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
0f1f06d
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
DiffTrain build for commit 3e00e58.
Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
9fac9d7
Full list of changes (not a public CHANGELOG):
* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](react/react#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](react/react#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](react/react#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](react/react#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](react/react#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](react/react#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](react/react#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](react/react#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](react/react#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](react/react#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](react/react#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](react/react#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](react/react#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](react/react#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](react/react#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](react/react#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](react/react#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](react/react#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](react/react#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](react/react#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](react/react#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](react/react#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](react/react#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](react/react#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](react/react#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](react/react#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](react/react#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](react/react#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](react/react#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](react/react#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](react/react#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](react/react#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](react/react#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](react/react#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](react/react#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](react/react#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](react/react#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](react/react#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](react/react#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](react/react#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](react/react#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](react/react#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](react/react#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](react/react#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](react/react#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](react/react#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](react/react#27790))
DiffTrain build for commit react/react@288cf74.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kassenskassensAwaiting requested review from kassens
@gnoffgnoffAwaiting requested review from gnoff

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq@facebook-github-bot