Delete more redundant JSX code - #28276

Merged
acdlite merged 1 commit into
react:mainfrom
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged

Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom
acdlite:delete-redundant-jsxDEV

Conversation

@acdlite

@acdliteacdlite commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator

Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.

@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 8, 2024
kassens
kassens approved these changes Feb 8, 2024
View reviewed changes

@kassenskassens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)

@react-sizebot

react-sizebot commented Feb 8, 2024

Copy link
Copy Markdown

Comparing: 37d901e...3bae73d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d

@acdlite
acdlite merged commit d3def47 into react:mainFeb 8, 2024
@acdlite

acdlite commented Feb 8, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)

yeah same :) I'm going to keep trying to consolidate it more.

github-actionsBot pushed a commit that referenced this pull request Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner mentioned this pull request Feb 9, 2024
Merged
huozhi pushed a commit to vercel/next.js that referenced this pull request Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Delete more redundant JSX code - #28276
Merged
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged
Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Conversation
@acdlite
@acdliteacdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

Collaborator
Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.
@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Feb 8, 2024
kassens
kassens
approved these changes
Feb 8, 2024
View reviewed changes
@kassenskassens
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
@react-sizebot
react-sizebot
commented
Feb 8, 2024

Copy link


Copy Markdown

Comparing: 37d901e...3bae73d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d
@acdlite
acdlite
merged commit d3def47
into
react:mainFeb 8, 2024
@acdlite
acdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
yeah same :) I'm going to keep trying to consolidate it more.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner
mentioned this pull request
Feb 9, 2024
 Merged

huozhi pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner
mentioned this pull request
Mar 19, 2024
 Closed

EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete more redundant JSX code - #28276
Merged
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged
Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Conversation
@acdlite
@acdliteacdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

Collaborator
Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.
@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Feb 8, 2024
kassens
kassens
approved these changes
Feb 8, 2024
View reviewed changes
@kassenskassens
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
@react-sizebot
react-sizebot
commented
Feb 8, 2024

Copy link


Copy Markdown

Comparing: 37d901e...3bae73d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d
@acdlite
acdlite
merged commit d3def47
into
react:mainFeb 8, 2024
@acdlite
acdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
yeah same :) I'm going to keep trying to consolidate it more.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner
mentioned this pull request
Feb 9, 2024
 Merged

huozhi pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner
mentioned this pull request
Mar 19, 2024
 Closed

EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete more redundant JSX code - #28276
Merged
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged
Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Conversation
@acdlite
@acdliteacdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

Collaborator
Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.
@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Feb 8, 2024
kassens
kassens
approved these changes
Feb 8, 2024
View reviewed changes
@kassenskassens
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
@react-sizebot
react-sizebot
commented
Feb 8, 2024

Copy link


Copy Markdown

Comparing: 37d901e...3bae73d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d
@acdlite
acdlite
merged commit d3def47
into
react:mainFeb 8, 2024
@acdlite
acdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
yeah same :) I'm going to keep trying to consolidate it more.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner
mentioned this pull request
Feb 9, 2024
 Merged

huozhi pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner
mentioned this pull request
Mar 19, 2024
 Closed

EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Delete more redundant JSX code - #28276
Merged
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged
Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Conversation
@acdlite
@acdliteacdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

Collaborator
Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.
@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Feb 8, 2024
kassens
kassens
approved these changes
Feb 8, 2024
View reviewed changes
@kassenskassens
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
@react-sizebot
react-sizebot
commented
Feb 8, 2024

Copy link


Copy Markdown

Comparing: 37d901e...3bae73d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d
@acdlite
acdlite
merged commit d3def47
into
react:mainFeb 8, 2024
@acdlite
acdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
yeah same :) I'm going to keep trying to consolidate it more.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner
mentioned this pull request
Feb 9, 2024
 Merged

huozhi pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner
mentioned this pull request
Mar 19, 2024
 Closed

EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete more redundant JSX code - #28276
Merged
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged
Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Conversation
@acdlite
@acdliteacdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

Collaborator
Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.
@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Feb 8, 2024
kassens
kassens
approved these changes
Feb 8, 2024
View reviewed changes
@kassenskassens
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
@react-sizebot
react-sizebot
commented
Feb 8, 2024

Copy link


Copy Markdown

Comparing: 37d901e...3bae73d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d
@acdlite
acdlite
merged commit d3def47
into
react:mainFeb 8, 2024
@acdlite
acdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
yeah same :) I'm going to keep trying to consolidate it more.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner
mentioned this pull request
Feb 9, 2024
 Merged

huozhi pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner
mentioned this pull request
Mar 19, 2024
 Closed

EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete more redundant JSX code - #28276
Merged
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged
Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Conversation
@acdlite
@acdliteacdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

Collaborator
Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.
@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Feb 8, 2024
kassens
kassens
approved these changes
Feb 8, 2024
View reviewed changes
@kassenskassens
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
@react-sizebot
react-sizebot
commented
Feb 8, 2024

Copy link


Copy Markdown

Comparing: 37d901e...3bae73d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d
@acdlite
acdlite
merged commit d3def47
into
react:mainFeb 8, 2024
@acdlite
acdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
yeah same :) I'm going to keep trying to consolidate it more.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner
mentioned this pull request
Feb 9, 2024
 Merged

huozhi pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner
mentioned this pull request
Mar 19, 2024
 Closed

EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Delete more redundant JSX code - #28276
Merged
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Feb 8, 2024
Merged
Delete more redundant JSX code#28276
acdlite merged 1 commit into
react:mainfrom 
acdlite:delete-redundant-jsxDEV
Conversation
@acdlite
@acdliteacdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

Collaborator
Found another redundant implementation of JSX code. Not being used anywhere so safe to delete.
@acdlite
Delete more redundant JSX code
3bae73d
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
@facebook-github-botfacebook-github-bot
added

CLA Signed

React Core Team
Opened by a member of the React Core Team
labels
Feb 8, 2024
kassens
kassens
approved these changes
Feb 8, 2024
View reviewed changes
@kassenskassens
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
@react-sizebot
react-sizebot
commented
Feb 8, 2024

Copy link


Copy Markdown

Comparing: 37d901e...3bae73d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.64 kB176.64 kB=55.02 kB55.02 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=178.63 kB178.63 kB=55.60 kB55.59 kB
facebook-www/ReactDOM-prod.classic.js=591.73 kB591.73 kB=104.44 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js=575.51 kB575.51 kB=101.53 kB101.53 kB
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted67.02 kB0.00 kBDeleted16.42 kB0.00 kB

Generated by 🚫 dangerJS against 3bae73d
@acdlite
acdlite
merged commit d3def47
into
react:mainFeb 8, 2024
@acdlite
acdlite
commented
Feb 8, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Great, I remember looking around and was surprised why there were so many implementations (and didn't think much more about this)
yeah same :) I'm going to keep trying to consolidate it more.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 8, 2024
@acdlite
Delete more redundant JSX code (#28276)
3b33617
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for [d3def47](d3def47)
@ztannerztanner
mentioned this pull request
Feb 9, 2024
 Merged

huozhi pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514
Updates React from 2bc7d336a to ba5e6a832.
### React upstream changes
- react/react#28283
- react/react#28280
- react/react#28079
- react/react#28233
- react/react#28276
- react/react#28272
- react/react#28265
- react/react#28259
- react/react#28153
- react/react#28246
- react/react#28218
- react/react#28263
- react/react#28257
- react/react#28261
- react/react#28262
- react/react#28260
- react/react#28258
- react/react#27864
- react/react#28254
- react/react#28219
- react/react#28248
- react/react#28216
- react/react#28249
- react/react#28241
- react/react#28243
- react/react#28253
- react/react#28256
- react/react#28236
- react/react#28237
- react/react#28242
- react/react#28251
- react/react#28252
Closes NEXT-2411
@ztannerztanner
mentioned this pull request
Mar 19, 2024
 Closed

EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@acdlite@AndyPengc12
Delete more redundant JSX code (react#28276)
a5a9429
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@acdlite
Delete more redundant JSX code (#28276)
4e9b256
Found another redundant implementation of JSX code. Not being used
anywhere so safe to delete.
DiffTrain build for commit d3def47.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kassenskassenskassens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite@react-sizebot@kassens@facebook-github-bot