Skip to content

Bundle config: inline internal hook wrapper - #28978

Merged
kassens merged 1 commit into
react:mainfrom
kassens:pr28978
May 3, 2024
Merged

Bundle config: inline internal hook wrapper#28978
kassens merged 1 commit into
react:mainfrom
kassens:pr28978

Conversation

@kassens

@kassenskassens commented May 2, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle config: inline internal hook wrapper

Instead of reading this wrapper from 2 files for "start" and "end" and then string modifying the templates, just inline them like the other wrappers in this file.

Stack created with Sapling. Best reviewed with ReviewStack.

@kassens
Bundle config: inline internal hook wrapper
63faec5
Instead of reading this wrapper from 2 files for "start" and "end" and then string modifying the templates, just inline them like the other wrappers in this file.
@kassenskassens mentioned this pull request May 2, 2024
Closed
@facebook-github-botfacebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 2, 2024
@react-sizebot

react-sizebot commented May 2, 2024

Copy link
Copy Markdown

Comparing: 73bcdfb...63faec5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.66 kB6.66 kB+0.05%1.82 kB1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=492.61 kB492.61 kB=87.88 kB87.88 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.67 kB6.67 kB+0.05%1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=498.86 kB498.86 kB=88.93 kB88.93 kB
facebook-www/ReactDOM-prod.classic.js=591.22 kB591.22 kB=103.96 kB103.96 kB
facebook-www/ReactDOM-prod.modern.js=567.44 kB567.44 kB=100.36 kB100.36 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js=5.85 kB5.72 kB=1.88 kB1.86 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js=5.85 kB5.72 kB=1.88 kB1.86 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js=5.85 kB5.72 kB=1.88 kB1.86 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js=5.80 kB5.67 kB=1.86 kB1.84 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js=5.80 kB5.67 kB=1.86 kB1.84 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js=5.80 kB5.67 kB=1.86 kB1.84 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js=2.77 kB2.64 kB=1.25 kB1.23 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js=2.77 kB2.64 kB=1.25 kB1.23 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js=2.77 kB2.64 kB=1.25 kB1.23 kB
oss-experimental/use-subscription/cjs/use-subscription.development.js=1.51 kB1.38 kB=0.66 kB0.64 kB
oss-stable-semver/use-subscription/cjs/use-subscription.development.js=1.51 kB1.38 kB=0.66 kB0.64 kB
oss-stable/use-subscription/cjs/use-subscription.development.js=1.51 kB1.38 kB=0.66 kB0.64 kB
test_utils/ReactAllWarnings.jsDeleted64.26 kB0.00 kBDeleted16.02 kB0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/cjs/react-dom.development.js=24.50 kB24.37 kB=6.26 kB6.25 kB
oss-stable/react-dom/cjs/react-dom.development.js=24.49 kB24.36 kB=6.26 kB6.24 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js=24.46 kB24.33 kB=6.23 kB6.22 kB
facebook-www/Scheduler-dev.classic.js=22.71 kB22.58 kB=5.92 kB5.90 kB
facebook-www/Scheduler-dev.modern.js=22.71 kB22.58 kB=5.92 kB5.90 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js=17.21 kB17.09 kB=4.86 kB4.84 kB
oss-experimental/scheduler/cjs/scheduler.development.js=17.19 kB17.06 kB=4.83 kB4.81 kB
oss-stable-semver/scheduler/cjs/scheduler.development.js=17.19 kB17.06 kB=4.83 kB4.81 kB
oss-stable/scheduler/cjs/scheduler.development.js=17.19 kB17.06 kB=4.83 kB4.81 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js=8.39 kB8.26 kB=3.18 kB3.16 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js=8.39 kB8.26 kB=3.18 kB3.16 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js=8.39 kB8.26 kB=3.18 kB3.16 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js=7.80 kB7.67 kB=3.08 kB3.06 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js=7.80 kB7.67 kB=3.08 kB3.06 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js=7.80 kB7.67 kB=3.08 kB3.06 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js=5.85 kB5.72 kB=1.88 kB1.86 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js=5.85 kB5.72 kB=1.88 kB1.86 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js=5.85 kB5.72 kB=1.88 kB1.86 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js=5.80 kB5.67 kB=1.86 kB1.84 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js=5.80 kB5.67 kB=1.86 kB1.84 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js=5.80 kB5.67 kB=1.86 kB1.84 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js=2.77 kB2.64 kB=1.25 kB1.23 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js=2.77 kB2.64 kB=1.25 kB1.23 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js=2.77 kB2.64 kB=1.25 kB1.23 kB
oss-experimental/use-subscription/cjs/use-subscription.development.js=1.51 kB1.38 kB=0.66 kB0.64 kB
oss-stable-semver/use-subscription/cjs/use-subscription.development.js=1.51 kB1.38 kB=0.66 kB0.64 kB
oss-stable/use-subscription/cjs/use-subscription.development.js=1.51 kB1.38 kB=0.66 kB0.64 kB
test_utils/ReactAllWarnings.jsDeleted64.26 kB0.00 kBDeleted16.02 kB0.00 kB

Generated by 🚫 dangerJS against 63faec5

rickhanlonii
rickhanlonii approved these changes May 3, 2024
View reviewed changes

@rickhanloniirickhanlonii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in the bundle output that there's no impact, it actually just removed a couple unnecessary comments

https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/react/cjs/react.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573

@kassens
kassens merged commit 0a0a3af into react:mainMay 3, 2024
@kassens
kassens deleted the pr28978 branch May 3, 2024 18:08
github-actionsBot pushed a commit that referenced this pull request May 3, 2024
@kassens
Bundle config: inline internal hook wrapper (#28978)
01110ac
Bundle config: inline internal hook wrapper
Instead of reading this wrapper from 2 files for "start" and "end" and
then string modifying the templates, just inline them like the other
wrappers in this file.
DiffTrain build for commit 0a0a3af.
github-actionsBot pushed a commit that referenced this pull request May 3, 2024
@kassens
Bundle config: inline internal hook wrapper (#28978)
b76cf7b
Bundle config: inline internal hook wrapper
Instead of reading this wrapper from 2 files for "start" and "end" and
then string modifying the templates, just inline them like the other
wrappers in this file.
DiffTrain build for [0a0a3af](0a0a3af)
@eps1loneps1lon mentioned this pull request May 16, 2024
Merged
eps1lon added a commit to vercel/next.js that referenced this pull request May 16, 2024
@eps1lon
Update React from 4508873393 to 04b058868c (#65864)
c045f0f
Completes #65845 which only
updated Canary not Experimental.
<details>
<summary> React upstream changes</summary>
- react/react#29026
- react/react#29025
- react/react#28743
- react/react#29022
- react/react#29023
- react/react#29015
- react/react#29016
- react/react#28988
- react/react#28987
- react/react#28986
- react/react#29014
- react/react#28982
- react/react#29006
- react/react#28973
- react/react#28841
- react/react#28964
- react/react#28990
- react/react#29003
- react/react#28989
- react/react#28893
- react/react#28887
- react/react#28807
- react/react#28978
- react/react#28963
- react/react#28972
- react/react#28970
- react/react#28816
- react/react#28977
- react/react#28974
- react/react#28976
- react/react#28975
- react/react#28969
- react/react#28966
- react/react#28056
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes
@yungstersyungstersAwaiting requested review from yungsters

Assignees

No one assigned

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kassens@react-sizebot@rickhanlonii@facebook-github-bot