Uh oh!
There was an error while loading. Please reload this page.
[Flight] Consistent format of virtual rsc: sources - #33706
Merged
Conversation
`filterStackFrame` was called with a sourceURL that didn't reflect the original sourceURL. This breaks once you try to use `findSourceMapURL` on the given sourceURL since the encoding would be off.
react-sizebot
commented
Jul 5, 2025
Comparing: 5d87cd2...0f6c76c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Jul 5, 2025
| // and suffix. We don't need the environment name because it's available on the | ||
| // parent object that will contain the stack. | ||
| const envIdx = url.indexOf('/', 12); | ||
| const envIdx = url.indexOf('/', 'rsc://React/'.length); |
Contributor
There was a problem hiding this comment.
Does this get optimized by closure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filterStackFramewas called with a sourceURL that didn't reflect the original sourceURL. This breaks once you try to usefindSourceMapURLon the given sourceURL since the encoding would be off.Mostly stood out when reading source that the encoding/decoding wasn't consistent.
ReactServeralways usesencodeURIbutdevirtualizeURLdid not applydecodeUR.ReactReplyClientdidn't encode at all. It's important thatrsc:URLs have a predictable format so that frameworks can retrieve the original sourceURL reliably.