Skip to content

[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783

Merged
poteto merged 1 commit into
mainfrom
pr34783
Oct 8, 2025
Merged

[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom
pr34783

Conversation

@poteto

@potetopoteto commented Oct 8, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
Merged
Merged
@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 8, 2025
@react-sizebot

react-sizebot commented Oct 8, 2025•
edited
Loading

Copy link
Copy Markdown

Comparing: 7568e71...121cd99

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 121cd99

josephsavona
josephsavona approved these changes Oct 8, 2025
View reviewed changes

@josephsavonajosephsavona left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default

@poteto

poteto commented Oct 8, 2025

Copy link
Copy Markdown
CollaboratorAuthor

yup, it was already enabled from before in #34022 but that predated the granular eslint rules work

poteto added a commit that referenced this pull request Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot pushed a commit that referenced this pull request Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot pushed a commit that referenced this pull request Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit that referenced this pull request Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot pushed a commit that referenced this pull request Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot pushed a commit that referenced this pull request Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto merged commit 4b3e662 into mainOct 8, 2025
21 checks passed
@poteto
poteto deleted the pr34783 branch October 8, 2025 19:55
github-actionsBot pushed a commit that referenced this pull request Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot pushed a commit that referenced this pull request Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
This was referenced Oct 9, 2025
Closed
Closed
Merged
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[compiler] Add VoidUseMemo rule to RecommendedLatest by poteto · Pull Request #34783 · react/react · GitHub
Skip to content
[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783
Merged
poteto merged 1 commit into
mainfrom 
pr34783
Oct 8, 2025
Merged
[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom 
pr34783
Conversation
@poteto
@potetopoteto
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
 Merged

 Merged

@github-actionsgithub-actionsBot
added
the 
React Core Team
Opened by a member of the React Core Team
label
Oct 8, 2025
@react-sizebot
react-sizebot
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 7568e71...121cd99
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against 121cd99
josephsavona
josephsavona
approved these changes
Oct 8, 2025
View reviewed changes
@josephsavonajosephsavona
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default
@poteto
poteto
commented
Oct 8, 2025

Copy link


Copy Markdown

CollaboratorAuthor
yup, it was already enabled from before in #34022 but that predated the granular eslint rules work
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto
merged commit 4b3e662
into
mainOct 8, 2025

21 checks passed

@poteto
poteto
deleted the

pr34783

branch
October 8, 2025 19:55
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)

This was referenced Oct 9, 2025
 Closed

 Closed

 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[compiler] Add VoidUseMemo rule to RecommendedLatest by poteto · Pull Request #34783 · react/react · GitHub
Skip to content
[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783
Merged
poteto merged 1 commit into
mainfrom 
pr34783
Oct 8, 2025
Merged
[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom 
pr34783
Conversation
@poteto
@potetopoteto
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
 Merged

 Merged

@github-actionsgithub-actionsBot
added
the 
React Core Team
Opened by a member of the React Core Team
label
Oct 8, 2025
@react-sizebot
react-sizebot
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 7568e71...121cd99
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against 121cd99
josephsavona
josephsavona
approved these changes
Oct 8, 2025
View reviewed changes
@josephsavonajosephsavona
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default
@poteto
poteto
commented
Oct 8, 2025

Copy link


Copy Markdown

CollaboratorAuthor
yup, it was already enabled from before in #34022 but that predated the granular eslint rules work
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto
merged commit 4b3e662
into
mainOct 8, 2025

21 checks passed

@poteto
poteto
deleted the

pr34783

branch
October 8, 2025 19:55
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)

This was referenced Oct 9, 2025
 Closed

 Closed

 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[compiler] Add VoidUseMemo rule to RecommendedLatest by poteto · Pull Request #34783 · react/react · GitHub
Skip to content
[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783
Merged
poteto merged 1 commit into
mainfrom 
pr34783
Oct 8, 2025
Merged
[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom 
pr34783
Conversation
@poteto
@potetopoteto
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
 Merged

 Merged

@github-actionsgithub-actionsBot
added
the 
React Core Team
Opened by a member of the React Core Team
label
Oct 8, 2025
@react-sizebot
react-sizebot
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 7568e71...121cd99
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against 121cd99
josephsavona
josephsavona
approved these changes
Oct 8, 2025
View reviewed changes
@josephsavonajosephsavona
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default
@poteto
poteto
commented
Oct 8, 2025

Copy link


Copy Markdown

CollaboratorAuthor
yup, it was already enabled from before in #34022 but that predated the granular eslint rules work
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto
merged commit 4b3e662
into
mainOct 8, 2025

21 checks passed

@poteto
poteto
deleted the

pr34783

branch
October 8, 2025 19:55
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)

This was referenced Oct 9, 2025
 Closed

 Closed

 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[compiler] Add VoidUseMemo rule to RecommendedLatest by poteto · Pull Request #34783 · react/react · GitHub
Skip to content
[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783
Merged
poteto merged 1 commit into
mainfrom 
pr34783
Oct 8, 2025
Merged
[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom 
pr34783
Conversation
@poteto
@potetopoteto
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
 Merged

 Merged

@github-actionsgithub-actionsBot
added
the 
React Core Team
Opened by a member of the React Core Team
label
Oct 8, 2025
@react-sizebot
react-sizebot
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 7568e71...121cd99
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against 121cd99
josephsavona
josephsavona
approved these changes
Oct 8, 2025
View reviewed changes
@josephsavonajosephsavona
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default
@poteto
poteto
commented
Oct 8, 2025

Copy link


Copy Markdown

CollaboratorAuthor
yup, it was already enabled from before in #34022 but that predated the granular eslint rules work
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto
merged commit 4b3e662
into
mainOct 8, 2025

21 checks passed

@poteto
poteto
deleted the

pr34783

branch
October 8, 2025 19:55
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)

This was referenced Oct 9, 2025
 Closed

 Closed

 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[compiler] Add VoidUseMemo rule to RecommendedLatest by poteto · Pull Request #34783 · react/react · GitHub
Skip to content
[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783
Merged
poteto merged 1 commit into
mainfrom 
pr34783
Oct 8, 2025
Merged
[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom 
pr34783
Conversation
@poteto
@potetopoteto
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
 Merged

 Merged

@github-actionsgithub-actionsBot
added
the 
React Core Team
Opened by a member of the React Core Team
label
Oct 8, 2025
@react-sizebot
react-sizebot
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 7568e71...121cd99
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against 121cd99
josephsavona
josephsavona
approved these changes
Oct 8, 2025
View reviewed changes
@josephsavonajosephsavona
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default
@poteto
poteto
commented
Oct 8, 2025

Copy link


Copy Markdown

CollaboratorAuthor
yup, it was already enabled from before in #34022 but that predated the granular eslint rules work
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto
merged commit 4b3e662
into
mainOct 8, 2025

21 checks passed

@poteto
poteto
deleted the

pr34783

branch
October 8, 2025 19:55
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)

This was referenced Oct 9, 2025
 Closed

 Closed

 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[compiler] Add VoidUseMemo rule to RecommendedLatest by poteto · Pull Request #34783 · react/react · GitHub
Skip to content
[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783
Merged
poteto merged 1 commit into
mainfrom 
pr34783
Oct 8, 2025
Merged
[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom 
pr34783
Conversation
@poteto
@potetopoteto
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
 Merged

 Merged

@github-actionsgithub-actionsBot
added
the 
React Core Team
Opened by a member of the React Core Team
label
Oct 8, 2025
@react-sizebot
react-sizebot
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 7568e71...121cd99
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against 121cd99
josephsavona
josephsavona
approved these changes
Oct 8, 2025
View reviewed changes
@josephsavonajosephsavona
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default
@poteto
poteto
commented
Oct 8, 2025

Copy link


Copy Markdown

CollaboratorAuthor
yup, it was already enabled from before in #34022 but that predated the granular eslint rules work
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto
merged commit 4b3e662
into
mainOct 8, 2025

21 checks passed

@poteto
poteto
deleted the

pr34783

branch
October 8, 2025 19:55
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)

This was referenced Oct 9, 2025
 Closed

 Closed

 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[compiler] Add VoidUseMemo rule to RecommendedLatest by poteto · Pull Request #34783 · react/react · GitHub
Skip to content
[compiler] Add VoidUseMemo rule to RecommendedLatest - #34783
Merged
poteto merged 1 commit into
mainfrom 
pr34783
Oct 8, 2025
Merged
[compiler] Add VoidUseMemo rule to RecommendedLatest#34783
poteto merged 1 commit into
mainfrom 
pr34783
Conversation
@poteto
@potetopoteto
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.

This was referenced Oct 8, 2025
 Merged

 Merged

@github-actionsgithub-actionsBot
added
the 
React Core Team
Opened by a member of the React Core Team
label
Oct 8, 2025
@react-sizebot
react-sizebot
commented
Oct 8, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 7568e71...121cd99
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=604.98 kB604.98 kB=107.14 kB107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=663.95 kB663.95 kB=117.03 kB117.03 kB
facebook-www/ReactDOM-prod.classic.js=687.81 kB687.81 kB=121.07 kB121.07 kB
facebook-www/ReactDOM-prod.modern.js=678.24 kB678.24 kB=119.42 kB119.42 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against 121cd99
josephsavona
josephsavona
approved these changes
Oct 8, 2025
View reviewed changes
@josephsavonajosephsavona
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but make sure to actually enable the rule (only for eslint) since it's still disabled by default
@poteto
poteto
commented
Oct 8, 2025

Copy link


Copy Markdown

CollaboratorAuthor
yup, it was already enabled from before in #34022 but that predated the granular eslint rules work
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
7568e71
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
f0f4198
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[eprh] Prepare for 7.0.0 (#34757)
cf7dcb7
For 7.0.0:
Slim down presets to just 2 configurations:
- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules
Removed:
- `recommended-latest-legacy`
- `flat/recommended`
Please see the README for new install instructions.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757
DiffTrain build for [7568e71](7568e71)
poteto added a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
3e1b34d
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest
989a414
Adds a new error category VoidUseMemo which is only enabled in the RecommendedLatest preset for now.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
bb67c72
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Setup RecommendedLatest preset (#34782)
6928ae6
Renames the `recommended` property on LintRule to `preset`, to allow
exporting rules for different presets. For now the `Recommended` and
`RecommendedLatest` presets are the same, but in the next PR I will
enable more rules for the latest preset.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34782).
* #34783
* __->__ #34782
DiffTrain build for [3e1b34d](3e1b34d)
@poteto
poteto
merged commit 4b3e662
into
mainOct 8, 2025

21 checks passed

@poteto
poteto
deleted the

pr34783

branch
October 8, 2025 19:55
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b5356aa
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 8, 2025
@poteto
[compiler] Add VoidUseMemo rule to RecommendedLatest (#34783)
b57bf4a
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](4b3e662)

This was referenced Oct 9, 2025
 Closed

 Closed

 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
e5fbf98
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 12, 2025
@pull
[compiler] Add VoidUseMemo rule to RecommendedLatest (react#34783)
1575af5
Adds a new error category VoidUseMemo which is only enabled in the
RecommendedLatest preset for now.
DiffTrain build for [4b3e662](react@4b3e662)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@josephsavonajosephsavonajosephsavona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@poteto@react-sizebot@josephsavona