[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoxyq merged 1 commit into from
Oct 13, 2025
Merged

[Perf Tracks]: Clear potentially large measures #34803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions packages/react-client/src/ReactFlightPerformanceTrack.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
const entryName =
isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
const debugTask = componentInfo.debugTask;
const measureName = '\u200b' + entryName;
if (__DEV__ && debugTask) {
const properties: Array<[string, string]> = [];
if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
if (componentInfo.props != null) {
addObjectToProperties(componentInfo.props, properties, 0, '');
}

debugTask.run(
// $FlowFixMe[method-unbinding]
performance.measure.bind(performance, '\u200b' + entryName, {
performance.measure.bind(performance, measureName, {
start: startTime < 0 ? 0 : startTime,
end: childrenEndTime,
detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
},
}),
);
performance.clearMeasures(measureName);
} else {
console.timeStamp(
'\u200b' + entryName,
measureName,
startTime < 0 ? 0 : startTime,
childrenEndTime,
trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
const isPrimaryEnv = env === rootEnv;
const entryName =
isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
const measureName = '\u200b' + entryName;
if (__DEV__) {
const properties: Array<[string, string]> = [
[
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
if (componentInfo.props != null) {
addObjectToProperties(componentInfo.props, properties, 0, '');
}
performance.measure('\u200b' + entryName, {

performance.measure(measureName, {
start: startTime < 0 ? 0 : startTime,
end: childrenEndTime,
detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
},
},
});
performance.clearMeasures(measureName);
} else {
console.timeStamp(
entryName,
measureName,
startTime < 0 ? 0 : startTime,
childrenEndTime,
trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
const isPrimaryEnv = env === rootEnv;
const entryName =
isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
const measureName = '\u200b' + entryName;
if (__DEV__) {
const message =
typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
if (componentInfo.props != null) {
addObjectToProperties(componentInfo.props, properties, 0, '');
}
performance.measure('\u200b' + entryName, {

performance.measure(measureName, {
start: startTime < 0 ? 0 : startTime,
end: childrenEndTime,
detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
},
},
});
performance.clearMeasures(measureName);
} else {
console.timeStamp(
entryName,
measureName,
startTime < 0 ? 0 : startTime,
childrenEndTime,
trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
},
}),
);
performance.clearMeasures(entryName);
} else {
console.timeStamp(
entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
},
}),
);
performance.clearMeasures(entryName);
} else {
console.timeStamp(
entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
},
}),
);
performance.clearMeasures(entryName);
} else {
console.timeStamp(
entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
const description = getIODescription(error);
const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
const debugTask = ioInfo.debugTask;
const measureName = '\u200b' + entryName;
if (__DEV__ && debugTask) {
const message =
typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
const properties = [['rejected with', message]];
const tooltipText =
getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

debugTask.run(
// $FlowFixMe[method-unbinding]
performance.measure.bind(performance, '\u200b' + entryName, {
performance.measure.bind(performance, measureName, {
start: startTime < 0 ? 0 : startTime,
end: endTime,
detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
},
}),
);
performance.clearMeasures(measureName);
} else {
console.timeStamp(
entryName,
measureName,
startTime < 0 ? 0 : startTime,
endTime,
IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
const color = getIOColor(entryName);
const debugTask = ioInfo.debugTask;
const measureName = '\u200b' + entryName;
if (__DEV__ && debugTask) {
const properties: Array<[string, string]> = [];
if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
);
debugTask.run(
// $FlowFixMe[method-unbinding]
performance.measure.bind(performance, '\u200b' + entryName, {
performance.measure.bind(performance, measureName, {
start: startTime < 0 ? 0 : startTime,
end: endTime,
detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
},
}),
);
performance.clearMeasures(measureName);
} else {
console.timeStamp(
entryName,
measureName,
startTime < 0 ? 0 : startTime,
endTime,
IO_TRACK,
Expand Down
29 changes: 21 additions & 8 deletions packages/react-reconciler/src/ReactFiberPerformanceTrack.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
} else {
performance.measure(trigger, reusableComponentOptions);
}
performance.clearMeasures(trigger);
}
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
},
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];

@hoxyqhoxyqOct 10, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix


const DEEP_EQUALITY_WARNING =
'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
alternate.memoizedProps !== props
) {
// If this is an update, we'll diff the props and emit which ones changed.
const properties: Array<[string, string]> = [resuableChangedPropsEntry];
const properties: Array<[string, string]> = [reusableChangedPropsEntry];
const isDeeplyEqual = addObjectDiffToProperties(
alternate.memoizedProps,
props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
reusableComponentOptions.start = startTime;
reusableComponentOptions.end = endTime;

const measureName = '\u200b' + name;
if (debugTask != null) {
debugTask.run(
// $FlowFixMe[method-unbinding]
performance.measure.bind(
performance,
'\u200b' + name,
measureName,
reusableComponentOptions,
),
);
} else {
performance.measure('\u200b' + name, reusableComponentOptions);
performance.measure(measureName, reusableComponentOptions);
}
performance.clearMeasures(measureName);
} else {
if (debugTask != null) {
debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
},
},
};

const measureName = '\u200b' + name;
if (__DEV__ && debugTask) {
debugTask.run(
// $FlowFixMe[method-unbinding]
performance.measure.bind(performance, '\u200b' + name, options),
performance.measure.bind(performance, measureName, options),
);
} else {
performance.measure('\u200b' + name, options);
performance.measure(measureName, options);
}
performance.clearMeasures(measureName);
} else {
console.timeStamp(
name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
},
};
const debugTask = fiber._debugTask;
const measureName = '\u200b' + name;
if (debugTask) {
debugTask.run(
// $FlowFixMe[method-unbinding]
performance.measure.bind(performance, '\u200b' + name, options),
performance.measure.bind(performance, measureName, options),
);
} else {
performance.measure('\u200b' + name, options);
performance.measure(measureName, options);
}
performance.clearMeasures(measureName);
} else {
console.timeStamp(
name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
} else {
performance.measure(label, measureOptions);
}
performance.clearMeasures(label);
} else {
console.timeStamp(
label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
} else {
performance.measure(label, measureOptions);
}
performance.clearMeasures(label);
} else {
console.timeStamp(
label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
} else {
performance.measure(label, measureOptions);
}
performance.clearMeasures(label);
} else {
console.timeStamp(
label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
} else {
performance.measure('Recovered', options);
}
performance.clearMeasures('Recovered');
} else {
console.timeStamp(
'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
} else {
performance.measure('Errored', options);
}
performance.clearMeasures('Errored');
} else {
console.timeStamp(
'Errored',
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Oct 13, 2025
 Merged


[Perf Tracks]: Clear potentially large measures
#34803
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


37 changes: 27 additions & 10 deletions
packages/react-client/src/ReactFlightPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const debugTask = componentInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
'\u200b' + entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const properties: Array<[string, string]> = [
 [
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const message =
 typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
 const description = getIODescription(error);
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const message =
 typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
 const properties = [['rejected with', message]];
 const tooltipText =
 getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const color = getIOColor(entryName);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
 );
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand Down

29 changes: 21 additions & 8 deletions
packages/react-reconciler/src/ReactFiberPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
 } else {
 performance.measure(trigger, reusableComponentOptions);
 }
 performance.clearMeasures(trigger);
 }
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
 },
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];
@hoxyqhoxyqOct 10, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix

const DEEP_EQUALITY_WARNING =
 'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
 alternate.memoizedProps !== props
 ) {
 // If this is an update, we'll diff the props and emit which ones changed.
 const properties: Array<[string, string]> = [resuableChangedPropsEntry];
 const properties: Array<[string, string]> = [reusableChangedPropsEntry];
 const isDeeplyEqual = addObjectDiffToProperties(
 alternate.memoizedProps,
 props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
 reusableComponentOptions.start = startTime;
 reusableComponentOptions.end = endTime;

 const measureName = '\u200b' + name;
 if (debugTask != null) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(
 performance,
'\u200b' + name,
measureName,
 reusableComponentOptions,
 ),
 );
 } else {
 performance.measure('\u200b' + name, reusableComponentOptions);
 performance.measure(measureName, reusableComponentOptions);
 }
 performance.clearMeasures(measureName);
 } else {
 if (debugTask != null) {
 debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
 },
 },
 };

 const measureName = '\u200b' + name;
 if (__DEV__ && debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
 },
 };
 const debugTask = fiber._debugTask;
 const measureName = '\u200b' + name;
 if (debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
 } else {
 performance.measure('Recovered', options);
 }
 performance.clearMeasures('Recovered');
 } else {
 console.timeStamp(
 'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
 } else {
 performance.measure('Errored', options);
 }
 performance.clearMeasures('Errored');
 } else {
 console.timeStamp(
 'Errored',
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Oct 13, 2025
 Merged


[Perf Tracks]: Clear potentially large measures
#34803
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


37 changes: 27 additions & 10 deletions
packages/react-client/src/ReactFlightPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const debugTask = componentInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
'\u200b' + entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const properties: Array<[string, string]> = [
 [
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const message =
 typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
 const description = getIODescription(error);
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const message =
 typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
 const properties = [['rejected with', message]];
 const tooltipText =
 getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const color = getIOColor(entryName);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
 );
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand Down

29 changes: 21 additions & 8 deletions
packages/react-reconciler/src/ReactFiberPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
 } else {
 performance.measure(trigger, reusableComponentOptions);
 }
 performance.clearMeasures(trigger);
 }
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
 },
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];
@hoxyqhoxyqOct 10, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix

const DEEP_EQUALITY_WARNING =
 'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
 alternate.memoizedProps !== props
 ) {
 // If this is an update, we'll diff the props and emit which ones changed.
 const properties: Array<[string, string]> = [resuableChangedPropsEntry];
 const properties: Array<[string, string]> = [reusableChangedPropsEntry];
 const isDeeplyEqual = addObjectDiffToProperties(
 alternate.memoizedProps,
 props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
 reusableComponentOptions.start = startTime;
 reusableComponentOptions.end = endTime;

 const measureName = '\u200b' + name;
 if (debugTask != null) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(
 performance,
'\u200b' + name,
measureName,
 reusableComponentOptions,
 ),
 );
 } else {
 performance.measure('\u200b' + name, reusableComponentOptions);
 performance.measure(measureName, reusableComponentOptions);
 }
 performance.clearMeasures(measureName);
 } else {
 if (debugTask != null) {
 debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
 },
 },
 };

 const measureName = '\u200b' + name;
 if (__DEV__ && debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
 },
 };
 const debugTask = fiber._debugTask;
 const measureName = '\u200b' + name;
 if (debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
 } else {
 performance.measure('Recovered', options);
 }
 performance.clearMeasures('Recovered');
 } else {
 console.timeStamp(
 'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
 } else {
 performance.measure('Errored', options);
 }
 performance.clearMeasures('Errored');
 } else {
 console.timeStamp(
 'Errored',
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Oct 13, 2025
 Merged


[Perf Tracks]: Clear potentially large measures
#34803
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


37 changes: 27 additions & 10 deletions
packages/react-client/src/ReactFlightPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const debugTask = componentInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
'\u200b' + entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const properties: Array<[string, string]> = [
 [
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const message =
 typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
 const description = getIODescription(error);
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const message =
 typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
 const properties = [['rejected with', message]];
 const tooltipText =
 getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const color = getIOColor(entryName);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
 );
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand Down

29 changes: 21 additions & 8 deletions
packages/react-reconciler/src/ReactFiberPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
 } else {
 performance.measure(trigger, reusableComponentOptions);
 }
 performance.clearMeasures(trigger);
 }
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
 },
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];
@hoxyqhoxyqOct 10, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix

const DEEP_EQUALITY_WARNING =
 'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
 alternate.memoizedProps !== props
 ) {
 // If this is an update, we'll diff the props and emit which ones changed.
 const properties: Array<[string, string]> = [resuableChangedPropsEntry];
 const properties: Array<[string, string]> = [reusableChangedPropsEntry];
 const isDeeplyEqual = addObjectDiffToProperties(
 alternate.memoizedProps,
 props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
 reusableComponentOptions.start = startTime;
 reusableComponentOptions.end = endTime;

 const measureName = '\u200b' + name;
 if (debugTask != null) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(
 performance,
'\u200b' + name,
measureName,
 reusableComponentOptions,
 ),
 );
 } else {
 performance.measure('\u200b' + name, reusableComponentOptions);
 performance.measure(measureName, reusableComponentOptions);
 }
 performance.clearMeasures(measureName);
 } else {
 if (debugTask != null) {
 debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
 },
 },
 };

 const measureName = '\u200b' + name;
 if (__DEV__ && debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
 },
 };
 const debugTask = fiber._debugTask;
 const measureName = '\u200b' + name;
 if (debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
 } else {
 performance.measure('Recovered', options);
 }
 performance.clearMeasures('Recovered');
 } else {
 console.timeStamp(
 'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
 } else {
 performance.measure('Errored', options);
 }
 performance.clearMeasures('Errored');
 } else {
 console.timeStamp(
 'Errored',
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Oct 13, 2025
 Merged


[Perf Tracks]: Clear potentially large measures
#34803
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


37 changes: 27 additions & 10 deletions
packages/react-client/src/ReactFlightPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const debugTask = componentInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
'\u200b' + entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const properties: Array<[string, string]> = [
 [
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const message =
 typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
 const description = getIODescription(error);
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const message =
 typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
 const properties = [['rejected with', message]];
 const tooltipText =
 getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const color = getIOColor(entryName);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
 );
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand Down

29 changes: 21 additions & 8 deletions
packages/react-reconciler/src/ReactFiberPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
 } else {
 performance.measure(trigger, reusableComponentOptions);
 }
 performance.clearMeasures(trigger);
 }
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
 },
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];
@hoxyqhoxyqOct 10, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix

const DEEP_EQUALITY_WARNING =
 'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
 alternate.memoizedProps !== props
 ) {
 // If this is an update, we'll diff the props and emit which ones changed.
 const properties: Array<[string, string]> = [resuableChangedPropsEntry];
 const properties: Array<[string, string]> = [reusableChangedPropsEntry];
 const isDeeplyEqual = addObjectDiffToProperties(
 alternate.memoizedProps,
 props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
 reusableComponentOptions.start = startTime;
 reusableComponentOptions.end = endTime;

 const measureName = '\u200b' + name;
 if (debugTask != null) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(
 performance,
'\u200b' + name,
measureName,
 reusableComponentOptions,
 ),
 );
 } else {
 performance.measure('\u200b' + name, reusableComponentOptions);
 performance.measure(measureName, reusableComponentOptions);
 }
 performance.clearMeasures(measureName);
 } else {
 if (debugTask != null) {
 debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
 },
 },
 };

 const measureName = '\u200b' + name;
 if (__DEV__ && debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
 },
 };
 const debugTask = fiber._debugTask;
 const measureName = '\u200b' + name;
 if (debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
 } else {
 performance.measure('Recovered', options);
 }
 performance.clearMeasures('Recovered');
 } else {
 console.timeStamp(
 'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
 } else {
 performance.measure('Errored', options);
 }
 performance.clearMeasures('Errored');
 } else {
 console.timeStamp(
 'Errored',
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Oct 13, 2025
 Merged


[Perf Tracks]: Clear potentially large measures
#34803
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


37 changes: 27 additions & 10 deletions
packages/react-client/src/ReactFlightPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const debugTask = componentInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
'\u200b' + entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const properties: Array<[string, string]> = [
 [
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const message =
 typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
 const description = getIODescription(error);
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const message =
 typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
 const properties = [['rejected with', message]];
 const tooltipText =
 getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const color = getIOColor(entryName);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
 );
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand Down

29 changes: 21 additions & 8 deletions
packages/react-reconciler/src/ReactFiberPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
 } else {
 performance.measure(trigger, reusableComponentOptions);
 }
 performance.clearMeasures(trigger);
 }
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
 },
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];
@hoxyqhoxyqOct 10, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix

const DEEP_EQUALITY_WARNING =
 'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
 alternate.memoizedProps !== props
 ) {
 // If this is an update, we'll diff the props and emit which ones changed.
 const properties: Array<[string, string]> = [resuableChangedPropsEntry];
 const properties: Array<[string, string]> = [reusableChangedPropsEntry];
 const isDeeplyEqual = addObjectDiffToProperties(
 alternate.memoizedProps,
 props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
 reusableComponentOptions.start = startTime;
 reusableComponentOptions.end = endTime;

 const measureName = '\u200b' + name;
 if (debugTask != null) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(
 performance,
'\u200b' + name,
measureName,
 reusableComponentOptions,
 ),
 );
 } else {
 performance.measure('\u200b' + name, reusableComponentOptions);
 performance.measure(measureName, reusableComponentOptions);
 }
 performance.clearMeasures(measureName);
 } else {
 if (debugTask != null) {
 debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
 },
 },
 };

 const measureName = '\u200b' + name;
 if (__DEV__ && debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
 },
 };
 const debugTask = fiber._debugTask;
 const measureName = '\u200b' + name;
 if (debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
 } else {
 performance.measure('Recovered', options);
 }
 performance.clearMeasures('Recovered');
 } else {
 console.timeStamp(
 'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
 } else {
 performance.measure('Errored', options);
 }
 performance.clearMeasures('Errored');
 } else {
 console.timeStamp(
 'Errored',
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Oct 13, 2025
 Merged


[Perf Tracks]: Clear potentially large measures
#34803
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


37 changes: 27 additions & 10 deletions
packages/react-client/src/ReactFlightPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const debugTask = componentInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
'\u200b' + entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const properties: Array<[string, string]> = [
 [
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const message =
 typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
 const description = getIODescription(error);
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const message =
 typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
 const properties = [['rejected with', message]];
 const tooltipText =
 getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const color = getIOColor(entryName);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
 );
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand Down

29 changes: 21 additions & 8 deletions
packages/react-reconciler/src/ReactFiberPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
 } else {
 performance.measure(trigger, reusableComponentOptions);
 }
 performance.clearMeasures(trigger);
 }
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
 },
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];
@hoxyqhoxyqOct 10, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix

const DEEP_EQUALITY_WARNING =
 'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
 alternate.memoizedProps !== props
 ) {
 // If this is an update, we'll diff the props and emit which ones changed.
 const properties: Array<[string, string]> = [resuableChangedPropsEntry];
 const properties: Array<[string, string]> = [reusableChangedPropsEntry];
 const isDeeplyEqual = addObjectDiffToProperties(
 alternate.memoizedProps,
 props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
 reusableComponentOptions.start = startTime;
 reusableComponentOptions.end = endTime;

 const measureName = '\u200b' + name;
 if (debugTask != null) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(
 performance,
'\u200b' + name,
measureName,
 reusableComponentOptions,
 ),
 );
 } else {
 performance.measure('\u200b' + name, reusableComponentOptions);
 performance.measure(measureName, reusableComponentOptions);
 }
 performance.clearMeasures(measureName);
 } else {
 if (debugTask != null) {
 debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
 },
 },
 };

 const measureName = '\u200b' + name;
 if (__DEV__ && debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
 },
 };
 const debugTask = fiber._debugTask;
 const measureName = '\u200b' + name;
 if (debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
 } else {
 performance.measure('Recovered', options);
 }
 performance.clearMeasures('Recovered');
 } else {
 console.timeStamp(
 'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
 } else {
 performance.measure('Errored', options);
 }
 performance.clearMeasures('Errored');
 } else {
 console.timeStamp(
 'Errored',
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[Perf Tracks]: Clear potentially large measures#34803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Oct 13, 2025
 Merged


[Perf Tracks]: Clear potentially large measures
#34803
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


37 changes: 27 additions & 10 deletions
packages/react-client/src/ReactFlightPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -102,6 +102,7 @@ export function logComponentRender(
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const debugTask = componentInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (componentInfo.key != null) {
Expand All@@ -110,9 +111,10 @@ export function logComponentRender(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -125,9 +127,10 @@ export function logComponentRender(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
'\u200b' + entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -152,6 +155,7 @@ export function logComponentAborted(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const properties: Array<[string, string]> = [
 [
Expand All@@ -165,7 +169,8 @@ export function logComponentAborted(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -178,9 +183,10 @@ export function logComponentAborted(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand All@@ -206,6 +212,7 @@ export function logComponentErrored(
 const isPrimaryEnv = env === rootEnv;
 const entryName =
 isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
 const measureName = '\u200b' + entryName;
 if (__DEV__) {
 const message =
 typeof error === 'object' &&
Expand All@@ -222,7 +229,8 @@ export function logComponentErrored(
 if (componentInfo.props != null) {
 addObjectToProperties(componentInfo.props, properties, 0, '');
 }
 performance.measure('\u200b' + entryName, {

 performance.measure(measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: childrenEndTime,
 detail: {
Expand All@@ -235,9 +243,10 @@ export function logComponentErrored(
 },
 },
 });
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 childrenEndTime,
 trackNames[trackIdx],
Expand DownExpand Up@@ -397,6 +406,7 @@ export function logComponentAwaitAborted(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -453,6 +463,7 @@ export function logComponentAwaitErrored(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand DownExpand Up@@ -514,6 +525,7 @@ export function logComponentAwait(
 },
 }),
 );
 performance.clearMeasures(entryName);
 } else {
 console.timeStamp(
 entryName,
Expand All@@ -538,6 +550,7 @@ export function logIOInfoErrored(
 const description = getIODescription(error);
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const message =
 typeof error === 'object' &&
Expand All@@ -550,9 +563,10 @@ export function logIOInfoErrored(
 const properties = [['rejected with', message]];
 const tooltipText =
 getIOLongName(ioInfo, description, ioInfo.env, rootEnv) + ' Rejected';

 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -565,9 +579,10 @@ export function logIOInfoErrored(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand All@@ -590,6 +605,7 @@ export function logIOInfo(
 const entryName = getIOShortName(ioInfo, description, ioInfo.env, rootEnv);
 const color = getIOColor(entryName);
 const debugTask = ioInfo.debugTask;
 const measureName = '\u200b' + entryName;
 if (__DEV__ && debugTask) {
 const properties: Array<[string, string]> = [];
 if (typeof value === 'object' && value !== null) {
Expand All@@ -605,7 +621,7 @@ export function logIOInfo(
 );
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + entryName, {
 performance.measure.bind(performance, measureName, {
 start: startTime < 0 ? 0 : startTime,
 end: endTime,
 detail: {
Expand All@@ -618,9 +634,10 @@ export function logIOInfo(
 },
 }),
 );
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
entryName,
measureName,
 startTime < 0 ? 0 : startTime,
 endTime,
 IO_TRACK,
Expand Down

29 changes: 21 additions & 8 deletions
packages/react-reconciler/src/ReactFiberPerformanceTrack.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -133,6 +133,7 @@ function logComponentTrigger(
 } else {
 performance.measure(trigger, reusableComponentOptions);
 }
 performance.clearMeasures(trigger);
 }
}

Expand DownExpand Up@@ -200,7 +201,7 @@ const reusableComponentOptions: PerformanceMeasureOptions = {
 },
};

const resuableChangedPropsEntry = ['Changed Props', ''];
const reusableChangedPropsEntry = ['Changed Props', ''];
@hoxyqhoxyqOct 10, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by typo fix

const DEEP_EQUALITY_WARNING =
 'This component received deeply equal props. It might benefit from useMemo or the React Compiler in its owner.';
Expand DownExpand Up@@ -261,7 +262,7 @@ export function logComponentRender(
 alternate.memoizedProps !== props
 ) {
 // If this is an update, we'll diff the props and emit which ones changed.
 const properties: Array<[string, string]> = [resuableChangedPropsEntry];
 const properties: Array<[string, string]> = [reusableChangedPropsEntry];
 const isDeeplyEqual = addObjectDiffToProperties(
 alternate.memoizedProps,
 props,
Expand DownExpand Up@@ -293,18 +294,20 @@ export function logComponentRender(
 reusableComponentOptions.start = startTime;
 reusableComponentOptions.end = endTime;

 const measureName = '\u200b' + name;
 if (debugTask != null) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(
 performance,
'\u200b' + name,
measureName,
 reusableComponentOptions,
 ),
 );
 } else {
 performance.measure('\u200b' + name, reusableComponentOptions);
 performance.measure(measureName, reusableComponentOptions);
 }
 performance.clearMeasures(measureName);
 } else {
 if (debugTask != null) {
 debugTask.run(
Expand DownExpand Up@@ -421,14 +424,17 @@ export function logComponentErrored(
 },
 },
 };

 const measureName = '\u200b' + name;
 if (__DEV__ && debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -488,14 +494,16 @@ function logComponentEffectErrored(
 },
 };
 const debugTask = fiber._debugTask;
 const measureName = '\u200b' + name;
 if (debugTask) {
 debugTask.run(
 // $FlowFixMe[method-unbinding]
 performance.measure.bind(performance, '\u200b' + name, options),
 performance.measure.bind(performance, measureName, options),
 );
 } else {
 performance.measure('\u200b' + name, options);
 performance.measure(measureName, options);
 }
 performance.clearMeasures(measureName);
 } else {
 console.timeStamp(
 name,
Expand DownExpand Up@@ -762,6 +770,7 @@ export function logBlockingStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -867,6 +876,7 @@ export function logGestureStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1007,6 +1017,7 @@ export function logTransitionStart(
 } else {
 performance.measure(label, measureOptions);
 }
 performance.clearMeasures(label);
 } else {
 console.timeStamp(
 label,
Expand DownExpand Up@@ -1238,6 +1249,7 @@ export function logRecoveredRenderPhase(
 } else {
 performance.measure('Recovered', options);
 }
 performance.clearMeasures('Recovered');
 } else {
 console.timeStamp(
 'Recovered',
Expand DownExpand Up@@ -1449,6 +1461,7 @@ export function logCommitErrored(
 } else {
 performance.measure('Errored', options);
 }
 performance.clearMeasures('Errored');
 } else {
 console.timeStamp(
 'Errored',
Expand Down
Loading