[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[DevTools] The bridge event types should only be defined in one direction - #34859

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes
Oct 15, 2025
Merged

[DevTools] The bridge event types should only be defined in one direction#34859
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:bridgetypes

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

This revealed that a lot of the event types were defined on the wrong end of the bridge.

It was also a problem that events with the same name couldn't have different arguments.

@github-actionsgithub-actionsBot added the React Core Team Opened by a member of the React Core Team label Oct 15, 2025
> extends EventEmitter<{
...IncomingEvents,
...OutgoingEvents,
}> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug.

logEvent({event_name: 'inspect-element-button-clicked'});
bridge.send('startInspectingHost');
} else {
bridge.send('stopInspectingHost', false);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was unused but it was only there because the types forced it.

@sebmarkbage
sebmarkbage merged commit 1873ad7 into react:mainOct 15, 2025
246 of 247 checks passed
@hoxyqhoxyq mentioned this pull request Oct 20, 2025
hoxyq added a commit that referenced this pull request Oct 20, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
Full list of changes:
* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[react#34925](react#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[react#34915](react#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[react#34913](react#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34921](react#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34922](react#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34918](react#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[react#34916](react#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34907](react#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[react#34898](react#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34893](react#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34892](react#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34885](react#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34881](react#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34894](react#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34880](react#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34876](react#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34878](react#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34873](react#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34870](react#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34869](react#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34867](react#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [react#34860](react#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34861](react#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34859](react#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34854](react#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34853](react#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34852](react#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34851](react#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34850](react#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34828](react#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[react#34756](react#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34830](react#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34829](react#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34827](react#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[react#34824](react#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[react#34823](react#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[react#34796](react#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[react#34792](react#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[react#34754](react#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[react#34712](react#34712))
DiffTrain build for [3cde211](react@3cde211)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sebmarkbage@eps1lon