Skip to content

Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014

Closed
zeyap wants to merge 8 commits into
react:mainfrom
zeyap:enable-vt-persistence-mode
Closed

Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom
zeyap:enable-vt-persistence-mode

Conversation

@zeyap

@zeyapzeyap commented Mar 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively
    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)

Test plan

  • Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  • Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes

@zeyapzeyap mentioned this pull request Mar 11, 2026
Closed
@react-sizebot

react-sizebot commented Mar 11, 2026•
edited
Loading

Copy link
Copy Markdown

Comparing: d594643...a0ed77d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d

@zeyapzeyap changed the title Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap changed the title Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope

jackpope commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762

zeyap added 8 commits March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed the enable-vt-persistence-mode branch from 59725a1 to a0ed77dCompareMarch 19, 2026 19:01
@zeyap

zeyap commented Mar 19, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762

@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:

actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag

@github-actions

github-actionsBot commented Jun 17, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actionsgithub-actionsBot added the Resolution: Stale Automatically closed due to inactivity label Jun 17, 2026
@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add enableViewTransitionForPersistenceMode dynamic feature flag by zeyap · Pull Request #36014 · react/react · GitHub
Skip to content
Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014
Closed
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Closed
Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Conversation
@zeyap
@zeyapzeyap
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively

    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)
Test plan
  •  Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  •  Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes
@zeyapzeyap
mentioned this pull request
Mar 11, 2026
 Closed

@react-sizebot
react-sizebot
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Comparing: d594643...a0ed77d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d
@zeyapzeyap
changed the title
Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap
changed the title
Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope
jackpope
commented
Mar 19, 2026

Copy link


Copy Markdown

Collaborator
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
zeyap
added 8 commits
March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed
the
enable-vt-persistence-mode
branch
from
59725a1 to
a0ed77dCompareMarch 19, 2026 19:01
@zeyap
zeyap
commented
Mar 19, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:
actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
@github-actionsgithub-actionsBot
added
the 
Resolution: Stale
Automatically closed due to inactivity
label
Jun 17, 2026
@github-actions
github-actionsBot
commented
Jun 24, 2026

Copy link


Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add enableViewTransitionForPersistenceMode dynamic feature flag by zeyap · Pull Request #36014 · react/react · GitHub
Skip to content
Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014
Closed
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Closed
Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Conversation
@zeyap
@zeyapzeyap
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively

    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)
Test plan
  •  Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  •  Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes
@zeyapzeyap
mentioned this pull request
Mar 11, 2026
 Closed

@react-sizebot
react-sizebot
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Comparing: d594643...a0ed77d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d
@zeyapzeyap
changed the title
Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap
changed the title
Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope
jackpope
commented
Mar 19, 2026

Copy link


Copy Markdown

Collaborator
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
zeyap
added 8 commits
March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed
the
enable-vt-persistence-mode
branch
from
59725a1 to
a0ed77dCompareMarch 19, 2026 19:01
@zeyap
zeyap
commented
Mar 19, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:
actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
@github-actionsgithub-actionsBot
added
the 
Resolution: Stale
Automatically closed due to inactivity
label
Jun 17, 2026
@github-actions
github-actionsBot
commented
Jun 24, 2026

Copy link


Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add enableViewTransitionForPersistenceMode dynamic feature flag by zeyap · Pull Request #36014 · react/react · GitHub
Skip to content
Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014
Closed
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Closed
Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Conversation
@zeyap
@zeyapzeyap
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively

    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)
Test plan
  •  Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  •  Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes
@zeyapzeyap
mentioned this pull request
Mar 11, 2026
 Closed

@react-sizebot
react-sizebot
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Comparing: d594643...a0ed77d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d
@zeyapzeyap
changed the title
Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap
changed the title
Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope
jackpope
commented
Mar 19, 2026

Copy link


Copy Markdown

Collaborator
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
zeyap
added 8 commits
March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed
the
enable-vt-persistence-mode
branch
from
59725a1 to
a0ed77dCompareMarch 19, 2026 19:01
@zeyap
zeyap
commented
Mar 19, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:
actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
@github-actionsgithub-actionsBot
added
the 
Resolution: Stale
Automatically closed due to inactivity
label
Jun 17, 2026
@github-actions
github-actionsBot
commented
Jun 24, 2026

Copy link


Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add enableViewTransitionForPersistenceMode dynamic feature flag by zeyap · Pull Request #36014 · react/react · GitHub
Skip to content
Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014
Closed
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Closed
Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Conversation
@zeyap
@zeyapzeyap
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively

    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)
Test plan
  •  Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  •  Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes
@zeyapzeyap
mentioned this pull request
Mar 11, 2026
 Closed

@react-sizebot
react-sizebot
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Comparing: d594643...a0ed77d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d
@zeyapzeyap
changed the title
Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap
changed the title
Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope
jackpope
commented
Mar 19, 2026

Copy link


Copy Markdown

Collaborator
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
zeyap
added 8 commits
March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed
the
enable-vt-persistence-mode
branch
from
59725a1 to
a0ed77dCompareMarch 19, 2026 19:01
@zeyap
zeyap
commented
Mar 19, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:
actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
@github-actionsgithub-actionsBot
added
the 
Resolution: Stale
Automatically closed due to inactivity
label
Jun 17, 2026
@github-actions
github-actionsBot
commented
Jun 24, 2026

Copy link


Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add enableViewTransitionForPersistenceMode dynamic feature flag by zeyap · Pull Request #36014 · react/react · GitHub
Skip to content
Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014
Closed
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Closed
Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Conversation
@zeyap
@zeyapzeyap
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively

    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)
Test plan
  •  Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  •  Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes
@zeyapzeyap
mentioned this pull request
Mar 11, 2026
 Closed

@react-sizebot
react-sizebot
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Comparing: d594643...a0ed77d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d
@zeyapzeyap
changed the title
Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap
changed the title
Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope
jackpope
commented
Mar 19, 2026

Copy link


Copy Markdown

Collaborator
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
zeyap
added 8 commits
March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed
the
enable-vt-persistence-mode
branch
from
59725a1 to
a0ed77dCompareMarch 19, 2026 19:01
@zeyap
zeyap
commented
Mar 19, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:
actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
@github-actionsgithub-actionsBot
added
the 
Resolution: Stale
Automatically closed due to inactivity
label
Jun 17, 2026
@github-actions
github-actionsBot
commented
Jun 24, 2026

Copy link


Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add enableViewTransitionForPersistenceMode dynamic feature flag by zeyap · Pull Request #36014 · react/react · GitHub
Skip to content
Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014
Closed
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Closed
Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Conversation
@zeyap
@zeyapzeyap
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively

    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)
Test plan
  •  Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  •  Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes
@zeyapzeyap
mentioned this pull request
Mar 11, 2026
 Closed

@react-sizebot
react-sizebot
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Comparing: d594643...a0ed77d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d
@zeyapzeyap
changed the title
Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap
changed the title
Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope
jackpope
commented
Mar 19, 2026

Copy link


Copy Markdown

Collaborator
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
zeyap
added 8 commits
March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed
the
enable-vt-persistence-mode
branch
from
59725a1 to
a0ed77dCompareMarch 19, 2026 19:01
@zeyap
zeyap
commented
Mar 19, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:
actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
@github-actionsgithub-actionsBot
added
the 
Resolution: Stale
Automatically closed due to inactivity
label
Jun 17, 2026
@github-actions
github-actionsBot
commented
Jun 24, 2026

Copy link


Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add enableViewTransitionForPersistenceMode dynamic feature flag by zeyap · Pull Request #36014 · react/react · GitHub
Skip to content
Add enableViewTransitionForPersistenceMode dynamic feature flag - #36014
Closed
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Closed
Add enableViewTransitionForPersistenceMode dynamic feature flag#36014
zeyap wants to merge 8 commits into
react:mainfrom 
zeyap:enable-vt-persistence-mode
Conversation
@zeyap
@zeyapzeyap
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds enableViewTransitionForPersistenceMode dynamic feature flag (defaults to false in all channels)
  • In applyViewTransitionToHostInstancesRecursive and measureViewTransitionHostInstancesRecursive, when it's persistence mode and enableViewTransitionForPersistenceMode==true, run applyViewTransitionName recursively

    • will build on top and add measureInstance related logic when it makes sense (see the TODOs inline)
Test plan
  •  Existing view transition tests pass (flag is false by default, so no behavior change)
  • yarn flow for dom-node, fabric, native renderers
  •  Check before vs after for ReactFabric-dev.fb.js and React-dev.js with the viewtransition featureflags default - nothing changes
@zeyapzeyap
mentioned this pull request
Mar 11, 2026
 Closed

@react-sizebot
react-sizebot
commented
Mar 11, 2026•

edited

Loading

Copy link


Copy Markdown

Comparing: d594643...a0ed77d
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.81 kB612.81 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.75 kB678.75 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=698.14 kB698.14 kB=122.65 kB122.65 kB
facebook-www/ReactDOM-prod.modern.js=688.45 kB688.45 kB=121.03 kB121.02 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
react-native/implementations/ReactFabric-profiling.fb.js+0.71%492.27 kB495.75 kB+0.71%82.92 kB83.51 kB
react-native/implementations/ReactFabric-prod.fb.js+0.67%409.60 kB412.35 kB+0.70%71.03 kB71.52 kB
react-native/implementations/ReactFabric-dev.fb.js+0.52%810.73 kB814.94 kB+0.51%129.72 kB130.39 kB

Generated by 🚫 dangerJS against a0ed77d
@zeyapzeyap
changed the title
Add enableViewTransitionForPersistenceMode feature flagAdd dynamic enableViewTransitionForPersistenceMode feature flagMar 19, 2026
@zeyapzeyap
changed the title
Add dynamic enableViewTransitionForPersistenceMode feature flagAdd enableViewTransitionForPersistenceMode dynamic feature flagMar 19, 2026
@jackpope
jackpope
commented
Mar 19, 2026

Copy link


Copy Markdown

Collaborator
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
zeyap
added 8 commits
March 19, 2026 15:00
@zeyap
Add enableViewTransitionForPersistenceMode feature flag
fa509c1
Wherever the reconciler checks supportsMutation before running view
transition logic, add an else-if branch gated on
enableViewTransitionForPersistenceMode for persistent renderers (Fabric).
This follows the pattern that supportsMutation guards mutation-mode-only
logic, and persistent mode should have its own branch rather than being
lumped under a single supportsViewTransition capability flag.
For now the persistent mode branches duplicate the mutation logic.
The flag defaults to false in all channels.
@zeyap
Simplify persistence mode view transition logic
f291958
Remove viewport measurement and cancelable children tracking for
persistence mode paths, deferring viewport calculation to a future TODO.
Remove duplicate restoreRootViewTransitionName call and deduplicate
feature flag import.
@zeyap
Early return in restoreViewTransitionOnHostInstances for non-mutation…
bad3c40
… mode
@zeyap
Refactor applyViewTransitionToHostInstancesRecursive to early return …
2e0f097
…for persistence mode
@zeyap
Refactor measureViewTransitionHostInstancesRecursive to early return …
b5868c7
…for persistence mode
@zeyap
Fix formatting and restructure persistence mode early returns
3364161
@zeyap
Add TODO and comments for persistence mode measure logic
2c74b71
@zeyap
Make enableViewTransitionForPersistenceMode a dynamic feature flag
a0ed77d
@zeyap
zeyapforce-pushed
the
enable-vt-persistence-mode
branch
from
59725a1 to
a0ed77dCompareMarch 19, 2026 19:01
@zeyap
zeyap
commented
Mar 19, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I believe what @rickhanlonii meant in #35764 (comment) was to create an exported flag from the config itself. Just like how we have supportsHydration we can have supportsViewTransitionhttps://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js#L3762
@jackpope oh Rick replied offline since I last attempted to add that supportsViewTransition:
actually now that i think about it, i think you will need a new flag separate from enableViewTransition for this. something like enableNativeViewTransition. two reasons:
- you need to gate all the supportsViewTransition logic
- we're ready to remove enableViewTransition.

you can make a flag dynamic, which allows you to control it with a GK

but I guess i can achieve the same with dynamic config flag
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
@github-actionsgithub-actionsBot
added
the 
Resolution: Stale
Automatically closed due to inactivity
label
Jun 17, 2026
@github-actions
github-actionsBot
commented
Jun 24, 2026

Copy link


Copy Markdown

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedResolution: StaleAutomatically closed due to inactivity

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@zeyap@react-sizebot@jackpope