Uh oh!
There was an error while loading. Please reload this page.
[DOM] Find host siblings for nested empty Fragments - #37162
Merged
Conversation
jackpopeforce-pushed
the
fragment-refs/empty-fragment-host-siblings
branch
2 times, most recently
from
July 31, 2026 19:14
0290447 to
ff50c0fComparejackpopeforce-pushed
the
fragment-refs/empty-fragment-host-siblings
branch
from
July 31, 2026 20:15
ff50c0f to
68a6ce0Comparejackpope
marked this pull request as ready for review
July 31, 2026 21:08
eps1lon
approved these changes
Jul 31, 2026
jackpopeforce-pushed
the
fragment-refs/empty-fragment-host-siblings
branch
from
August 9, 2026 19:15
68a6ce0 to
f535428Compareeps1lon
approved these changes
Aug 10, 2026
jackpopeforce-pushed
the
fragment-refs/empty-fragment-host-siblings
branch
from
August 11, 2026 03:49
f535428 to
169969cComparejackpopeforce-pushed
the
fragment-refs/empty-fragment-host-siblings
branch
from
August 12, 2026 00:50
169969c to
f0f3f22CompareEmpty compareDocumentPosition used fiber.sibling, and the shared host sibling walk stopped too early inside non-host wrappers. Use the parent tree walk and keep scanning after nested empties so CDP and scrollIntoView resolve following siblings.
jackpopeforce-pushed
the
fragment-refs/empty-fragment-host-siblings
branch
from
August 12, 2026 01:05
f0f3f22 to
8459200Comparepoteto
approved these changes
Aug 12, 2026
poteto
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (light skim). Stacking stamps for the fragment-refs land sequence.
react-sizebot
commented
Aug 12, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
compareDocumentPositionfiber traversal would stop searching after an empty Fragment fiber. Also affectsscrollIntoView