Uh oh!
There was an error while loading. Please reload this page.
[DOM] Preserve autofocus for controls inside dialogs - #37328
Conversation
Hi @bestmaa! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
dianatofficial
left a comment
There was a problem hiding this comment.
Approved. The fix is minimal and correct.
Summary
Fixes#23301.
React implements autoFocus on client-created controls by calling focus() during commit and omitting the native autofocus attribute. That call has no effect while a parent dialog is closed, so opening the dialog later lets the browser focus the first focusable control instead.
This change:
The logic lives in the DOM host config so dialog-specific behavior stays out of the reconciler.
How did you test this change?