Uh oh!
There was an error while loading. Please reload this page.
Fix percent absolute position and size calcuate different with web - #1028
Closed
dislon wants to merge 1 commit into
Closed
Fix percent absolute position and size calcuate different with web#1028dislon wants to merge 1 commit into
dislon wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Sep 1, 2020
Contributor
Hi @dislon! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Sep 1, 2020
Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
dislonforce-pushed
the
fix_layout_absolute_percentage
branch
3 times, most recently
from
September 1, 2020 11:42
5c82d6b to
318e0a3Comparedislon
commented
Sep 1, 2020
Author
@SidharthGuglani could you take a look, please? Thank you! |
dislonforce-pushed
the
fix_layout_absolute_percentage
branch
from
December 14, 2020 12:31
13e1217 to
4909280CompareNickGerleman added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 29, 2022
…h web" behind experimental feature (react#1028) Fixesreact#850react#850 describes a conformance issue where positioning of an absolute child using percentages is not calculated againt the correct box size. This takes the fix for that in react#1028, regenerates tests, and fixes tests so that the experimental feature can be enabled. Goal is to run this as an experiment internally to see if we can enable by default. Changelog: [Internal]
NickGerleman
commented
Dec 29, 2022
Contributor
A lot of the repo has changed since this PR was opened, but I created a new PR #1201 to accept the conformance fix behind a feature flag, so we can test how breaking it is and make default. |
facebook-github-bot pushed a commit
that referenced
this pull request
Jan 8, 2023
…h web" behind experimental feature (#1028) (#1201) Summary: Fixes#850#850 describes a conformance issue where positioning of an absolute child using percentages is not calculated against the correct box size. This takes the fix for that in #1028, regenerates tests, and fixes tests so that the experimental feature can be enabled. Goal is to run this as an experiment internally to see if we can enable by default. Changelog: [Internal] Pull Request resolved: #1201 Reviewed By: yungsters Differential Revision: D42282358 Pulled By: NickGerleman fbshipit-source-id: 57c0dd9b0f1c47cb9335ff6e13d44b4646e5fa58
facebook-github-bot pushed a commit
to facebook/litho
that referenced
this pull request
Jan 8, 2023
…h web" behind experimental feature (#1028) (#1201) Summary: Fixesreact/yoga#850react/yoga#850 describes a conformance issue where positioning of an absolute child using percentages is not calculated against the correct box size. This takes the fix for that in react/yoga#1028, regenerates tests, and fixes tests so that the experimental feature can be enabled. Goal is to run this as an experiment internally to see if we can enable by default. Changelog: [Internal] X-link: react/yoga#1201 Reviewed By: yungsters Differential Revision: D42282358 Pulled By: NickGerleman fbshipit-source-id: 57c0dd9b0f1c47cb9335ff6e13d44b4646e5fa58
facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Jan 8, 2023
…h web" behind experimental feature (#1028) (#1201) Summary: Fixesreact/yoga#850react/yoga#850 describes a conformance issue where positioning of an absolute child using percentages is not calculated against the correct box size. This takes the fix for that in react/yoga#1028, regenerates tests, and fixes tests so that the experimental feature can be enabled. Goal is to run this as an experiment internally to see if we can enable by default. Changelog: [Internal] X-link: react/yoga#1201 Reviewed By: yungsters Differential Revision: D42282358 Pulled By: NickGerleman fbshipit-source-id: 57c0dd9b0f1c47cb9335ff6e13d44b4646e5fa58
liujinye-sys pushed a commit
to open-vela/external_yoga
that referenced
this pull request
Dec 16, 2025
…h web" behind experimental feature (#1028) (#1201) Summary: Fixesreact/yoga#850react/yoga#850 describes a conformance issue where positioning of an absolute child using percentages is not calculated against the correct box size. This takes the fix for that in react/yoga#1028, regenerates tests, and fixes tests so that the experimental feature can be enabled. Goal is to run this as an experiment internally to see if we can enable by default. Changelog: [Internal] Pull Request resolved: react/yoga#1201 Reviewed By: yungsters Differential Revision: D42282358 Pulled By: NickGerleman fbshipit-source-id: 57c0dd9b0f1c47cb9335ff6e13d44b4646e5fa58
openvela-robot pushed a commit
to open-vela/external_yoga
that referenced
this pull request
Apr 21, 2026
…h web" behind experimental feature (#1028) (#1201) Summary: Fixesreact/yoga#850react/yoga#850 describes a conformance issue where positioning of an absolute child using percentages is not calculated against the correct box size. This takes the fix for that in react/yoga#1028, regenerates tests, and fixes tests so that the experimental feature can be enabled. Goal is to run this as an experiment internally to see if we can enable by default. Changelog: [Internal] Pull Request resolved: react/yoga#1201 Reviewed By: yungsters Differential Revision: D42282358 Pulled By: NickGerleman fbshipit-source-id: 57c0dd9b0f1c47cb9335ff6e13d44b4646e5fa58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #850
Additionally,
gentest/gentest.rb^yoga/tests/*.cppin.clang-format-ignore.YGFlexTest.cpp,YGMinMaxDimensionTest.cppandYGPercentageTest.cppto a separate fileYogaNodeStylePropertiesTest.java