Skip to content

upgrade chart.js 2.7.2 and fix #247 - #327

Closed
mizukami234 wants to merge 2 commits into
reactchartjs:masterfrom
mizukami234:feature/upgrade-chartjs-2.7.2
Closed

mizukami234 wants to merge 2 commits into
reactchartjs:masterfrom
mizukami234:feature/upgrade-chartjs-2.7.2

Conversation

@mizukami234

Copy link
Copy Markdown

@mizukami234

Copy link
Copy Markdown
Author

Hi @jerairrest , could you please merge this?
I need this bugfix: chartjs/Chart.js#4937

@bagratinho

Copy link
Copy Markdown

please @jerairrest take time to merge this as I assume this will also fix #337

@rpearce

rpearce commented Mar 29, 2019

Copy link
Copy Markdown

If chart.js is a peerDependency, as shown here https://github.com/jerairrest/react-chartjs-2/blob/master/package.json#L67, then you should be able to specify your own chart.js version in your project, and that will take precedence.

I am not in charge of this project but just came across this PR.

@jerairrest

Copy link
Copy Markdown
Collaborator

I agree with rpeace. Closing since a peer dependency would fix this issue.

@jerairrest jerairrest closed this Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mix chart, labels.slice is not a function error

4 participants