Skip to content

replaced image path cloudinary url [Fixes #118] - #120

Merged
orama254 merged 2 commits into
reactdeveloperske:developfrom
isaacknjama:add-image
Apr 5, 2023
Merged

orama254 merged 2 commits into
reactdeveloperske:developfrom
isaacknjama:add-image

Conversation

@isaacknjama

Copy link
Copy Markdown
Contributor

Fixes #118

Changes proposed

A proposed solution would be to serve the images from a CDN

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot (57)

@vercel

vercel Bot commented Mar 11, 2023

Copy link
Copy Markdown

@isaack-mungui is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel.

@reactdeveloperske first needs to authorize it.

@vercel

vercel Bot commented Apr 5, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reactdevske-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 9:35am

@orama254 orama254 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@orama254
orama254 merged commit 10c9b7f into reactdeveloperske:develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serve Images from CDN instead of locally

2 participants