Uh oh!
There was an error while loading. Please reload this page.
Warn and fix missing mime types - #1050
Conversation
rmorshea
commented
Jun 14, 2023
I'll review this evening. |
Uh oh!
There was an error while loading. Please reload this page.
I thought the same thing at first. But the patch is a harmless fix for I didn't want to link to anything specific since the repair method depends on operating system. This issue technically isn't limited to Windows, but it is far more likely to happen on Windows. I will update the comment to be more specific about this issue being OS independent. |
Uh oh!
There was an error while loading. Please reload this page.
rmorshea
commented
Jun 15, 2023
I just merged a fix for the |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
rmorshea
commented
Jun 15, 2023
After that last comment LGTM |
Issues
N/A
Summary
Windows registry can sometimes go corrupt causing missing mime types. This results in our backends assuming all file types are
text/plain. Ultimately, this causes us to fail to serve our ReactPy clientindex.js.This PR aims to only resolve a minimal set of file extensions (only the ones we potentially use within ReactPy core). I considered using a more comprehensive
mime_typeslist from this repo, but it seems a bit overkill for us right now. We may want to use it if we need to serve a variety of static files.Checklist
changelog.rsthas been updated with any significant changes.