Uh oh!
There was an error while loading. Please reload this page.
Skip rendering None in all situations - #1171
Merged
rmorshea merged 9 commits intoDec 28, 2023
Merged
Conversation
Archmonger
previously approved these changes
Dec 11, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rmorsheaforce-pushed
the
none-renders-as-fragment
branch
from
December 28, 2023 01:35
c869812 to
204534dComparermorsheaforce-pushed
the
none-renders-as-fragment
branch
from
December 28, 2023 02:53
f29b233 to
72ed1e4Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request you agree that all contributions to this project are made under the MIT license.
Issues
Currently the value
Nonewill render as the string"None"when used as a child in VDOM elements. However, when returned by a component it will not render. This inconsistency is confusing for users.fix#1025
Solution
We should skip rendering
Nonein all cases.Checklist
changelog.rsthas been updated with any significant changes.