Skip to content

translate refs-and-the-dom - #108

Merged
iRayan7 merged 9 commits into
reactjs:masterfrom
mohshbool:refs-and-the-dom
Jun 25, 2019
Merged

translate refs-and-the-dom#108
iRayan7 merged 9 commits into
reactjs:masterfrom
mohshbool:refs-and-the-dom

Conversation

@mohshbool

@mohshboolmohshbool commented Jun 23, 2019

Copy link
Copy Markdown
Contributor

translated Refs and the dom page

@netlify

netlifyBot commented Jun 23, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 70eb002

https://deploy-preview-108--ar-reactjs.netlify.com

@mohshboolmohshbool mentioned this pull request Jun 23, 2019
Closed
Fcmam5
Fcmam5 suggested changes Jun 23, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @mohshbool for your contribution, mashaa Allah you did a very good job.
Please allow me to add some suggestions & corrections so we get closer to the perfection with this clean PR.

Also, as a suggestion when adding the original English word to clarify your translation, make it in parentheses as the wiki suggest

Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
mohshbooland others added 7 commits June 24, 2019 12:45
@mohshbool@Fcmam5
suggested changes
41ee167
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool@Fcmam5
remove a همزه
79d0b2e
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool@Fcmam5
fix استخدام
858f51a
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool@Fcmam5
remove comma from inside the ``
535aac7
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool@Fcmam5
fix wrong همزة and a typo in writing نحن
cd47994
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool@Fcmam5
add همزة
f23bc06
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool@Fcmam5
fix wrong همزة
940eec1
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool

mohshbool commented Jun 24, 2019

Copy link
Copy Markdown
ContributorAuthor

@Fcmam5 thank you so much for your kind words and your valuable suggestions that I managed to miss because I was just too focused on getting this repo to 70% so that it's available as an official language on the actual website. I can't thank enough for those great suggestions

@iRayan7
iRayan7 merged commit cddab9e into reactjs:masterJun 25, 2019
@mohshbool
mohshbool deleted the refs-and-the-dom branch June 27, 2019 14:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Fcmam5Fcmam5Fcmam5 approved these changes
@iRayan7iRayan7iRayan7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohshbool@Fcmam5@iRayan7