Skip to content

[Done] translate community/support (related to #117) - #113

Merged
iRayan7 merged 2 commits into
reactjs:masterfrom
Fcmam5:translate-community
Jun 28, 2019
Merged

[Done] translate community/support (related to #117)#113
iRayan7 merged 2 commits into
reactjs:masterfrom
Fcmam5:translate-community

Conversation

@Fcmam5

@Fcmam5Fcmam5 commented Jun 27, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Related to #117

@Fcmam5Fcmam5 changed the title [Work in progress] translate community page[Work in progress] translate community pagesJun 27, 2019
@netlify

netlifyBot commented Jun 27, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 5c37fd0

https://deploy-preview-113--ar-reactjs.netlify.com

@3imed-jaberi

3imed-jaberi commented Jun 27, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Hello @Fcmam5 ,

I think every page should be in one PR. Check out this with @iRayan7.
If this may be, i think you should rename this PR to [Work in progress] translate community section.
I will help here translate the rest together.

@Fcmam5Fcmam5 changed the title [Work in progress] translate community pages[Work in progress] translate community sectionJun 27, 2019
@Fcmam5

Fcmam5 commented Jun 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Hello @Fcmam5 ,
think every page should be in one PR. Check out this with @iRayan7.
If this may be, i think you should rename this PR to [Work in progress] translate community section.
I will help here translate the rest together.

You're right about the title, I thought that it was a simple page until I figured out that it was a complete section.
And sure, you are the most welcome to collaborate on this section, just reference #113 on your PRs, or let's follow any strategy the team chooses :)

@3imed-jaberi

3imed-jaberi commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

Hello @Fcmam5 ,
think every page should be in one PR. Check out this with @iRayan7.
If this may be, i think you should rename this PR to [Work in progress] translate community section.
I will help here translate the rest together.

You're right about the title, I thought that it was a simple page until I figured out that it was a complete section.
And sure, you are the most welcome to collaborate on this section, just reference #113 on your PRs, or let's follow any strategy the team chooses :)

Awesome, let's wait for the strategy of the team to choose 🤝:heart:

@iRayan7

@iRayan7iRayan7 mentioned this pull request Jun 27, 2019
Closed
20 tasks
@iRayan7

iRayan7 commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

Hi @Fcmam5@3imed-jaberi, just created this issue for Community section #117 . Let us continue the assignment there.

@iRayan7

iRayan7 commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

@Fcmam5 Please make this PR for the first page to close it 👍

@Fcmam5Fcmam5 changed the title [Work in progress] translate community section[Done] translate community/support (related to #117)Jun 27, 2019
@iRayan7
iRayan7 merged commit 572c350 into reactjs:masterJun 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@iRayan7iRayan7iRayan7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fcmam5@3imed-jaberi@iRayan7