Skip to content

[Done] translate "How to Contribute" - #120

Merged
iRayan7 merged 10 commits into
reactjs:masterfrom
Fcmam5:translate-how-to-contribute
Aug 9, 2019
Merged

[Done] translate "How to Contribute"#120
iRayan7 merged 10 commits into
reactjs:masterfrom
Fcmam5:translate-how-to-contribute

Conversation

@Fcmam5

@Fcmam5Fcmam5 commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented Jun 28, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit a46aab7

https://deploy-preview-120--ar-reactjs.netlify.com

3imed-jaberi
3imed-jaberi suggested changes Jun 28, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fcmam5 , thank you so much for the great job and your effort you're doing 🎓.
Please, I suggested some request to change some expression 📑. Can you check it out✒️?!
You may be right but this is just a view to be a clearer expression ✌🏻✔️.

Comment threadcontent/docs/how-to-contribute.md
Comment threadcontent/docs/how-to-contribute.md
Comment threadcontent/docs/how-to-contribute.md Outdated
@Fcmam5

Fcmam5 commented Jun 28, 2019

Copy link
Copy Markdown
ContributorAuthor

@3imed-jaberi this PR is in "progress", I think that it doesn't make sense to review an unfinished work since it will have more commits for other parts of the page, and also some corrections when re-reading the translation

@3imed-jaberi

3imed-jaberi commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

@3imed-jaberi this PR is in "progress", I think that it doesn't make sense to review an unfinished work since it will have more commits for other parts of the page, and also some corrections when re-reading the translation

I'm sorry .. I just want to give you some help in your first commit ..

@tesseralistesseralis mentioned this pull request Jun 29, 2019
Closed
@iRayan7

iRayan7 commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Hi @3imed-jaberi, please review this PR after it's been completed. and merge it when approved.

3imed-jaberi
3imed-jaberi suggested changes Jul 2, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
@Fcmam5Fcmam5 changed the title [Work in progress] translate "How to Contribute"[Done] translate "How to Contribute"Jul 23, 2019
3imed-jaberi
3imed-jaberi suggested changes Jul 24, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شكرا لك اخي الكريم على عملك الرائع و مجهود في مساهماتك القيمة 💪🏻 ..

لقد قمت بإقتراح بعض التعديلات بالإضافة إلى التعديلات السابقة ..
يمكنك النظر إليها و شكرا لك

Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md
Comment threadcontent/docs/how-to-contribute.md
Comment threadcontent/docs/how-to-contribute.md Outdated
3imed-jaberi
3imed-jaberi reviewed Jul 24, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md
@Fcmam5
Fcmam5 requested a review from 3imed-jaberiJuly 29, 2019 15:05
@Fcmam5
Fcmam5 requested a review from iRayan7August 9, 2019 18:46
iRayan7
iRayan7 approved these changes Aug 9, 2019
View reviewed changes

@iRayan7iRayan7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Amazing job

@iRayan7
iRayan7 merged commit c226d89 into reactjs:masterAug 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohshboolmohshboolAwaiting requested review from mohshbool
@3imed-jaberi3imed-jaberiAwaiting requested review from 3imed-jaberi
1 more reviewer
@iRayan7iRayan7iRayan7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@3imed-jaberi3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fcmam5@3imed-jaberi@iRayan7