Uh oh!
There was an error while loading. Please reload this page.
translated warnings/dont-call-proptypes - #121
Conversation
Deploy preview for ar-reactjs ready! Built with commit 46bc192 |
Fcmam5
left a comment
There was a problem hiding this comment.
const message = `"${propName}" property of "${componentName}" has been deprecated.\n${explanation}`;
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
mohshbool
commented
Jun 29, 2019
شكرًا! |
That makes sense, sorry I was mistaken in that point.
That's true and it will be super weird if we reorder words so it will be understandable to the reader. We should find a solution for such cases |
I don't think it's that necessary to translate them, I saw the RTL setup, I think the code would look a bit odd if it's written RTL |
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
iRayan7
commented
Jul 2, 2019
Hi @Fcmam5, please review this PR and merge it after approving it.
Thanks. |
Fcmam5
left a comment
There was a problem hiding this comment.
@mohshbool, I'm sorry I missed some "micro-mistakes", would you mind reviewing them?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
mohshbool
commented
Jul 2, 2019
@Fcmam5 I have committed your suggestions, idk how I managed to miss them 😅 |
I haven't translated the
titlebecause I wasn't sure whether to do so or not since some of the translations did and some others didn't!