Skip to content

translated warnings/dont-call-proptypes - #121

Merged
Fcmam5 merged 8 commits into
reactjs:masterfrom
mohshbool:warnings/dont-call-prototypes
Jul 2, 2019
Merged

translated warnings/dont-call-proptypes#121
Fcmam5 merged 8 commits into
reactjs:masterfrom
mohshbool:warnings/dont-call-prototypes

Conversation

@mohshbool

Copy link
Copy Markdown
Contributor

I haven't translated the title because I wasn't sure whether to do so or not since some of the translations did and some others didn't!

@netlify

netlifyBot commented Jun 28, 2019

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 46bc192

https://deploy-preview-121--ar-reactjs.netlify.com

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ما شاء الله أخي محمد! عمل جميل
I had some suggestions (mainly some missing `ّ` شدّة). Also, I suggest translating the title, it's very important for the SEO and for readers and please, can you translate the strings in the examples like:
const message = `"${propName}" property of "${componentName}" has been deprecated.\n${explanation}`;

Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
mohshbooland others added 2 commits June 29, 2019 03:11
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool

Copy link
Copy Markdown
ContributorAuthor

ما شاء الله أخي محمد! عمل جميل
I had some suggestions (mainly some missing ّ شدّة). Also, I suggest translating the title, it's very important for the SEO and for readers and please, can you translate the strings in the examples like:

const message = `"${propName}" property of "${componentName}" has been deprecated.\n${explanation}`;

شكرًا!
regarding the title issue, it's written in #1 not to translate the error message itself since users search for it so (the error/warning is thrown in English)
as for the messages, I was also planning to translate the comments but it turns out that the code part is LTR so its a little messed up. preview: https://imgur.com/a/OwDiyhj

@Fcmam5

Fcmam5 commented Jun 29, 2019

Copy link
Copy Markdown
Contributor

regarding the title issue, it's written in #1 not to translate the error message itself since users search for it so (the error/warning is thrown in English)

That makes sense, sorry I was mistaken in that point.

as for the messages, I was also planning to translate the comments but it turns out that the code part is LTR so its a little messed up. preview: https://imgur.com/a/OwDiyhj

That's true and it will be super weird if we reorder words so it will be understandable to the reader. We should find a solution for such cases

@mohshbool

mohshbool commented Jun 29, 2019

Copy link
Copy Markdown
ContributorAuthor

as for the messages, I was also planning to translate the comments but it turns out that the code part is LTR so its a little messed up. preview: https://imgur.com/a/OwDiyhj

That's true and it will be super weird if we reorder words so it will be understandable to the reader. We should find a solution for such cases

I don't think it's that necessary to translate them, I saw the RTL setup, I think the code would look a bit odd if it's written RTL

Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@iRayan7

Copy link
Copy Markdown
Contributor

Hi @Fcmam5, please review this PR and merge it after approving it.
make sure you checked out this note from #1

Warnings
These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.

Thanks.

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohshbool, I'm sorry I missed some "micro-mistakes", would you mind reviewing them?

Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
mohshbooland others added 3 commits July 2, 2019 13:39
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@mohshbool

Copy link
Copy Markdown
ContributorAuthor

@mohshbool, I'm sorry I missed some "micro-mistakes", would you mind reviewing them?

@Fcmam5 I have committed your suggestions, idk how I managed to miss them 😅

@Fcmam5
Fcmam5 merged commit e37b37d into reactjs:masterJul 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mohshbool@Fcmam5@iRayan7