Skip to content

translated warnings/invalid-aria-prop - #123

Merged
Fcmam5 merged 3 commits into
reactjs:masterfrom
mohshbool:warnings/invalid-aria-prop
Jul 2, 2019
Merged

translated warnings/invalid-aria-prop#123
Fcmam5 merged 3 commits into
reactjs:masterfrom
mohshbool:warnings/invalid-aria-prop

Conversation

@mohshbool

@mohshboolmohshbool commented Jun 29, 2019

Copy link
Copy Markdown
Contributor

done translating warnings/invalid-aria-prop.*

mohshbool
mohshbool commented Jun 29, 2019
View reviewed changes
Comment threadcontent/warnings/invalid-aria-prop.md Outdated
@netlify

netlifyBot commented Jun 29, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 175aa2e

https://deploy-preview-123--ar-reactjs.netlify.com

@tesseralistesseralis mentioned this pull request Jun 29, 2019
Closed
Fcmam5
Fcmam5 reviewed Jul 1, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my respect Mohammed! I really love what you're doing, especially when it comes to "make tashkeel" to the hard words.
I had some micro-suggestions 🔬 to fix when it's possible :)

Comment threadcontent/warnings/invalid-aria-prop.md Outdated
Comment threadcontent/warnings/invalid-aria-prop.md Outdated
@mohshbool@Fcmam5
remove unnecessary space
3fc4e93
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@iRayan7

iRayan7 commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Hi @Fcmam5, please review this PR and merge it after approving it.
make sure you checked out this note from #1

Warnings
These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.

Thanks.

mohshbool
mohshbool commented Jul 2, 2019
View reviewed changes
Comment threadcontent/warnings/invalid-aria-prop.md Outdated
@mohshbool

mohshbool commented Jul 2, 2019

Copy link
Copy Markdown
ContributorAuthor

@Fcmam5 I think it's done now 😄

@Fcmam5
Fcmam5 merged commit 83b25d9 into reactjs:masterJul 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Fcmam5Fcmam5Fcmam5 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Fcmam5Fcmam5

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohshbool@iRayan7@Fcmam5