Skip to content

[DONE] hello-world.md .. - #125

Merged
3imed-jaberi merged 11 commits into
reactjs:masterfrom
maskeddeveloper:hello-world-translation
Jul 26, 2019
Merged

[DONE] hello-world.md .. #125
3imed-jaberi merged 11 commits into
reactjs:masterfrom
maskeddeveloper:hello-world-translation

Conversation

@maskeddeveloper

@maskeddevelopermaskeddeveloper commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented Jul 2, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 44a5980

https://deploy-preview-125--ar-reactjs.netlify.com

@3imed-jaberi

3imed-jaberi commented Jul 21, 2019

Copy link
Copy Markdown
Contributor

Hi @maskeddeveloper 👋 any updates on this?

@3imed-jaberi3imed-jaberi added the update needed This PR needs update since last commit label Jul 21, 2019
Aissaoui-Ahmed
Aissaoui-Ahmed reviewed Jul 21, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md
@maskeddeveloper

maskeddeveloper commented Jul 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@3imed-jaberi Today i'll commit

@maskeddeveloper

maskeddeveloper commented Jul 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@3imed-jaberi it's done , i'm open for review.
Sorry to be so late, lot of wooork

@maskeddeveloper

maskeddeveloper commented Jul 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@Aissaoui-Ahmed yes i did correct that, thanx for your comment

@maskeddevelopermaskeddeveloper changed the title [Work in progress] Hello World[DONE] Hello WorldJul 23, 2019
@mohshboolmohshbool added in-review and removed update needed This PR needs update since last commit work-in-progress labels Jul 23, 2019
mohshbool
mohshbool suggested changes Jul 23, 2019
View reviewed changes

@mohshboolmohshbool left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @maskeddeveloper
amazing work, really
please, allow me to make these suggestions, they're just small fixes

Comment threadcontent/docs/hello-world.md
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
@mohshboolmohshbool added changes-requested update needed This PR needs update since last commit and removed in-review labels Jul 23, 2019
@maskeddeveloper

maskeddeveloper commented Jul 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@moshbool i'll be making the changes ASAP

@3imed-jaberi3imed-jaberi self-assigned this Jul 23, 2019
3imed-jaberi
3imed-jaberi suggested changes Jul 23, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @maskeddeveloper ..
thanks you for your contribution in react community 🎖 ..

i will add this nano bug to the suggestions ..

Comment threadcontent/docs/hello-world.md Outdated
```js
ReactDOM.render(
<h1>Hello, world!</h1>,
<h1>مرحبا بالعالم!</h1>,

@3imed-jaberi3imed-jaberiJul 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

أهلا بالعالم ✔️ ..

@3imed-jaberi3imed-jaberiJul 24, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maskeddeveloper ,
لماذا لم تغيرها !

maskeddeveloperand others added 6 commits July 24, 2019 10:01
@maskeddeveloper@mohshbool
Update content/docs/hello-world.md
f9784cf
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper@mohshbool
Update content/docs/hello-world.md
b451a1c
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper@mohshbool
Update content/docs/hello-world.md
5379d3a
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper@mohshbool
Update content/docs/hello-world.md
00b70af
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper@mohshbool
Update content/docs/hello-world.md
ca9bb26
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper@mohshbool
Update content/docs/hello-world.md
fd57593
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@maskeddeveloper

maskeddeveloper commented Jul 24, 2019

Copy link
Copy Markdown
ContributorAuthor

@mohshbool@3imed-jaberi , i think it's good

3imed-jaberi
3imed-jaberi suggested changes Jul 24, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

يجب عليك تغييرها !! ظننت انك قمت بتغييرها لذلك صادقت على مسهمتك ..

Comment threadcontent/docs/hello-world.md Outdated
```js
ReactDOM.render(
<h1>Hello, world!</h1>,
<h1>مرحبا بالعالم!</h1>,

@3imed-jaberi3imed-jaberiJul 24, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maskeddeveloper ,
لماذا لم تغيرها !

@maskeddeveloper

maskeddeveloper commented Jul 26, 2019

Copy link
Copy Markdown
ContributorAuthor

@3imed-jaberi Could you please check again i don't know why it didn't change
i added another commit for that

@mohshboolmohshbool added approved and removed changes-requested update needed This PR needs update since last commit labels Jul 26, 2019
@mohshbool

mohshbool commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

🎉

3imed-jaberi
3imed-jaberi approved these changes Jul 26, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bro 🚀 ..

@3imed-jaberi3imed-jaberi changed the title [DONE] Hello World[DONE] hello-world.md .. Jul 26, 2019
@3imed-jaberi
3imed-jaberi merged commit 1784b0b into reactjs:masterJul 26, 2019
@tesseralistesseralis mentioned this pull request Jul 26, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@Aissaoui-AhmedAissaoui-AhmedAissaoui-Ahmed left review comments
@mohshboolmohshboolmohshbool approved these changes
@3imed-jaberi3imed-jaberi3imed-jaberi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mohshboolmohshbool

@3imed-jaberi3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maskeddeveloper@3imed-jaberi@mohshbool@Aissaoui-Ahmed@mhamime