Skip to content

[Done] Translation of tutorial/nav.yml .. - #136

Merged
mohshbool merged 4 commits into
reactjs:masterfrom
3imed-jaberi:tutorial-nav
Jul 20, 2019
Merged

[Done] Translation of tutorial/nav.yml ..#136
mohshbool merged 4 commits into
reactjs:masterfrom
3imed-jaberi:tutorial-nav

Conversation

@3imed-jaberi

@3imed-jaberi3imed-jaberi commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Jul 12, 2019
Closed
@netlify

netlifyBot commented Jul 12, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 6ef1534

https://deploy-preview-136--ar-reactjs.netlify.com

Aissaoui-Ahmed
Aissaoui-Ahmed suggested changes Jul 12, 2019
View reviewed changes
Comment threadcontent/tutorial/nav.yml
Comment threadcontent/tutorial/nav.yml Outdated
Comment threadcontent/tutorial/nav.yml Outdated
Comment threadcontent/tutorial/nav.yml
Comment threadcontent/tutorial/nav.yml
Comment threadcontent/tutorial/nav.yml Outdated
Comment threadcontent/tutorial/nav.yml
@3imed-jaberi

3imed-jaberi commented Jul 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi @Aissaoui-Ahmed ,
Thanks for your suggestions ❤️ ..
Please add this translation and associated terms to the glossary issue #122 for discussion ...

@celyes

celyes commented Jul 14, 2019

Copy link
Copy Markdown

@3imed-jaberi I can review any upcoming pull requests, add me if you want.

@3imed-jaberi
3imed-jaberi requested review from Fcmam5 and mohshbool and removed request for Fcmam5 and iRayan7July 18, 2019 00:05
mohshbool
mohshbool suggested changes Jul 19, 2019
View reviewed changes

@mohshboolmohshbool left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please allow me to make these little suggestions, other than them, I think you did a great a job! Keep it up 👏👏

Comment threadcontent/tutorial/nav.yml
Comment threadcontent/tutorial/nav.yml Outdated
Comment threadcontent/tutorial/nav.yml Outdated
3imed-jaberiand others added 2 commits July 19, 2019 23:58
@3imed-jaberi@mohshbool
fix line 80 - better expression ..
73e4b86
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@3imed-jaberi@mohshbool
fix ligne 68 - better exp ...
6ef1534
Co-Authored-By: Mohammad Shbool <alshboolmoh@gmail.com>
@mohshbool
mohshbool merged commit 3981062 into reactjs:masterJul 20, 2019
@mohshbool

mohshbool commented Jul 20, 2019

Copy link
Copy Markdown
Contributor

🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Aissaoui-AhmedAissaoui-AhmedAissaoui-Ahmed approved these changes
@mohshboolmohshboolmohshbool approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mohshboolmohshbool

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@3imed-jaberi@celyes@mohshbool@Aissaoui-Ahmed@iRayan7