Skip to content

[DONE] Update content/community/nav.yml - #144

Merged
3imed-jaberi merged 1 commit into
reactjs:masterfrom
Aissaoui-Ahmed:nan.yml
Jul 31, 2019
Merged

[DONE] Update content/community/nav.yml#144
3imed-jaberi merged 1 commit into
reactjs:masterfrom
Aissaoui-Ahmed:nan.yml

Conversation

@Aissaoui-Ahmed

@Aissaoui-AhmedAissaoui-Ahmed commented Jul 22, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

hi everyone !

translate file content/community/nav.yml

@Aissaoui-AhmedAissaoui-Ahmed mentioned this pull request Jul 22, 2019
Closed
20 tasks
@Aissaoui-AhmedAissaoui-Ahmed changed the title [DONE]Update nav.yml[DONE] Update content/community/nav.ymlJul 22, 2019
Fcmam5
Fcmam5 suggested changes Jul 22, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ahmed, thank you very much and congrats for this first contribution 😄 !
Please review the translations, some of my comments only suggest adding "ال" .
Please, feel free to discuss any suggestion you don't feel convinced of it :)

Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml
Comment threadcontent/community/nav.yml Outdated
@mohshboolmohshbool added update needed This PR needs update since last commit in-review labels Jul 22, 2019
@netlify

netlifyBot commented Jul 22, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit a9831a0

https://deploy-preview-144--ar-reactjs.netlify.com

@mohshboolmohshbool removed the update needed This PR needs update since last commit label Jul 22, 2019
3imed-jaberi
3imed-jaberi suggested changes Jul 27, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution ❤️ ..

I have suggested some modifications ... you can check them 💯 ..

Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
@3imed-jaberi3imed-jaberi added update needed This PR needs update since last commit work-in-progress and removed in-review labels Jul 29, 2019
Fcmam5
Fcmam5 suggested changes Jul 29, 2019
View reviewed changes
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
Fcmam5
Fcmam5 suggested changes Jul 30, 2019
View reviewed changes
Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/community/nav.yml Outdated
@Aissaoui-Ahmed

Aissaoui-Ahmed commented Jul 30, 2019

Copy link
Copy Markdown
ContributorAuthor

done!

@3imed-jaberi
3imed-jaberi removed the request for review from mohshboolJuly 30, 2019 23:32
Fcmam5
Fcmam5 approved these changes Jul 31, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ahmed! We are good to go 🚀

@3imed-jaberi3imed-jaberi added approved and removed in-review update needed This PR needs update since last commit labels Jul 31, 2019
@3imed-jaberi
3imed-jaberi merged commit e39a59b into reactjs:masterJul 31, 2019
@Aissaoui-Ahmed
Aissaoui-Ahmed deleted the nan.yml branch August 4, 2019 15:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Fcmam5Fcmam5Fcmam5 approved these changes
@3imed-jaberi3imed-jaberi3imed-jaberi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Fcmam5Fcmam5

@3imed-jaberi3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aissaoui-Ahmed@Fcmam5@3imed-jaberi@mohshbool