Skip to content

[Done] Translation courses.md - @Moast - #148

Merged
3imed-jaberi merged 6 commits into
reactjs:masterfrom
moast:moast-react-branch
Jul 31, 2019
Merged

[Done] Translation courses.md - @Moast#148
3imed-jaberi merged 6 commits into
reactjs:masterfrom
moast:moast-react-branch

Conversation

@3imed-jaberi

@3imed-jaberi3imed-jaberi commented Jul 25, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@moast , thank you for your contribution ...

The next time , please create a Pull Request. If you don't know how to do this follow this video ..

@3imed-jaberi3imed-jaberi mentioned this pull request Jul 25, 2019
Closed
20 tasks
@netlify

netlifyBot commented Jul 25, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit f6cea75

https://deploy-preview-148--ar-reactjs.netlify.com

Aissaoui-Ahmed
Aissaoui-Ahmed suggested changes Jul 25, 2019
View reviewed changes
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
@moast

moast commented Jul 25, 2019

Copy link
Copy Markdown

Changed were added

3imed-jaberi
3imed-jaberi commented Jul 29, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moast
يجب عليك القيام بهذه التغيرات ... لكي يتمكن
netlify
من رفع تغيرات ..

Comment threadcontent/community/courses.md
Comment threadcontent/community/courses.md Outdated
@3imed-jaberi3imed-jaberi added changes-requested update needed This PR needs update since last commit work-in-progress and removed in-review labels Jul 29, 2019
@3imed-jaberi3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit work-in-progress labels Jul 29, 2019
Fcmam5
Fcmam5 suggested changes Jul 29, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Please review the comments I left and also, remove all إطار عمل React and replace it by simply React or مكتبة React. React is a library, not a framework (مكتبة وليست إطار عمل).
Also, there are some missing همزات, I highlighted some of them, so please review your translation :)

Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
Comment threadcontent/community/courses.md Outdated
@3imed-jaberi3imed-jaberi self-assigned this Jul 29, 2019
@3imed-jaberi

3imed-jaberi commented Jul 29, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you for your contribution!
Please review the comments I left and also, remove all إطار عمل React and replace it by simply React or مكتبة React. React is a library, not a framework (مكتبة وليست إطار عمل).
Also, there are some missing همزات, I highlighted some of them, so please review your translation :)

please @moast , check this ........

@Aissaoui-Ahmed

Aissaoui-Ahmed commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

I suggest "أداءة"

@3imed-jaberi
3imed-jaberi requested review from Fcmam5 and removed request for mohshboolJuly 30, 2019 23:34
@3imed-jaberi

3imed-jaberi commented Jul 30, 2019

Copy link
Copy Markdown
ContributorAuthor

I suggest "أداءة"

where ?

@Aissaoui-Ahmed

Aissaoui-Ahmed commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

framework > أداءة

Fcmam5
Fcmam5 approved these changes Jul 31, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this beauty: https://deploy-preview-148--ar-reactjs.netlify.com/community/courses.html 😄
Good job, and thank you @3imed-jaberi

Comment threadcontent/community/courses.md
@moast

moast commented Jul 31, 2019•
edited
Loading

Copy link
Copy Markdown

framework > أداءة

It's incorrect. It can be اداة

@3imed-jaberi
3imed-jaberi merged commit 72d4c75 into reactjs:masterJul 31, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@moastmoastmoast left review comments
@Fcmam5Fcmam5Fcmam5 approved these changes
@Aissaoui-AhmedAissaoui-AhmedAissaoui-Ahmed approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Fcmam5Fcmam5

@mohshboolmohshbool

@3imed-jaberi3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@3imed-jaberi@moast@Aissaoui-Ahmed@Fcmam5@mohshbool