Skip to content

[Done] Translation of videos.md .. - #156

Merged
3imed-jaberi merged 6 commits into
reactjs:masterfrom
3imed-jaberi:videos
Aug 4, 2019
Merged

[Done] Translation of videos.md ..#156
3imed-jaberi merged 6 commits into
reactjs:masterfrom
3imed-jaberi:videos

Conversation

@3imed-jaberi

@3imed-jaberi3imed-jaberi commented Aug 4, 2019

Copy link
Copy Markdown
Contributor

I don't know if should translate the titles or leave them like conf section.

@iRayan7iRayan7 mentioned this pull request Aug 4, 2019
Closed
20 tasks
@netlify

netlifyBot commented Aug 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 481094f

https://deploy-preview-156--ar-reactjs.netlify.com

@Fcmam5

Fcmam5 commented Aug 4, 2019

Copy link
Copy Markdown
Contributor

I don't know if should translate the titles or leave them like conf section.

I suggest keeping them without translation, the description is enough

Fcmam5
Fcmam5 suggested changes Aug 4, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Imed thanks again for your efforts, I left below some comments and suggestions. Also please uncomment and translate the video lengths like in the line 31.
Also, what do you think of translating titles that doesn't have the conference name or something, like those who have simple sentences like React and Flux: Building Applications with a Unidirectional Data Flow, Introduction to React ?

Comment threadcontent/community/videos.md
Comment threadcontent/community/videos.md Outdated
Comment threadcontent/community/videos.md Outdated
Comment threadcontent/community/videos.md Outdated
Comment threadcontent/community/videos.md Outdated
@3imed-jaberi3imed-jaberi changed the title Videos[Done] Translation of videos.md ..Aug 4, 2019
3imed-jaberiand others added 4 commits August 4, 2019 15:49
@3imed-jaberi@Fcmam5
make ssr to uppercase - line 36 ..
1b24d73
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi@Fcmam5
fix typo unders---- line 54 ..
6e60dd6
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi@Fcmam5
better for seo & clear - line 11 ..
9b3f9dc
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi
better expression - line 42 ..
481094f
@3imed-jaberi
3imed-jaberi merged commit e30a449 into reactjs:masterAug 4, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Fcmam5Fcmam5Fcmam5 approved these changes
@mohshboolmohshboolmohshbool approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Fcmam5Fcmam5

@mohshboolmohshbool

@3imed-jaberi3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@3imed-jaberi@Fcmam5@mohshbool