Skip to content

[DONE] Update tools-jsx.md - #157

Merged
3imed-jaberi merged 1 commit into
reactjs:masterfrom
Aissaoui-Ahmed:tools-jsx
Aug 17, 2019
Merged

[DONE] Update tools-jsx.md#157
3imed-jaberi merged 1 commit into
reactjs:masterfrom
Aissaoui-Ahmed:tools-jsx

Conversation

@Aissaoui-Ahmed

@Aissaoui-AhmedAissaoui-Ahmed commented Aug 4, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

translate file : content/community/tools-jsx.md
Ref : here

@netlify

netlifyBot commented Aug 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit d00a262

https://deploy-preview-157--ar-reactjs.netlify.com

@Aissaoui-AhmedAissaoui-Ahmed changed the title [WIP] Update tools-jsx.md[DONE] Update tools-jsx.mdAug 4, 2019
Fcmam5
Fcmam5 suggested changes Aug 5, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ahmed for your contribution.
I left some remarks and some suggestions please take a peek when you're free :)

Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md
@iRayan7iRayan7 mentioned this pull request Aug 6, 2019
Closed
20 tasks
@mohshboolmohshbool removed their assignment Aug 6, 2019
@mohshboolmohshbool added changes-requested update needed This PR needs update since last commit labels Aug 6, 2019
@iRayan7
iRayan7 requested a review from Fcmam5August 9, 2019 21:06
Fcmam5
Fcmam5 suggested changes Aug 10, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-review the suggestions, some of them are marked as resolved but it doesn't to be. Maybe because of that you're force-pushing your commits and that doesn't trigger netifly build.

Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md
3imed-jaberi
3imed-jaberi suggested changes Aug 10, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شكرا لك اخ @Aissaoui-Ahmed على مجهوداتك القيمة ❤️ ..

هناك بعض الاقترحات ارجو منك مراجعتها و شكرا لك 💯 ..

Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
3imed-jaberi
3imed-jaberi suggested changes Aug 10, 2019
View reviewed changes
Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
@Aissaoui-Ahmed

Aissaoui-Ahmed commented Aug 10, 2019

Copy link
Copy Markdown
ContributorAuthor

/cc @Fcmam5@3imed-jaberi

@3imed-jaberi

3imed-jaberi commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

please @Fcmam5 , check this then merge it or approve and let me merge it ...

Fcmam5
Fcmam5 suggested changes Aug 14, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know your time is valuable, so just bear with me another minute, please :)

Comment threadcontent/community/tools-jsx.md Outdated
Comment threadcontent/community/tools-jsx.md Outdated
@3imed-jaberi
3imed-jaberi merged commit af90bb1 into reactjs:masterAug 17, 2019
@Aissaoui-Ahmed
Aissaoui-Ahmed deleted the tools-jsx branch August 17, 2019 15:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Fcmam5Fcmam5Fcmam5 approved these changes
@3imed-jaberi3imed-jaberi3imed-jaberi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Fcmam5Fcmam5

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aissaoui-Ahmed@3imed-jaberi@Fcmam5@mohshbool