Skip to content

[DONE] Translation of tools-routing.md .. - #159

Merged
iRayan7 merged 7 commits into
reactjs:masterfrom
3imed-jaberi:routing
Aug 14, 2019
Merged

[DONE] Translation of tools-routing.md .. #159
iRayan7 merged 7 commits into
reactjs:masterfrom
3imed-jaberi:routing

Conversation

@3imed-jaberi

@3imed-jaberi3imed-jaberi commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented Aug 9, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 785eebb

https://deploy-preview-159--ar-reactjs.netlify.com

iRayan7
iRayan7 suggested changes Aug 10, 2019
View reviewed changes
Comment threadcontent/community/tools-routing.md Outdated
Aissaoui-Ahmed
Aissaoui-Ahmed reviewed Aug 10, 2019
View reviewed changes
Comment threadcontent/community/nav.yml
Aissaoui-Ahmed
Aissaoui-Ahmed suggested changes Aug 11, 2019
View reviewed changes
Comment threadcontent/community/tools-routing.md Outdated
Fcmam5
Fcmam5 suggested changes Aug 11, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my respect bro for your work 😎 !
I tried to help with some suggestions to commit by replacing route translation.

Comment threadcontent/community/nav.yml
Comment threadcontent/community/tools-routing.md Outdated
Comment threadcontent/community/tools-routing.md Outdated
Comment threadcontent/community/tools-routing.md Outdated
Comment threadcontent/community/tools-routing.md
3imed-jaberiand others added 3 commits August 11, 2019 18:35
@3imed-jaberi@Fcmam5
translate - line 19
98c3c2a
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi@Fcmam5
better expression - line 13
9ed1b5d
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi@Fcmam5
fix around routing - line 11
549ddf5
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi
3imed-jaberi requested review from Fcmam5 and iRayan7 and removed request for Fcmam5, iRayan7, mohshbool and splimterAugust 11, 2019 17:39
Fcmam5
Fcmam5 approved these changes Aug 11, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go Imed! I approve your PR, I just noticed a small typo if you can fix it that would be great

Comment threadcontent/community/tools-routing.md Outdated
Aissaoui-Ahmed
Aissaoui-Ahmed reviewed Aug 11, 2019
View reviewed changes
Comment threadcontent/community/tools-routing.md
@3imed-jaberi@Fcmam5
fix typo - line 9
785eebb
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@3imed-jaberi3imed-jaberi assigned iRayan7 and unassigned splimterAug 12, 2019
@iRayan7iRayan7 mentioned this pull request Aug 12, 2019
Closed
20 tasks
iRayan7
iRayan7 approved these changes Aug 14, 2019
View reviewed changes

@iRayan7iRayan7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@iRayan7
iRayan7 merged commit a1c0597 into reactjs:masterAug 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohshboolmohshboolAwaiting requested review from mohshbool
3 more reviewers
@Fcmam5Fcmam5Fcmam5 approved these changes
@Aissaoui-AhmedAissaoui-AhmedAissaoui-Ahmed requested changes
@iRayan7iRayan7iRayan7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@iRayan7iRayan7

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@3imed-jaberi@Fcmam5@Aissaoui-Ahmed@iRayan7@splimter