Skip to content

[Done] Translation of tools starter kits - #165

Merged
iRayan7 merged 16 commits into
reactjs:masterfrom
AzizAK:translation-of-tools-starter-kits
Aug 16, 2019
Merged

[Done] Translation of tools starter kits#165
iRayan7 merged 16 commits into
reactjs:masterfrom
AzizAK:translation-of-tools-starter-kits

Conversation

@AzizAK

@AzizAKAzizAK commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

Translate file: tools-starter-kits

@AzizAK

AzizAK commented Aug 14, 2019

Copy link
Copy Markdown
ContributorAuthor

I have suggestion to change 'أدوات البداية' to 'حزم البداية'

@netlify

netlifyBot commented Aug 14, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit a3dd03f

https://deploy-preview-165--ar-reactjs.netlify.com

@iRayan7iRayan7 mentioned this pull request Aug 15, 2019
Closed
20 tasks
@3imed-jaberi

3imed-jaberi commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

I have suggestion to change 'أدوات البداية' to 'حزم البداية'

عندما تتنهي من العمل سنراجع هذا و سنقوم بالنقاش حول تغيير العنوان ان كان هناك معارضيين ..

شكرا لك علي مساهمتك

@AzizAKAzizAK changed the title [WIP] Translation of tools starter kits[Done] Translation of tools starter kitsAug 15, 2019
Fcmam5
Fcmam5 suggested changes Aug 15, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe that this is your first contribution, it's so well done. We appreciate the effort you put in it by searching for terms and for struggling with the formatting issues :)

I had just some small remarks about some translations and some missing . at the end of the description of the tools in the first part.

دمت عزيزا يا عزيز :) شكرا لك على المساهمة

Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
AzizAKand others added 11 commits August 15, 2019 17:17
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
c7d7c0a
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
da80299
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
e4b3f03
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
0eb9bce
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
1d70d21
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
e05ef0f
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
3ca2c9c
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
162e00f
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
25ff02a
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
7413f25
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK@Fcmam5
Update content/community/tools-starter-kits.md
49480f4
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
@AzizAK

AzizAK commented Aug 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you very much Fortas for the kind words. And thanks for the feedback very helpful for the future translations, I will add any new word to the Glossary to keep tracking.

AzizAK
AzizAK commented Aug 15, 2019
View reviewed changes

@AzizAKAzizAK left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@3imed-jaberi
3imed-jaberi self-requested a review August 15, 2019 14:33
3imed-jaberi
3imed-jaberi suggested changes Aug 15, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

عمل رائع اخي و مبارك عليك مساهمتك الاولى معنا ✌️ ...
لدي بعض الإقترحات الصغيرة يجب عليك مراجعتها حتى لا نقع في اختلاف عند ترجمة بعض الكلمات ...

شكرا لك على مساهمتك 🚀 ..

Comment threadcontent/community/tools-starter-kits.md Outdated
Comment threadcontent/community/tools-starter-kits.md Outdated
@AzizAK

AzizAK commented Aug 15, 2019

Copy link
Copy Markdown
ContributorAuthor

تم تعديل جميع المراجعات السابقة.

Fcmam5
Fcmam5 approved these changes Aug 15, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock 🚀 !

@iRayan7

iRayan7 commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

I really like حزم البداية and I believe it's more accurate. Since kit is حزمة and أداة is actually tool.

iRayan7
iRayan7 suggested changes Aug 15, 2019
View reviewed changes
Comment threadcontent/community/tools-starter-kits.md Outdated
3imed-jaberi
3imed-jaberi approved these changes Aug 16, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job bro 🚀 ..

@AzizAK

AzizAK commented Aug 16, 2019

Copy link
Copy Markdown
ContributorAuthor

good job bro 🚀 ..

Thank you 👍

iRayan7
iRayan7 approved these changes Aug 16, 2019
View reviewed changes

@iRayan7iRayan7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@iRayan7
iRayan7 merged commit ce75e00 into reactjs:masterAug 16, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@Fcmam5Fcmam5Fcmam5 approved these changes
@iRayan7iRayan7iRayan7 approved these changes
@3imed-jaberi3imed-jaberi3imed-jaberi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AzizAK@3imed-jaberi@iRayan7@Fcmam5