Skip to content

[DONE] Translating testing overview - #195

Merged
Fcmam5 merged 6 commits into
reactjs:masterfrom
mohdule:translating-testing-overview
Nov 2, 2019
Merged

[DONE] Translating testing overview#195
Fcmam5 merged 6 commits into
reactjs:masterfrom
mohdule:translating-testing-overview

Conversation

@mohdule

@mohdulemohdule commented Oct 27, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented Oct 27, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 8d87dc2

https://deploy-preview-195--ar-reactjs.netlify.com

@Fcmam5Fcmam5 self-assigned this Oct 27, 2019
@tesseralistesseralis mentioned this pull request Oct 28, 2019
Closed
@mohdulemohdule changed the title [WIP] Translating testing overview[DONE] Translating testing overviewOct 28, 2019
@mohdule

mohdule commented Oct 31, 2019

Copy link
Copy Markdown
ContributorAuthor

I'm done 🙂

Fcmam5
Fcmam5 suggested changes Oct 31, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things to correct if you don't mind 😄, it's just about همزات and a comma فاصلة.
Also, please next time make sure to commit only the files that are related to your PR, like for this one other pages had changes, I guess that it's because of your linter/editor.

Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
@mohdule

mohdule commented Oct 31, 2019

Copy link
Copy Markdown
ContributorAuthor

Sure thing, no worries 🙂
should i remove all the همزات though ?

as for the linting issue, that's actually not my linter, i just ran yarn check-all as instructed on the repo's contribution guide.

3imed-jaberi
3imed-jaberi suggested changes Oct 31, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to correct all comma الفاصلة and you should also push only the file you selected ( PR ) ..

@3imed-jaberi3imed-jaberi self-assigned this Oct 31, 2019
@3imed-jaberi
3imed-jaberi requested review from Fcmam5 and removed request for Fcmam5October 31, 2019 23:55
Fcmam5
Fcmam5 approved these changes Nov 2, 2019
View reviewed changes

@Fcmam5Fcmam5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations Mohannad for your first contribution in ar.reactjs.org 👏 !

@Fcmam5
Fcmam5 merged commit 0cb0b36 into reactjs:masterNov 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@Fcmam5Fcmam5Fcmam5 approved these changes
@Aissaoui-AhmedAissaoui-AhmedAissaoui-Ahmed approved these changes
@3imed-jaberi3imed-jaberi3imed-jaberi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Fcmam5Fcmam5

@3imed-jaberi3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohdule@Fcmam5@Aissaoui-Ahmed@3imed-jaberi