Skip to content

Finish Translating Testing Environments - #202

Merged
Aissaoui-Ahmed merged 5 commits into
reactjs:masterfrom
mohamedsgap:translate-testing-env
Nov 30, 2019
Merged

Finish Translating Testing Environments#202
Aissaoui-Ahmed merged 5 commits into
reactjs:masterfrom
mohamedsgap:translate-testing-env

Conversation

@mohamedsgap

@mohamedsgapmohamedsgap commented Nov 27, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@mohamedsgap

mohamedsgap commented Nov 27, 2019

Copy link
Copy Markdown
ContributorAuthor

@3imed-jaberi@asantarissy Hey guys, I need your reviews for this pull request, I've just finished translating Testing Environemnts

@netlify

netlifyBot commented Nov 27, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit 5cdf49b

https://deploy-preview-202--ar-reactjs.netlify.com

@asantarissy
asantarissy self-requested a review November 28, 2019 08:22
@tesseralistesseralis mentioned this pull request Nov 28, 2019
Closed
@3imed-jaberi3imed-jaberi self-assigned this Nov 28, 2019
3imed-jaberi
3imed-jaberi suggested changes Nov 28, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @mohamedsgap 💪,
I have some suggestions to check then 🚀 ..

Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
@3imed-jaberi3imed-jaberi added changes-requested update needed This PR needs update since last commit and removed in-review labels Nov 28, 2019
@mohamedsgap

mohamedsgap commented Nov 28, 2019

Copy link
Copy Markdown
ContributorAuthor

@3imed-jaberi@asantarissy@Aissaoui-Ahmed improved the translation after the requested changes! please, check it out :)

@3imed-jaberi3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit labels Nov 28, 2019
3imed-jaberi
3imed-jaberi reviewed Nov 28, 2019
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @mohamedsgap, check all suggestion ...

@3imed-jaberi3imed-jaberi added changes-requested update needed This PR needs update since last commit and removed in-review labels Nov 28, 2019
Aissaoui-Ahmed
Aissaoui-Ahmed suggested changes Nov 29, 2019
View reviewed changes
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
@mohamedsgap

mohamedsgap commented Nov 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@Aissaoui-Ahmed@3imed-jaberi I've modified the translation guys! check it out ;)

Aissaoui-Ahmed
Aissaoui-Ahmed suggested changes Nov 29, 2019
View reviewed changes

@Aissaoui-AhmedAissaoui-Ahmed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove before
، to ،

Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
Comment threadcontent/docs/testing-environments.md Outdated
@mohamedsgap

mohamedsgap commented Nov 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@Aissaoui-Ahmed@3imed-jaberi I've made the last changed, check it out!!

@3imed-jaberi3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit labels Nov 30, 2019
@Aissaoui-Ahmed
Aissaoui-Ahmed merged commit 3b89a0d into reactjs:masterNov 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asantarissyasantarissyAwaiting requested review from asantarissy
3 more reviewers
@atefBBatefBBatefBB left review comments
@Aissaoui-AhmedAissaoui-AhmedAissaoui-Ahmed approved these changes
@3imed-jaberi3imed-jaberi3imed-jaberi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@3imed-jaberi3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mohamedsgap@atefBB@Aissaoui-Ahmed@3imed-jaberi@asantarissy