Skip to content

[DONE] Translated "Suspense for Data Fetching" - #208

Merged
Aissaoui-Ahmed merged 61 commits into
reactjs:masterfrom
mohamedsgap:suspense-for-data-fetching
Jan 5, 2020
Merged

[DONE] Translated "Suspense for Data Fetching"#208
Aissaoui-Ahmed merged 61 commits into
reactjs:masterfrom
mohamedsgap:suspense-for-data-fetching

Conversation

@mohamedsgap

@mohamedsgapmohamedsgap commented Dec 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Started translating "Suspense for Data Fetching", I wonder what is the most suitable word for translating suspense, I translated it to "التشويق" is it good ??

@asantarissy@iRayan7@aladin002dz@Fcmam5@mohshbool@3imed-jaberi@splimter@Aissaoui-Ahmed

@netlify

netlifyBot commented Dec 12, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ar-reactjs ready!

Built with commit de45610

https://deploy-preview-208--ar-reactjs.netlify.com

@tesseralistesseralis mentioned this pull request Dec 12, 2019
Closed
@Fcmam5

Fcmam5 commented Dec 16, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

I suggest to not translate Suspense word. IMO it's a technical word and translating it will make things confusing.
Also, please refere to @aissa-bouguern's great article: https://www.tutomena.com/react-suspense/.
Last thing, please merge master to your branch and fix the possible conflict after merging #209 .

@mohamedsgap

mohamedsgap commented Dec 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@Fcmam5 Okay it sounds clear, I gonna fix it

@mohamedsgap

mohamedsgap commented Dec 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@Fcmam5 I fixed the merge conflict and correct Suspense word in my translation! :)

@mohamedsgap
mohamedsgapforce-pushed the suspense-for-data-fetching branch from e6c6332 to 47e276bCompareDecember 28, 2019 04:12
@mohamedsgap

mohamedsgap commented Dec 28, 2019

Copy link
Copy Markdown
ContributorAuthor

I've just finished translated the most challenging page I've ever translated "Suspense for data fetching", I need your review, guys! :)
@asantarissy@iRayan7@aladin002dz@Fcmam5@mohshbool@3imed-jaberi@splimter@Aissaoui-Ahmed

@mohamedsgapmohamedsgap changed the title WIP: started translating suspense for data fetchingtranslated "Suspense for Data Fetching"Dec 28, 2019
@Aissaoui-AhmedAissaoui-Ahmed changed the title translated "Suspense for Data Fetching"[DONE] Translated "Suspense for Data Fetching"Dec 29, 2019
Aissaoui-Ahmed
Aissaoui-Ahmed reviewed Dec 29, 2019
View reviewed changes
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Aissaoui-Ahmed
Aissaoui-Ahmed reviewed Dec 29, 2019
View reviewed changes
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Aissaoui-Ahmed
Aissaoui-Ahmed reviewed Dec 29, 2019
View reviewed changes
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
@Aissaoui-Ahmed

Aissaoui-Ahmed commented Dec 29, 2019

Copy link
Copy Markdown
Contributor
شكرا @mohamedsgap على المساهمة الرائعة؟

@3imed-jaberi3imed-jaberi added in-review and removed changes-requested update needed This PR needs update since last commit labels Dec 31, 2019
Fcmam5
Fcmam5 suggested changes Dec 31, 2019
View reviewed changes
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
@mohamedsgap@Fcmam5
Update content/docs/concurrent-mode-suspense.md
4b63fd6
improved arabic syntax
Co-Authored-By: Fortas Abdeldjalil <dr.fcmam5@gmail.com>
atefBB
atefBB suggested changes Jan 1, 2020
View reviewed changes
Comment threadcontent/docs/concurrent-mode-suspense.md
Comment threadcontent/docs/concurrent-mode-suspense.md
Comment threadcontent/docs/concurrent-mode-suspense.md
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Aissaoui-Ahmed
Aissaoui-Ahmed approved these changes Jan 1, 2020
View reviewed changes

@Aissaoui-AhmedAissaoui-Ahmed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

من بعد @atefBB

3imed-jaberi
3imed-jaberi suggested changes Jan 1, 2020
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

أسف اخي على المراجعة المتقطعة ...

لاننا نسعى ان تكون الترجمة ذات جودة ... اتمنى ان تقوم بتغيير كل كلمة من النهج إلى المنهج ..

Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
@3imed-jaberi3imed-jaberi added changes-requested update needed This PR needs update since last commit and removed in-review labels Jan 1, 2020
mohamedsgapand others added 3 commits January 2, 2020 21:39
@mohamedsgap@3imed-jaberi
Update content/docs/concurrent-mode-suspense.md
89c267f
Co-Authored-By: imed jaberi <imed_jebari@hotmail.fr>
@mohamedsgap@3imed-jaberi
Update content/docs/concurrent-mode-suspense.md
658e3fe
Co-Authored-By: imed jaberi <imed_jebari@hotmail.fr>
@mohamedsgap@3imed-jaberi
Update content/docs/concurrent-mode-suspense.md
d90e20d
Co-Authored-By: imed jaberi <imed_jebari@hotmail.fr>
@3imed-jaberi

3imed-jaberi commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

أسف اخي على المراجعة المتقطعة ...
لاننا نسعى ان تكون الترجمة ذات جودة ... اتمنى ان تقوم بتغيير كل كلمة من النهج إلى المنهج ..

@mohamedsgap , اتمنى ان تقوم بتغيير كل كلمة من النهج إلى المنهج ..

@mohamedsgap

mohamedsgap commented Jan 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Done with the latest suggested changes!! @3imed-jaberi

@3imed-jaberi

3imed-jaberi commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

Done with the latest suggested changes!! @3imed-jaberi

image

@mohamedsgap

mohamedsgap commented Jan 3, 2020

Copy link
Copy Markdown
ContributorAuthor

fixedError
@3imed-jaberi What do you think now?? ;)

@mohamedsgap

mohamedsgap commented Jan 4, 2020

Copy link
Copy Markdown
ContributorAuthor

any update ??? @3imed-jaberi

3imed-jaberi
3imed-jaberi approved these changes Jan 5, 2020
View reviewed changes

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, finally 🚀 ..

@3imed-jaberi

3imed-jaberi commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

@atefBB , الرجاء فتح طلب سحب لكل الاخطاء اللغوية اظن اننا استغرقنا وقت كثير في هذا الطلب ..

@3imed-jaberi3imed-jaberi added approved and removed changes-requested update needed This PR needs update since last commit labels Jan 5, 2020
@Aissaoui-Ahmed
Aissaoui-Ahmed merged commit 11daf83 into reactjs:masterJan 5, 2020
@atefBB

atefBB commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

@3imed-jaberi

سأفعل عندنا أحصل على بعض الوقت إن شاء الله.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fcmam5Fcmam5Awaiting requested review from Fcmam5
3 more reviewers
@atefBBatefBBatefBB requested changes
@Aissaoui-AhmedAissaoui-AhmedAissaoui-Ahmed approved these changes
@3imed-jaberi3imed-jaberi3imed-jaberi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Aissaoui-AhmedAissaoui-Ahmed

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mohamedsgap@Fcmam5@Aissaoui-Ahmed@3imed-jaberi@atefBB