Skip to content

Translating tutorial.md - #4

Closed
Emmanuel-Melon wants to merge 1 commit into
reactjs:masterfrom
Emmanuel-Melon:translate-tutorial-page
Closed

Translating tutorial.md#4
Emmanuel-Melon wants to merge 1 commit into
reactjs:masterfrom
Emmanuel-Melon:translate-tutorial-page

Conversation

@Emmanuel-Melon

@Emmanuel-MelonEmmanuel-Melon commented Feb 12, 2019

Copy link
Copy Markdown

No description provided.

@tesseralistesseralis mentioned this pull request Feb 12, 2019
Closed
@iRayan7

iRayan7 commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Hey Emmanuel, thanks for starting!
I would highly recommend waiting for review before merging your pr.
Thanks 🙏

@asantarissy

asantarissy commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

@Emmanuel-Melon what's the status on this?

@Emmanuel-Melon

Emmanuel-Melon commented Feb 17, 2019

Copy link
Copy Markdown
Author

@Emmanuel-Melon what's the status on this?

Almost done, will push code soon.

@asantarissy

asantarissy commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

Hello @Emmanuel-Melon, @iRayan7 created a new Glossary wiki, please use it as a reference and keep checking it as it's WIP.

Cheers!

@Emmanuel-MelonEmmanuel-Melon mentioned this pull request Feb 23, 2019
Merged
@asantarissyasantarissy changed the title Switched repository && started translating tutorial pageTranslating tutorial.mdFeb 23, 2019
@asantarissy

asantarissy commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

Hello @Emmanuel-Melon, anything on this, should we assign it to another contributor?

@Emmanuel-Melon

Emmanuel-Melon commented Mar 17, 2019 via email

Copy link
Copy Markdown
Author

@Emmanuel-Melon

Emmanuel-Melon commented Mar 17, 2019 via email

Copy link
Copy Markdown
Author

@iRayan7
iRayan7 self-requested a review March 24, 2019 06:35
@iRayan7

iRayan7 commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

Hi @Emmanuel-Melon, any updates on this PR?

@Emmanuel-Melon

Emmanuel-Melon commented Apr 11, 2019 via email

Copy link
Copy Markdown
Author

@Emmanuel-Melon

Emmanuel-Melon commented Apr 11, 2019 via email

Copy link
Copy Markdown
Author

@iRayan7

iRayan7 commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @Emmanuel-Melon 🙏

@iRayan7

iRayan7 commented Apr 20, 2019

Copy link
Copy Markdown
Contributor

Hi @Emmanuel-Melon, please make sure to update your translation according to Hsoub's https://wiki.hsoub.com/React/tutorial

@Emmanuel-Melon

Emmanuel-Melon commented Apr 20, 2019

Copy link
Copy Markdown
Author

Hi @Emmanuel-Melon, please make sure to update your translation according to Hsoub's https://wiki.hsoub.com/React/tutorial

Sure thing, I'm having issues with RTL support. Has it been added?

@aladin002dz

aladin002dz commented Apr 20, 2019

Copy link
Copy Markdown
Contributor

Hi @Emmanuel-Melon, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial

Sure thing, I'm having issues with RTL support. Has it been added?

yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor

@Emmanuel-Melon

Emmanuel-Melon commented Apr 20, 2019 via email

Copy link
Copy Markdown
Author

@aladin002dz

aladin002dz commented Apr 20, 2019

Copy link
Copy Markdown
Contributor

I'm using WebStorm and it has support for RTL but text looks disoriented when I run the server and view the pages on my browser, is that normal?
…
On Sat, Apr 20, 2019 at 12:12 PM Mahfoudh Arous @.***> wrote: Hi @Emmanuel-Melon <@Emmanuel-Melon>, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial Sure thing, I'm having issues with RTL support. Has it been added? yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <github.com/notifications/unsubscribe-auth/AFAKVJAWZJMNPDA67IXXRZTPRLNATANCNFSM4GW62OKA> .

if you are on windows, try notepad++, I don't have issues with it

@Emmanuel-Melon

Emmanuel-Melon commented Apr 20, 2019

Copy link
Copy Markdown
Author

I'm using WebStorm and it has support for RTL but text looks disoriented when I run the server and view the pages on my browser, is that normal?
…
On Sat, Apr 20, 2019 at 12:12 PM Mahfoudh Arous @.***> wrote: Hi @Emmanuel-Melon <@Emmanuel-Melon>, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial Sure thing, I'm having issues with RTL support. Has it been added? yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <github.com/notifications/unsubscribe-auth/AFAKVJAWZJMNPDA67IXXRZTPRLNATANCNFSM4GW62OKA> .

if you are on windows, try notepad++, I don't have issues with it

I'm done translating. Only adding links and checking out for typos.
Text still looks like this on my browser. Can I push my changes or there's something that I need to do?
Screenshot 2019-04-20 at 12 17 54

@aladin002dz

aladin002dz commented Apr 20, 2019

Copy link
Copy Markdown
Contributor

I'm using WebStorm and it has support for RTL but text looks disoriented when I run the server and view the pages on my browser, is that normal?
…
On Sat, Apr 20, 2019 at 12:12 PM Mahfoudh Arous @.***> wrote: Hi @Emmanuel-Melon <@Emmanuel-Melon>, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial Sure thing, I'm having issues with RTL support. Has it been added? yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <github.com/notifications/unsubscribe-auth/AFAKVJAWZJMNPDA67IXXRZTPRLNATANCNFSM4GW62OKA> .

if you are on windows, try notepad++, I don't have issues with it

I'm done translating. Only adding links and checking out for typos.
Text still looks like this on my browser. Can I push my changes or there's something that I need to do?
Screenshot 2019-04-20 at 12 17 54

may be, save the file you worked on then update your local repo: "git pull upstream" upstream is the original repo,

@iRayan7

iRayan7 commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

Hi @Emmanuel-Melon, any updates?

@iRayan7iRayan7 added the update needed This PR needs update since last commit label Jun 25, 2019
atefBB
atefBB reviewed Jun 26, 2019
View reviewed changes
Comment threadcontent/tutorial/tutorial.md
@@ -12,7 +12,7 @@ redirect_from:
- "docs/tutorial-zh-CN.html"

@atefBBatefBBApr 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing this link to "docs/tutorial-ar.html"?

@iRayan7

iRayan7 commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

@atefBB Would you like to translate this page? it's one of the most important ones. And I feel like you would do justice to it 👍

@atefBB

atefBB commented Jun 27, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@iRayan7 What is the progress of the actual translation of the file? I see @Emmanuel-Melon starting the translation ! Any updates/help?!

@iRayan7

iRayan7 commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

@atefBB I'm not sure. Open a new PR on it and I will assign it to you 👍

@iRayan7iRayan7 closed this Jun 27, 2019
@Emmanuel-Melon

Emmanuel-Melon commented Jun 27, 2019 via email

Copy link
Copy Markdown
Author

@atefBB

atefBB commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

Hi @Emmanuel-Melon ! Can you send you translation as PR to review it?

@atefBB

atefBB commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

@iRayan7 I think @Emmanuel-Melon still working on it !

@Emmanuel-Melon

Emmanuel-Melon commented Jun 27, 2019 via email

Copy link
Copy Markdown
Author

@Emmanuel-Melon

Emmanuel-Melon commented Jun 27, 2019 via email

Copy link
Copy Markdown
Author

@iRayan7

iRayan7 commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

@Emmanuel-Melon Sorry about your laptop 💔. If it would take a long time to do a complete do over, I would suggest @atefBB to do it.
What do you think guys?

@iRayan7iRayan7 reopened this Jun 28, 2019
@iRayan7iRayan7 closed this Jun 28, 2019
@Emmanuel-Melon

Emmanuel-Melon commented Jun 28, 2019 via email

Copy link
Copy Markdown
Author

@iRayan7

iRayan7 commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

@Emmanuel-Melon Are you going to do the complete page? or only some parts of it?
If not the complete page, I think @atefBB would do it completely, so share it with him so he can complete it.

@Emmanuel-Melon

Emmanuel-Melon commented Jun 28, 2019 via email

Copy link
Copy Markdown
Author

@iRayan7

iRayan7 commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

@Emmanuel-Melon Would like to complete it?

@Emmanuel-Melon

Emmanuel-Melon commented Jun 28, 2019 via email

Copy link
Copy Markdown
Author

@atefBB

atefBB commented Jun 28, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@iRayan7 I haven't a laptop to complete the translation, I have a bad ux with github in my phone, so I can't help in translation in my case, but still can review changes. Sorry for disappoint.

@iRayan7

iRayan7 commented Jun 29, 2019

Copy link
Copy Markdown
Contributor

Yes, I'd like to complete it. However, I'm going to be very during this upcoming week. Is it possible to do it after?

How many days will take you to complete the translation?

@Emmanuel-Melon

Emmanuel-Melon commented Jul 2, 2019

Copy link
Copy Markdown
Author

Yes, I'd like to complete it. However, I'm going to be very during this upcoming week. Is it possible to do it after?

How many days will take you to complete the translation?

2 days.

@iRayan7

iRayan7 commented Jul 5, 2019

Copy link
Copy Markdown
Contributor

Yes, I'd like to complete it. However, I'm going to be very during this upcoming week. Is it possible to do it after?

How many days will take you to complete the translation?

2 days.

Hi @Emmanuel-Melon, Any update?

@Emmanuel-Melon

Emmanuel-Melon commented Jul 5, 2019 via email

Copy link
Copy Markdown
Author

@iRayan7

iRayan7 commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

Ok @Emmanuel-Melon, I'm assigning it to another contributor 👍. Sorry for any inconvenience.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashrafdevmashrafdevAwaiting requested review from mashrafdev
@iRayan7iRayan7Awaiting requested review from iRayan7
1 more reviewer
@atefBBatefBBatefBB left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@iRayan7iRayan7

Labels

update neededThis PR needs update since last commitwork-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Emmanuel-Melon@iRayan7@asantarissy@aladin002dz@atefBB