Skip to content

Translate Design Principles - #169

Merged
GasimGasimzada merged 2 commits into
reactjs:masterfrom
mehdiyev:translate-design-principles
Jan 23, 2020
Merged

Translate Design Principles#169
GasimGasimzada merged 2 commits into
reactjs:masterfrom
mehdiyev:translate-design-principles

Conversation

@mehdiyev

@mehdiyevmehdiyev commented Jan 18, 2020•
edited by GasimGasimzada
Loading

Copy link
Copy Markdown
Contributor
  • Overview
  • Composition
  • Common Abstraction
  • Escape Hatches
  • Stability
  • Interoperability
  • Scheduling
  • Developer Experience
  • Debugging
  • Configuration
  • Beyond the DOM
  • Implementation
  • Optimized for Tooling
  • Dogfooding

https://deploy-preview-169--az-reactjs.netlify.com/docs/design-principles.html

@netlify

netlifyBot commented Jan 18, 2020•
edited
Loading

Copy link
Copy Markdown

Deploy preview for az-reactjs ready!

Built with commit 549a9bf

https://deploy-preview-169--az-reactjs.netlify.com

@GasimGasimzada

GasimGasimzada commented Jan 18, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

Thank you! I will review it tomorrow.

@tesseralistesseralis mentioned this pull request Jan 18, 2020
Closed
99 tasks
GasimGasimzada
GasimGasimzada requested changes Jan 20, 2020
View reviewed changes

@GasimGasimzadaGasimGasimzada left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mən "Konfiqurasiya" bölməsinə kimi yoxladım. Sabah qalan bölmələrə baxacağam. Siz hələlik yazdığım dəyişikliklərə baxın.

Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
@GasimGasimzada

GasimGasimzada commented Jan 20, 2020

Copy link
Copy Markdown
Collaborator

Please do not click "Resolve conversation" if you have not pushed changes or provided discussion for the requested changes. Otherwise, it is really hard to keep track of which changes are discussed, fixed, or resolved.

GasimGasimzada
GasimGasimzada requested changes Jan 22, 2020
View reviewed changes

@GasimGasimzadaGasimGasimzada left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have requested more changes. Please review them all of them and do the necessary changes (or discuss your decisions).

Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
@GasimGasimzada
GasimGasimzada merged commit 8592144 into reactjs:masterJan 23, 2020
@GasimGasimzada

GasimGasimzada commented Jan 23, 2020

Copy link
Copy Markdown
Collaborator

Merged! Thank you for your contributions!

@mehdiyev
mehdiyev deleted the translate-design-principles branch January 23, 2020 17:16
@GasimGasimzadaGasimGasimzada added this to the Contribution milestone Feb 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GasimGasimzadaGasimGasimzadaGasimGasimzada approved these changes
@azizaismayilovaazizaismayilovaAwaiting requested review from azizaismayilova

Assignees

@GasimGasimzadaGasimGasimzada

@azizaismayilovaazizaismayilova

Labels

None yet

Projects

None yet

Milestone

Contribution

Development

Successfully merging this pull request may close these issues.

3 participants

@mehdiyev@GasimGasimzada@azizaismayilova